chore(meta): make post-review gate coverage fail-closed

- Replace the post-review allowlist with a fail-closed denylist: default
  pathspec ":/" covers all tracked changes, default excludes are empty,
  and projects opt in via review.post_review_exclude_globs
- Drop the deprecated review.post_review_globs block from .agents/.airc.json
  and mirror the shared lib to templates/
- Add e2e tests for coverage expansion, package-lock.json default coverage,
  and project opt-in exclusion, plus two template parity guards

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Codex <noreply@openai.com>

Author: 3 people

.agents/.airc.json

@@ -103,20 +103,5 @@
   },
   "task": {
     "shortIdLength": 2
-  },
-  "review": {
-    "post_review_globs": [
-      ".agents/.airc.json",
-      ".agents/rules",
-      ".agents/scripts",
-      ".agents/skills",
-      ".agents/workflows",
-      ".git-hooks/pre-commit",
-      ".github/workflows",
-      "bin",
-      "lib",
-      "src",
-      "templates"
-    ]
   }
 }

.agents/scripts/lib/post-review-commit.js

@@ -3,25 +3,22 @@ import path from "node:path";
 
 import { artifactName, maxRound } from "./review-artifacts.js";
 
-export const DEFAULT_POST_REVIEW_GLOBS = [
-  ".agents/skills",
-  ".agents/scripts",
-  ".agents/rules",
-  ".agents/workflows",
-  "bin",
-  "lib",
-  "src",
-  "templates"
-];
-
+// Paths excluded from the post-review coverage gate. Fail-closed: the gate
+// covers ALL tracked changes by default. This default denylist is EMPTY —
+// projects opt into exclusions explicitly via review.post_review_exclude_globs.
+export const DEFAULT_POST_REVIEW_EXCLUDES = [];
+
+// Returns git pathspecs selecting "all tracked changes except project excludes".
+// The leading ":/" makes coverage fail-closed (everything from the repo root);
+// each exclude becomes a top-level negative pathspec. Projects extend the
+// denylist via review.post_review_exclude_globs (union, deduped).
 export function resolvePostReviewGlobs(config = {}, reviewConfig = {}) {
-  if (Array.isArray(config.post_review_globs)) {
-    return config.post_review_globs;
-  }
-  if (Array.isArray(reviewConfig.post_review_globs)) {
-    return reviewConfig.post_review_globs;
-  }
-  return DEFAULT_POST_REVIEW_GLOBS;
+  const projectExcludes = [
+    ...(Array.isArray(reviewConfig.post_review_exclude_globs) ? reviewConfig.post_review_exclude_globs : []),
+    ...(Array.isArray(config.post_review_exclude_globs) ? config.post_review_exclude_globs : [])
+  ];
+  const excludes = [...new Set([...DEFAULT_POST_REVIEW_EXCLUDES, ...projectExcludes])];
+  return [":/", ...excludes.map((p) => `:(top,exclude)${p}`)];
 }
 
 export function findAuthoritativeReviewCodeArtifact(taskDir) {

templates/.agents/scripts/lib/post-review-commit.js

@@ -3,25 +3,22 @@ import path from "node:path";
 
 import { artifactName, maxRound } from "./review-artifacts.js";
 
-export const DEFAULT_POST_REVIEW_GLOBS = [
-  ".agents/skills",
-  ".agents/scripts",
-  ".agents/rules",
-  ".agents/workflows",
-  "bin",
-  "lib",
-  "src",
-  "templates"
-];
-
+// Paths excluded from the post-review coverage gate. Fail-closed: the gate
+// covers ALL tracked changes by default. This default denylist is EMPTY —
+// projects opt into exclusions explicitly via review.post_review_exclude_globs.
+export const DEFAULT_POST_REVIEW_EXCLUDES = [];
+
+// Returns git pathspecs selecting "all tracked changes except project excludes".
+// The leading ":/" makes coverage fail-closed (everything from the repo root);
+// each exclude becomes a top-level negative pathspec. Projects extend the
+// denylist via review.post_review_exclude_globs (union, deduped).
 export function resolvePostReviewGlobs(config = {}, reviewConfig = {}) {
-  if (Array.isArray(config.post_review_globs)) {
-    return config.post_review_globs;
-  }
-  if (Array.isArray(reviewConfig.post_review_globs)) {
-    return reviewConfig.post_review_globs;
-  }
-  return DEFAULT_POST_REVIEW_GLOBS;
+  const projectExcludes = [
+    ...(Array.isArray(reviewConfig.post_review_exclude_globs) ? reviewConfig.post_review_exclude_globs : []),
+    ...(Array.isArray(config.post_review_exclude_globs) ? config.post_review_exclude_globs : [])
+  ];
+  const excludes = [...new Set([...DEFAULT_POST_REVIEW_EXCLUDES, ...projectExcludes])];
+  return [":/", ...excludes.map((p) => `:(top,exclude)${p}`)];
 }
 
 export function findAuthoritativeReviewCodeArtifact(taskDir) {

tests/e2e/core/review-diff-fingerprint.test.ts

@@ -86,3 +86,47 @@ test("post-review globs are shared by the validator and fingerprint helper", ()
   assert.match(validator, /from "\.\/lib\/post-review-commit\.js"/);
   assert.match(validator, /resolvePostReviewGlobs\(config, loadReviewConfig\(\)\)/);
 });
+
+test("review diff fingerprint covers paths outside the legacy allowlist (fail-closed)", onPlatforms("linux", "darwin", "win32"), async () => {
+  await withTempRoot("agent-infra-fingerprint-failclosed-", (tempRoot) => {
+    const baseline = setupRepo(tempRoot);
+    const clean = fingerprint(tempRoot, "worktree", baseline);
+
+    write(path.join(tempRoot, "scripts/x.js"), "// new generator change\n");
+    const changed = fingerprint(tempRoot, "worktree", baseline);
+    assert.notEqual(changed, clean);
+  });
+});
+
+test("review diff fingerprint covers package-lock.json by default", onPlatforms("linux", "darwin", "win32"), async () => {
+  await withTempRoot("agent-infra-fingerprint-lockfile-", (tempRoot) => {
+    const baseline = setupRepo(tempRoot);
+    const clean = fingerprint(tempRoot, "worktree", baseline);
+
+    write(path.join(tempRoot, "package-lock.json"), "{}\n");
+    const changed = fingerprint(tempRoot, "worktree", baseline);
+    assert.notEqual(changed, clean);
+  });
+});
+
+test("review diff fingerprint honors project post_review_exclude_globs", onPlatforms("linux", "darwin", "win32"), async () => {
+  await withTempRoot("agent-infra-fingerprint-exclude-", (tempRoot) => {
+    setupRepo(tempRoot);
+    write(
+      path.join(tempRoot, ".agents/.airc.json"),
+      JSON.stringify({ review: { post_review_exclude_globs: ["package-lock.json"] } }, null, 2) + "\n"
+    );
+    git(tempRoot, ["add", ".agents/.airc.json"]);
+    git(tempRoot, ["commit", "-qm", "add exclude config"]);
+    const baseline = git(tempRoot, ["rev-parse", "HEAD"]);
+    const clean = fingerprint(tempRoot, "worktree", baseline);
+
+    write(path.join(tempRoot, "package-lock.json"), "{}\n");
+    const excluded = fingerprint(tempRoot, "worktree", baseline);
+    assert.equal(excluded, clean);
+
+    write(path.join(tempRoot, "scripts/included.js"), "// not excluded\n");
+    const included = fingerprint(tempRoot, "worktree", baseline);
+    assert.notEqual(included, clean);
+  });
+});

tests/e2e/core/validate-artifact-post-review-commit.test.ts

@@ -217,3 +217,29 @@ test("post-review-commit blocks when the task is not inside a git repository", o
     assert.equal(payload.status, "blocked");
   });
 });
+
+test("post-review-commit fails for a commit outside the legacy allowlist (fail-closed coverage)", onPlatforms("linux", "darwin", "win32"), async () => {
+  await withTempRoot("agent-infra-prc-failclosed-", (tempRoot) => {
+    const { taskDir } = setupRepo(tempRoot);
+    const baseline = commitCodePath(tempRoot, ".agents/skills/x.md", "base\n", "base");
+    write(path.join(taskDir, "task.md"), buildTask());
+    write(path.join(taskDir, "review-code.md"), buildReviewCode(baseline));
+    commitCodePath(tempRoot, "scripts/build-inline.js", "// generated\n", "post-review change to a previously-uncovered path");
+
+    const { payload } = runCheck(taskDir);
+    assert.equal(payload.status, "fail");
+  });
+});
+
+test("post-review-commit covers package-lock.json by default (no hardcoded exclusion)", onPlatforms("linux", "darwin", "win32"), async () => {
+  await withTempRoot("agent-infra-prc-lockfile-", (tempRoot) => {
+    const { taskDir } = setupRepo(tempRoot);
+    const baseline = commitCodePath(tempRoot, ".agents/skills/x.md", "base\n", "base");
+    write(path.join(taskDir, "task.md"), buildTask());
+    write(path.join(taskDir, "review-code.md"), buildReviewCode(baseline));
+    commitCodePath(tempRoot, "package-lock.json", "{}\n", "post-review lockfile bump");
+
+    const { payload } = runCheck(taskDir);
+    assert.equal(payload.status, "fail");
+  });
+});

tests/unit/templates/templates.test.ts

@@ -209,6 +209,8 @@ test("update-agent-infra template copies stay in sync with working files", () =>
     [".agents/skills/update-agent-infra/scripts/sync-templates.js", "templates/.agents/skills/update-agent-infra/scripts/sync-templates.js"],
     [".agents/scripts/validate-artifact.js", "templates/.agents/scripts/validate-artifact.js"],
     [".agents/scripts/lib/review-artifacts.js", "templates/.agents/scripts/lib/review-artifacts.js"],
+    [".agents/scripts/lib/post-review-commit.js", "templates/.agents/scripts/lib/post-review-commit.js"],
+    [".agents/scripts/review-diff-fingerprint.js", "templates/.agents/scripts/review-diff-fingerprint.js"],
     [".agents/workflows/feature-development.yaml", "templates/.agents/workflows/feature-development.en.yaml"],
     [".agents/workflows/bug-fix.yaml", "templates/.agents/workflows/bug-fix.en.yaml"],
     [".agents/workflows/refactoring.yaml", "templates/.agents/workflows/refactoring.en.yaml"],