Commit 2490e19
committed
fkclaude: prefer an application command over patching the core's touch handler
enterUf2Dfu() is declared in the core's public cores/nRF5/wiring.h, so an application can call it
directly - a MeshCore command "reboot to UF2" needs no core change at all. That is strictly better
than patching TinyUSB_Port_EnterDFU(), which changes what a 1200-baud touch means for every
application built on that core; since the touch is the normal Arduino upload path, on Windows a
removable drive would appear on every upload, with an indexer or antivirus scanning a freshly mounted
FAT volume while a serial DFU is in flight.
Recorded the measurement that argument needs: serial DFU does work with MSC mounted - the XIAO was
flashed from UF2 mode in 28.33 s, 928 marks, Device programmed. So MSC is a nuisance there, not a
breakage.
Also corrected an overstatement from the previous note. meshcore-dev/MeshCore is as much an upstream
as oltaco's bootloader; a command added there needs its own PR. The asymmetry that survives is the
cost of carrying the change until it lands - the command sits in a fork already maintained and built
from, while the core patch would need a fork of meshcore-dev/Adafruit_nRF52_Arduino and a re-pinned
platformio.ini, or PlatformIO overwrites it.
And the three routes are not redundant: an application command covers a running application, PR 47's
recovery covers an invalid one, and only PR 50 covers a bootloader already sitting in serial-only DFU.1 parent d86545d commit 2490e19
1 file changed
Lines changed: 31 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
152 | 183 | | |
153 | 184 | | |
154 | 185 | | |
| |||
0 commit comments