Use new/delete to manage the lifecycle of flagcxHostSemaphore to prevent memory leaks

Author: MC952-arch

flagcx/core/launch_kernel.h

@@ -36,9 +36,9 @@ void cpuAsyncLoad(void *args);
 void cpuAsyncLoadWithMaxSpinCount(void *args);
 
 struct flagcxHostSemaphore {
-  int start;   // started or not
-  int end;     // ended or not
-  int counter; // total operations to wait for inside the group
+  int start = 0;   // started or not
+  int end = 0;     // ended or not
+  int counter = 0; // total operations to wait for inside the group
   std::vector<flagcxEvent_t> events;
 
   ~flagcxHostSemaphore() {

flagcx/core/proxy.cc

@@ -198,9 +198,10 @@ static flagcxResult_t progressOps(struct flagcxProxyState *proxyState,
             } else {
               if (op->args.done == 1) {
                 // Let the last operation within the group release the semaphore
-                if (op->eventId >= (int)op->args.semaphore->events.size() - 1) {
+                if ((size_t)op->eventId >=
+                    op->args.semaphore->events.size() - 1) {
                   if (op->args.semaphore->pollEnd()) {
-                    free(op->args.semaphore);
+                    delete op->args.semaphore;
                     flagcxIntruQueueDelete(queue, op);
                     free(op);
                   }
@@ -231,9 +232,10 @@ static flagcxResult_t progressOps(struct flagcxProxyState *proxyState,
             } else {
               if (op->args.done == 1) {
                 // Let the last operation within the group release the semaphore
-                if (op->eventId >= (int)op->args.semaphore->events.size() - 1) {
+                if ((size_t)op->eventId >=
+                    op->args.semaphore->events.size() - 1) {
                   if (op->args.semaphore->pollEnd()) {
-                    free(op->args.semaphore);
+                    delete op->args.semaphore;
                     flagcxIntruQueueDelete(queue, op);
                     free(op);
                   }