Skip to content

Commit a480906

Browse files
author
chencjcj
committed
fix code format
1 parent 25a4d10 commit a480906

10 files changed

Lines changed: 421 additions & 332 deletions

File tree

flagcx/adaptor/include/ib_common.h

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
#define FLAGCX_IB_COMMON_H_
1111

1212
#include "flagcx_net.h"
13-
#include "net.h"
1413
#include "ibvcore.h"
14+
#include "net.h"
1515
#include <pthread.h>
1616
#include <stdint.h>
1717

@@ -57,7 +57,6 @@ struct flagcxIbStats {
5757
int fatalErrorCount;
5858
};
5959

60-
6160
struct flagcxIbDev {
6261
pthread_mutex_t lock;
6362
int device;
@@ -274,7 +273,6 @@ extern pthread_mutex_t flagcxIbLock;
274273
extern int flagcxIbRelaxedOrderingEnabled;
275274
extern pthread_t flagcxIbAsyncThread;
276275

277-
278276
// Parameter functions
279277
extern int64_t flagcxParamIbGidIndex(void);
280278
extern int64_t flagcxParamIbRoceVersionNum(void);
@@ -295,14 +293,24 @@ extern int64_t flagcxParamIbQpsPerConn(void);
295293
extern sa_family_t envIbAddrFamily(void);
296294
extern void *envIbAddrRange(sa_family_t af, int *mask);
297295
extern sa_family_t getGidAddrFamily(union ibv_gid *gid);
298-
extern bool matchGidAddrPrefix(sa_family_t af, void *prefix, int prefixlen, union ibv_gid *gid);
296+
extern bool matchGidAddrPrefix(sa_family_t af, void *prefix, int prefixlen,
297+
union ibv_gid *gid);
299298
extern bool configuredGid(union ibv_gid *gid);
300299
extern bool linkLocalGid(union ibv_gid *gid);
301300
extern bool validGid(union ibv_gid *gid);
302-
extern flagcxResult_t flagcxIbRoceGetVersionNum(const char *deviceName, int portNum, int gidIndex, int *version);
303-
extern flagcxResult_t flagcxUpdateGidIndex(struct ibv_context *context, uint8_t portNum, sa_family_t af, void *prefix, int prefixlen, int roceVer, int gidIndexCandidate, int *gidIndex);
304-
extern flagcxResult_t flagcxIbGetGidIndex(struct ibv_context *context, uint8_t portNum, int gidTblLen, int *gidIndex);
305-
extern flagcxResult_t flagcxIbGetPciPath(char *devName, char **path, int *realPort);
301+
extern flagcxResult_t flagcxIbRoceGetVersionNum(const char *deviceName,
302+
int portNum, int gidIndex,
303+
int *version);
304+
extern flagcxResult_t flagcxUpdateGidIndex(struct ibv_context *context,
305+
uint8_t portNum, sa_family_t af,
306+
void *prefix, int prefixlen,
307+
int roceVer, int gidIndexCandidate,
308+
int *gidIndex);
309+
extern flagcxResult_t flagcxIbGetGidIndex(struct ibv_context *context,
310+
uint8_t portNum, int gidTblLen,
311+
int *gidIndex);
312+
extern flagcxResult_t flagcxIbGetPciPath(char *devName, char **path,
313+
int *realPort);
306314
extern int flagcxIbWidth(int width);
307315
extern int flagcxIbSpeed(int speed);
308316
extern int flagcxIbRelaxedOrderingCapable(void);
@@ -319,7 +327,6 @@ extern flagcxResult_t flagcxIbGdrSupport(void);
319327
extern flagcxResult_t flagcxIbDmaBufSupport(int dev);
320328
extern flagcxResult_t flagcxIbFreeRequest(struct flagcxIbRequest *r);
321329

322-
323330
static_assert((sizeof(struct flagcxIbNetCommBase) % 32) == 0,
324331
"flagcxIbNetCommBase size must be 32-byte multiple to ensure "
325332
"fifo is at proper offset");
@@ -333,9 +340,9 @@ static_assert((offsetof(struct flagcxIbSendComm, wrs) % 32) == 0,
333340
"wrs must be 32-byte aligned");
334341
static_assert((offsetof(struct flagcxIbRecvComm, remFifo) % 32) == 0,
335342
"flagcxIbRecvComm fifo must be 32-byte aligned");
336-
static_assert(sizeof(struct flagcxIbHandle) < FLAGCX_NET_HANDLE_MAXSIZE,
337-
"flagcxIbHandle size must be smaller than FLAGCX_NET_HANDLE_MAXSIZE");
338-
343+
static_assert(
344+
sizeof(struct flagcxIbHandle) < FLAGCX_NET_HANDLE_MAXSIZE,
345+
"flagcxIbHandle size must be smaller than FLAGCX_NET_HANDLE_MAXSIZE");
339346

340347
static_assert(MAX_REQUESTS <= 256, "request id are encoded in wr_id and we "
341348
"need up to 8 requests ids per completion");

flagcx/adaptor/include/ucx_adaptor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
#ifdef USE_UCX
1313

1414
#include "check.h"
15-
#include "socket.h"
1615
#include "ib_common.h"
16+
#include "socket.h"
1717
#include <pthread.h>
1818
#include <ucp/api/ucp.h>
1919

flagcx/adaptor/net/ibrc_adaptor.cc

Lines changed: 13 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -8,25 +8,24 @@
88
#include "core.h"
99
#include "flagcx_common.h"
1010
#include "flagcx_net.h"
11+
#include "ib_common.h"
1112
#include "ibvwrap.h"
13+
#include "net.h"
1214
#include "param.h"
1315
#include "socket.h"
16+
#include "timer.h"
1417
#include "utils.h"
15-
#include "ib_common.h"
1618
#include <assert.h>
19+
#include <errno.h>
20+
#include <fcntl.h>
1721
#include <poll.h>
1822
#include <pthread.h>
1923
#include <stdio.h>
2024
#include <stdlib.h>
2125
#include <string.h>
26+
#include <sys/socket.h>
2227
#include <sys/types.h>
2328
#include <unistd.h>
24-
#include <errno.h>
25-
#include <fcntl.h>
26-
#include <sys/socket.h>
27-
#include "ib_common.h"
28-
#include "net.h"
29-
#include "timer.h"
3029

3130
char flagcxIbIfName[MAX_IF_NAME_SIZE + 1];
3231
union flagcxSocketAddress flagcxIbIfAddr;
@@ -56,7 +55,6 @@ struct flagcxIbDev flagcxIbDevs[MAX_IB_DEVS];
5655
pthread_mutex_t flagcxIbLock = PTHREAD_MUTEX_INITIALIZER;
5756
int flagcxIbRelaxedOrderingEnabled = 0;
5857

59-
6058
pthread_t flagcxIbAsyncThread;
6159
void *flagcxIbAsyncThreadMain(void *args) {
6260
struct flagcxIbDev *dev = (struct flagcxIbDev *)args;
@@ -217,9 +215,8 @@ bool validGid(union ibv_gid *gid) {
217215
return (configuredGid(gid) && !linkLocalGid(gid));
218216
}
219217

220-
flagcxResult_t flagcxIbRoceGetVersionNum(const char *deviceName,
221-
int portNum, int gidIndex,
222-
int *version) {
218+
flagcxResult_t flagcxIbRoceGetVersionNum(const char *deviceName, int portNum,
219+
int gidIndex, int *version) {
223220
char gidRoceVerStr[16] = {0};
224221
char roceTypePath[PATH_MAX] = {0};
225222
sprintf(roceTypePath, "/sys/class/infiniband/%s/ports/%d/gid_attrs/types/%d",
@@ -250,9 +247,8 @@ flagcxResult_t flagcxIbRoceGetVersionNum(const char *deviceName,
250247

251248
flagcxResult_t flagcxUpdateGidIndex(struct ibv_context *context,
252249
uint8_t portNum, sa_family_t af,
253-
void *prefix, int prefixlen,
254-
int roceVer, int gidIndexCandidate,
255-
int *gidIndex) {
250+
void *prefix, int prefixlen, int roceVer,
251+
int gidIndexCandidate, int *gidIndex) {
256252
union ibv_gid gid, gidCandidate;
257253
FLAGCXCHECK(flagcxWrapIbvQueryGid(context, portNum, *gidIndex, &gid));
258254
FLAGCXCHECK(flagcxWrapIbvQueryGid(context, portNum, gidIndexCandidate,
@@ -288,9 +284,8 @@ flagcxResult_t flagcxUpdateGidIndex(struct ibv_context *context,
288284
return flagcxSuccess;
289285
}
290286

291-
flagcxResult_t flagcxIbGetGidIndex(struct ibv_context *context,
292-
uint8_t portNum, int gidTblLen,
293-
int *gidIndex) {
287+
flagcxResult_t flagcxIbGetGidIndex(struct ibv_context *context, uint8_t portNum,
288+
int gidTblLen, int *gidIndex) {
294289
*gidIndex = flagcxParamIbGidIndex();
295290
if (*gidIndex >= 0) {
296291
return flagcxSuccess;
@@ -311,9 +306,7 @@ flagcxResult_t flagcxIbGetGidIndex(struct ibv_context *context,
311306
return flagcxSuccess;
312307
}
313308

314-
315-
flagcxResult_t flagcxIbGetPciPath(char *devName, char **path,
316-
int *realPort) {
309+
flagcxResult_t flagcxIbGetPciPath(char *devName, char **path, int *realPort) {
317310
char devicePath[PATH_MAX];
318311
snprintf(devicePath, PATH_MAX, "/sys/class/infiniband/%s/device", devName);
319312
char *p = realpath(devicePath, NULL);
@@ -610,7 +603,6 @@ flagcxResult_t flagcxIbInit() {
610603

611604
const char *reqTypeStr[] = {"Unused", "Send", "Recv", "Flush"};
612605

613-
614606
static void flagcxIbAddEvent(struct flagcxIbRequest *req, int devIndex,
615607
struct flagcxIbNetCommDevBase *base) {
616608
req->events[devIndex]++;

0 commit comments

Comments
 (0)