[KernelGen][MThreads] Add log10_ Moore Threads specialized operator - #299
[KernelGen][MThreads] Add log10_ Moore Threads specialized operator#299Yukun-Cui wants to merge 2 commits into
Conversation
|
/test | log10_:mthreads |
❌ On-demand test failedOperator: The test failed to complete. Check the workflow run for details. |
|
/test | log10_:mthreads |
1 similar comment
|
/test | log10_:mthreads |
Dongxu-H
left a comment
There was a problem hiding this comment.
PR has merge conflicts that must be resolved before merging. The mthreads ops init.py imports log10_ from both .log10 and .log10_ modules, which could cause confusion. Consider removing the duplicate import from .log10 if log10_ is intended to use the specialized implementation.
Dongxu-H
left a comment
There was a problem hiding this comment.
常数命名 LOG10_2 容易产生歧义,建议改为 LOG10_OF_2 或类似更清晰的名称。Arithmetic Mean Speedup 为 1.00x,几乎没有性能提升,请确认是否需要保留这个特化实现。
16699a8 to
74af0f9
Compare
Dongxu-H
left a comment
There was a problem hiding this comment.
In init.py, both from .log10 import log10, log10_, log10_out and from .log10_ import log10_ are imported. This creates duplicate imports of log10_ which could be confusing. The specialized backend log10_ should override the default one, but the import order matters. Consider removing log10_ from the log10 import line to make the override explicit.
…it__ The existing log10.py exports log10, log10_ and log10_out; the new specialized log10_.py also exports log10_. Import log10_ only from the new specialized module to drop the F811 redefinition.
|
/test | log10_:mthreads |
[KernelGen][MThreads] Add log10_ Moore Threads specialized operator
Summary
Add a Moore Threads (MUSA) specialized Triton kernel for
log10_, overriding the generic implementation viaruntime.replace_customized_ops(). Implements the log10 operation.Testing
tests/test_log10.py(-m log10_)GEMS_MTHREADS LOG10_debug logPerformance
Compared against the generic FlagGems implementation on Moore Threads (MUSA).
log10_
Files Changed
src/flag_gems/runtime/backend/_mthreads/ops/log10_.py: Moore Threads Triton kernel + fallbacksrc/flag_gems/runtime/backend/_mthreads/ops/__init__.py: Register import and__all__