Skip to content

Commit f45e9d0

Browse files
committed
remove custom lint
1 parent f4ae7cd commit f45e9d0

3 files changed

Lines changed: 63 additions & 62 deletions

File tree

.github/workflows/all_tests_common.yml

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -79,18 +79,11 @@ jobs:
7979
BUILD_ENV=$(yq '.build_env // {} | tojson(0)' "$CONFIG_FILE")
8080
echo "build_env=$BUILD_ENV" >> $GITHUB_OUTPUT
8181
82-
lint:
83-
name: lint
84-
needs:
85-
- checkout_and_config
86-
uses: ./.github/workflows/lint_common.yml
87-
8882
unit_tests:
8983
name: unit_tests
9084
if: inputs.run_unit_tests
9185
needs:
9286
- checkout_and_config
93-
- lint
9487
strategy:
9588
fail-fast: false
9689
matrix:
@@ -127,7 +120,6 @@ jobs:
127120
if: inputs.run_integration_tests
128121
needs:
129122
- checkout_and_config
130-
- lint
131123
- unit_tests_complete
132124
uses: ./.github/workflows/integration_tests_common.yml
133125
with:
@@ -162,7 +154,6 @@ jobs:
162154
shell: bash
163155
needs:
164156
- checkout_and_config
165-
- lint
166157
- unit_tests_complete
167158
- integration_tests_complete
168159
runs-on: ubuntu-latest
@@ -173,12 +164,6 @@ jobs:
173164
# Check all test jobs (skip if not run)
174165
failed=false
175166
176-
if [ "${{ needs.lint.result }}" != "success" ] && \
177-
[ "${{ needs.lint.result }}" != "skipped" ]; then
178-
echo "❌ Lint failed"
179-
failed=true
180-
fi
181-
182167
if [ "${{ needs.unit_tests_complete.result }}" != "success" ] && \
183168
[ "${{ needs.unit_tests_complete.result }}" != "skipped" ]; then
184169
echo "❌ Unit tests failed or cancelled: ${{ needs.unit_tests_complete.result }}"

.github/workflows/lint.yml

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
# Copyright (c) 2022-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
2+
#
3+
# See LICENSE for license information.
4+
5+
# A workflow to trigger lint tests on GitHub
6+
name: 'Lint'
7+
on:
8+
pull_request:
9+
workflow_dispatch:
10+
jobs:
11+
pytorch_cpplint:
12+
name: 'PyTorch C++'
13+
runs-on: ubuntu-latest
14+
steps:
15+
- name: Checkout
16+
uses: actions/checkout@v3
17+
- name: 'Lint'
18+
run: |
19+
sudo apt-get update
20+
sudo apt-get install pip -y
21+
export CPP_ONLY=1
22+
export TE_PATH=.
23+
bash ./qa/L0_pytorch_lint/test.sh
24+
pytorch_pylint:
25+
name: 'PyTorch Python'
26+
runs-on: ubuntu-latest
27+
steps:
28+
- name: 'Checkout'
29+
uses: actions/checkout@v3
30+
- name: 'Lint'
31+
run: |
32+
sudo apt-get update
33+
sudo apt-get install pip -y
34+
pip install torch numpy
35+
export PYTHON_ONLY=1
36+
export TE_PATH=.
37+
bash ./qa/L0_pytorch_lint/test.sh
38+
jax_cpplint:
39+
name: 'JAX C++'
40+
runs-on: ubuntu-latest
41+
steps:
42+
- name: 'Checkout'
43+
uses: actions/checkout@v3
44+
- name: 'Lint'
45+
run: |
46+
sudo apt-get update
47+
sudo apt-get install pip -y
48+
export CPP_ONLY=1
49+
export TE_PATH=.
50+
bash ./qa/L0_jax_lint/test.sh
51+
jax_pylint:
52+
name: 'JAX Python'
53+
runs-on: ubuntu-latest
54+
steps:
55+
- name: 'Checkout'
56+
uses: actions/checkout@v3
57+
- name: 'Lint'
58+
run: |
59+
sudo apt-get update
60+
sudo apt-get install pip -y
61+
export PYTHON_ONLY=1
62+
export TE_PATH=.
63+
bash ./qa/L0_jax_lint/test.sh

.github/workflows/lint_common.yml

Lines changed: 0 additions & 47 deletions
This file was deleted.

0 commit comments

Comments
 (0)