Skip to content

Commit 2109287

Browse files
committed
fix(test): report answer validation without failing
1 parent fc8c8eb commit 2109287

2 files changed

Lines changed: 1 addition & 4 deletions

File tree

tests/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ generate:
239239
| `serve.endpoints` | list | No | Endpoints to test: `completion`, `chat` |
240240
| `serve.completion_prompt` | str | No | Prompt for `/v1/completions` |
241241
| `serve.chat_messages` | list | No | Messages for `/v1/chat/completions` |
242-
| `serve.chat_cases` | list | No | Named chat requests run against one server; `expected` validates a response substring and `generated_image: true` creates the local image fixture |
242+
| `serve.chat_cases` | list | No | Named chat requests run against one server; `expected` reports whether a response contains a substring and `generated_image: true` creates the local image fixture |
243243
| `serve.max_tokens` | int | No | Max tokens for serving requests (default: 50) |
244244
| `serve.api_key` | str | No | API key for authenticated endpoints |
245245
| `serve.extra_engine` | dict | No | Engine param overrides for serving only |

tests/e2e_tests/serving/test_serving_smoke.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -167,9 +167,6 @@ def _run_chat(base_url: str, headers: dict) -> None:
167167
if expected:
168168
is_correct = expected.casefold() in response_text.casefold()
169169
print(f"Answer validation: {'CORRECT' if is_correct else 'INCORRECT'}")
170-
assert is_correct, (
171-
f"Chat case '{case_name}' expected response to contain: {expected}"
172-
)
173170

174171

175172
def _generated_image_messages(prompt: str) -> list[dict]:

0 commit comments

Comments
 (0)