refactor: replace print statements with logging

- xml_reader.py: Replace print to stderr with logger.warning
- glencoe_writer.py: Replace debug prints with logger.debug
- feature_cardinality_refactoring.py: Replace debug print with logger.debug

Author: jagalindo

flamapy/metamodels/fm_metamodel/transformations/glencoe_writer.py

@@ -1,11 +1,14 @@
 import json
+import logging
 import string
 from typing import Any
 
 from flamapy.core.models.ast import Node, ASTOperation
 from flamapy.core.transformations import ModelToText
 from flamapy.metamodels.fm_metamodel.models import FeatureModel, Feature, Constraint
 
+logger = logging.getLogger(__name__)
+
 
 class GlencoeWriter(ModelToText):
     CTC_TYPES = {
@@ -38,8 +41,8 @@ def transform(self) -> str:
 
 def _to_json(feature_model: FeatureModel) -> dict[str, Any]:
     result: dict[str, Any] = {}
-    print(f'-{feature_model.root.name}-')
-    print(f'-{safename(feature_model.root.name)}-')
+    logger.debug("Root name: %s", feature_model.root.name)
+    logger.debug("Safe root name: %s", safename(feature_model.root.name))
     result["id"] = f"FM_{safename(feature_model.root.name)}"
     result["name"] = f"FM_{safename(feature_model.root.name)}"
     result["features"] = _get_features_info(feature_model.get_features())

flamapy/metamodels/fm_metamodel/transformations/refactorings/feature_cardinality_refactoring.py

@@ -1,4 +1,5 @@
 import copy
+import logging
 from dataclasses import dataclass
 from typing import Any, cast
 
@@ -16,6 +17,8 @@
     RefactoringException
 )
 
+logger = logging.getLogger(__name__)
+
 
 @dataclass
 class CloneContext:
@@ -167,7 +170,8 @@ def contextualize_constraint(feature_model: FeatureModel,
                              features_names_map: dict[str, str]) -> Constraint:
     """Create a contextualized constraint for the given constraints according to the provided
     feature clone."""
-    print(f'Contextualizing constraint {constraint.name} for features {features_names_map}')
+    logger.debug("Contextualizing constraint %s for features %s",
+                 constraint.name, features_names_map)
     # Create a copy of the constraint
     new_constraint = copy.deepcopy(constraint)
     # Rename the constraint's name

flamapy/metamodels/fm_metamodel/transformations/xml_reader.py

@@ -1,4 +1,4 @@
-import sys
+import logging
 from typing import Optional
 from xml.etree import ElementTree
 
@@ -12,6 +12,8 @@
     Relation,
 )
 
+logger = logging.getLogger(__name__)
+
 
 class XMLReader(TextToModel):
 
@@ -39,7 +41,7 @@ def transform(self) -> FeatureModel:
                 ctc = self.parse_ctc(child)
                 feature_model.ctcs.append(ctc)
             else:
-                print("This XML contains non supported elements", file=sys.stderr)
+                logger.warning("This XML contains non supported elements")
 
         return feature_model
 
@@ -83,7 +85,7 @@ def parse_feature(self, element: ElementTree.Element, parent: Optional[Feature])
         feature = Feature(name, [], parent=parent)
 
         if name in self.name_feature:
-            print("This XML contains duplicated feature names", file=sys.stderr)
+            logger.warning("This XML contains duplicated feature names")
             raise DuplicatedFeature
 
         self.name_feature[name] = feature
@@ -113,7 +115,7 @@ def parse_relation(self, element: ElementTree.Element, parent: Feature) -> Relat
                     relation.card_min = int(str(child.attrib.get('min')))
                     relation.card_max = int(str(child.attrib.get('max')))
                 else:
-                    print("This XML contains non supported elements", file=sys.stderr)
+                    logger.warning("This XML contains non supported elements")
 
         elif element.tag.casefold() == 'setrelation':
             for child in element:
@@ -124,7 +126,7 @@ def parse_relation(self, element: ElementTree.Element, parent: Feature) -> Relat
                     relation.card_min = int(str(child.attrib.get('min')))
                     relation.card_max = int(str(child.attrib.get('max')))
                 else:
-                    print("This XML contains non supported elements", file=sys.stderr)
+                    logger.warning("This XML contains non supported elements")
         else:
             raise RuntimeError("Something is wrong on the xml")
         return relation