Skip to content

Commit 185c76b

Browse files
authored
Merge pull request #977 from flippercloud/remove-expression-duration
Remove expression duration
2 parents c387c07 + 4af8eea commit 185c76b

5 files changed

Lines changed: 2 additions & 77 deletions

File tree

lib/flipper.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -108,10 +108,6 @@ def time(value)
108108
Expression.build({ Time: value })
109109
end
110110

111-
def duration(scalar, unit = 'second')
112-
Expression.build({ Duration: [scalar, unit] })
113-
end
114-
115111
def feature_enabled(name)
116112
Expression.build({ FeatureEnabled: name })
117113
end

lib/flipper/expressions/duration.rb

Lines changed: 0 additions & 28 deletions
This file was deleted.

spec/flipper/adapters/dalli_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
let(:memory_adapter) do
77
Flipper::Adapters::OperationLogger.new(Flipper::Adapters::Memory.new)
88
end
9-
let(:cache) { Dalli::Client.new(ENV['MEMCACHED_URL']) }
9+
let(:cache) { Dalli::Client.new(ENV['MEMCACHED_URL'], protocol: :meta) }
1010
let(:adapter) { described_class.new(memory_adapter, cache, 10) }
1111
let(:flipper) { Flipper.new(adapter) }
1212

spec/flipper/expressions/duration_spec.rb

Lines changed: 0 additions & 43 deletions
This file was deleted.

test/adapters/dalli_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ class DalliTest < MiniTest::Test
77

88
def setup
99
url = ENV.fetch('MEMCACHED_URL', 'localhost:11211')
10-
@cache = Dalli::Client.new(url)
10+
@cache = Dalli::Client.new(url, protocol: :meta)
1111
Dalli.logger = Logger.new('/dev/null')
1212
@cache.flush
1313
memory_adapter = Flipper::Adapters::Memory.new

0 commit comments

Comments
 (0)