Warn about ActiveRecord value column migration (#1013)

Author: jnunemaker

lib/flipper/adapters/active_record.rb

@@ -299,7 +299,9 @@ def with_write_connection(model = @feature_class, &block)
 
       def warned_about_value_not_text?
         return @warned_about_value_not_text if defined?(@warned_about_value_not_text)
+
         @warned_about_value_not_text = true
+        false
       end
     end
   end

spec/flipper/adapters/active_record_spec.rb

@@ -92,6 +92,19 @@
           end
         end
 
+        it "warns once if the gates value column is not text" do
+          allow(Flipper::Adapters::ActiveRecord::Gate).
+            to receive(:column_for_attribute).
+            with(:value).
+            and_return(double(type: :string))
+
+          output = capture_output do
+            2.times { subject.features }
+          end
+
+          expect(output.scan("Your database needs to be migrated").size).to eq(1)
+        end
+
         context "ActiveRecord connection_pool" do
           before do
             clear_active_connections!