Skip to content

Commit 3296074

Browse files
Further improve naming for Simulink MATLAB functions
1 parent 5c4370c commit 3296074

3 files changed

Lines changed: 10 additions & 6 deletions

File tree

miss_hit/mh_trace.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,11 @@ def visit_end(self, node, n_parent, relation):
138138
if isinstance(node, Function_Definition) and \
139139
not any(self.no_tracing_stack):
140140
if self.blockname:
141-
name = self.blockname
141+
name = self.blockname
142+
shortname = self.blockname
142143
else:
143-
name = self.name_prefix + node.get_local_name()
144+
name = self.name_prefix + node.get_local_name()
145+
shortname = node.get_local_name()
144146
tag = "matlab %s" % name
145147
location = node.loc()
146148
lobster_loc = {"kind" : "file",
@@ -152,7 +154,7 @@ def visit_end(self, node, n_parent, relation):
152154
set()))
153155
item = {"tag" : tag,
154156
"location" : lobster_loc,
155-
"name" : node.get_local_name(),
157+
"name" : shortname,
156158
"refs" : ["req %s" % tag for tag in all_tags],
157159
"just_up" : [],
158160
"just_down" : [],

miss_hit_core/s_ast.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,10 @@ def full_name(self):
199199
name_stack = []
200200
ptr = self
201201
while ptr:
202-
if isinstance(ptr, Container):
202+
if isinstance(ptr, Model):
203203
name_stack.append(ptr.name)
204+
elif isinstance(ptr, Library):
205+
break
204206
elif isinstance(ptr, Block):
205207
name_stack.append(ptr.name)
206208
ptr = ptr.n_parent

tests/trace/simulink-matlab/mh_imp_trace.lobster

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"kind": "file",
3232
"line": 1
3333
},
34-
"name": "fcn",
34+
"name": "test/Potato/Thing_A",
3535
"refs": [],
3636
"shared": false,
3737
"tag": "matlab test/Potato/Thing_A"
@@ -48,7 +48,7 @@
4848
"kind": "file",
4949
"line": 1
5050
},
51-
"name": "fcn",
51+
"name": "test/Potato/Thing_B",
5252
"refs": [
5353
"req foo.bar"
5454
],

0 commit comments

Comments
 (0)