fix(flow-php/postgresql): quote schema-qualified table per identifier part in BulkInsert (#2428)

Author: norberttech

src/lib/postgresql/src/Flow/PostgreSql/QueryBuilder/Insert/BulkInsert.php

@@ -5,6 +5,7 @@
 namespace Flow\PostgreSql\QueryBuilder\Insert;
 
 use Flow\PostgreSql\QueryBuilder\Clause\ConflictTarget;
+use Flow\PostgreSql\QueryBuilder\QualifiedIdentifier;
 use Flow\PostgreSql\QueryBuilder\Sql;
 use InvalidArgumentException;
 
@@ -96,7 +97,7 @@ public function toSql(): string
             $rows[] = '(' . implode(', ', $placeholders) . ')';
         }
 
-        $sql = sprintf('INSERT INTO "%s" (%s) VALUES %s', $this->table, $quotedColumns, implode(', ', $rows));
+        $sql = sprintf('INSERT INTO %s (%s) VALUES %s', $this->quotedTable(), $quotedColumns, implode(', ', $rows));
 
         if ($this->doNothing) {
             $sql .= ' ON CONFLICT';
@@ -125,6 +126,14 @@ public function toSql(): string
         return $sql;
     }
 
+    private function quotedTable(): string
+    {
+        return implode('.', array_map(
+            static fn(string $part): string => '"' . $part . '"',
+            QualifiedIdentifier::parse($this->table)->parts(),
+        ));
+    }
+
     private function formatConflictTarget(ConflictTarget $target): string
     {
         $constraint = $target->getConstraint();

src/lib/postgresql/tests/Flow/PostgreSql/Tests/Unit/QueryBuilder/Insert/BulkInsertTest.php

@@ -48,6 +48,41 @@ public function test_immutability_on_conflict_do_update(): void
         static::assertStringContainsString('DO UPDATE', $query2->toSql());
     }
 
+    public function test_insert_into_schema_qualified_table(): void
+    {
+        $query = BulkInsert::into('enriched.production', ['a', 'b'], 1);
+
+        static::assertSame('INSERT INTO "enriched"."production" ("a", "b") VALUES ($1, $2)', $query->toSql());
+    }
+
+    public function test_insert_into_three_part_qualified_table(): void
+    {
+        $query = BulkInsert::into('db.enriched.production', ['a'], 1);
+
+        static::assertSame('INSERT INTO "db"."enriched"."production" ("a") VALUES ($1)', $query->toSql());
+    }
+
+    public function test_insert_into_already_quoted_qualified_table(): void
+    {
+        $query = BulkInsert::into('enriched."my.table"', ['a'], 1);
+
+        static::assertSame('INSERT INTO "enriched"."my.table" ("a") VALUES ($1)', $query->toSql());
+    }
+
+    public function test_schema_qualified_table_with_on_conflict_do_update(): void
+    {
+        $query = BulkInsert::into(
+            'enriched.production',
+            ['email', 'name'],
+            1,
+        )->onConflictDoUpdate(ConflictTarget::columns(['email']));
+
+        static::assertSame(
+            'INSERT INTO "enriched"."production" ("email", "name") VALUES ($1, $2) ON CONFLICT ("email") DO UPDATE SET "name" = EXCLUDED."name"',
+            $query->toSql(),
+        );
+    }
+
     public function test_insert_with_many_columns(): void
     {
         $query = BulkInsert::into('products', ['id', 'name', 'price', 'category', 'stock'], 2);