Skip to content

Commit f4396cc

Browse files
committed
Fix parameter_assignments lint in changeTypeInstanceName
Use local variable instead of reassigning the instanceName parameter.
1 parent f695cdd commit f4396cc

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

lib/get_it_impl.dart

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1505,9 +1505,8 @@ class _GetItImplementation implements GetIt {
15051505
? _findRegistrationByInstance(instance)
15061506
: _findRegistrationByNameAndType<T>(instanceName);
15071507

1508-
if (instance != null) {
1509-
instanceName = registrationToRename.instanceName;
1510-
}
1508+
final resolvedInstanceName =
1509+
instance != null ? registrationToRename.instanceName : instanceName;
15111510

15121511
throwIfNot(
15131512
registrationToRename.isNamedRegistration,
@@ -1523,7 +1522,7 @@ class _GetItImplementation implements GetIt {
15231522
);
15241523

15251524
typeRegistration.namedRegistrations[newInstanceName] = registrationToRename;
1526-
typeRegistration.namedRegistrations.remove(instanceName);
1525+
typeRegistration.namedRegistrations.remove(resolvedInstanceName);
15271526
registrationToRename.instanceName = newInstanceName;
15281527
}
15291528

0 commit comments

Comments
 (0)