Merge pull request #24 from fmichonneau/fix-gcc16-stringop-overflow

Avoid GCC 16 -Wstringop-overflow false positive in NxsString

Author: fmichonneau

.github/workflows/rhub.yaml

@@ -7,20 +7,24 @@
 # It is unlikely that you need to modify this file manually.
 
 name: R-hub
-run-name: "${{ github.event.inputs.id }}: ${{ github.event.inputs.name || format('Manually run by {0}', github.triggering_actor) }}"
+run-name: >-
+  ${{ github.event.inputs.id || format('Manual run by @{0}', github.triggering_actor) }}:
+  ${{ github.event.inputs.name || github.event.inputs.config }}
 
 on:
   workflow_dispatch:
     inputs:
       config:
-        description: 'A comma separated list of R-hub platforms to use.'
+        description: >-
+          Comma-separated list of R-hub platforms to use.
+          Full list: https://r-hub.github.io/containers/
         type: string
         default: 'linux,windows,macos'
       name:
-        description: 'Run name. You can leave this empty now.'
+        description: 'Run name. You can leave this empty.'
         type: string
       id:
-        description: 'Unique ID. You can leave this empty now.'
+        description: 'Unique ID. You can leave this empty.'
         type: string
 
 jobs:

src/ncl/nxsstring.h

@@ -422,7 +422,7 @@ inline NxsString &NxsString::operator=(
 inline NxsString &NxsString::operator+=(
   const char *s)	/* the C-string to be appended */
 	{
-	append(std::string(s));
+	append(s);
 	return *this;
 	}
 
@@ -442,10 +442,7 @@ inline NxsString &NxsString::operator+=(
 inline NxsString &NxsString::operator+=(
   const char c)	/* the character to append */
 	{
-	char s[2];
-	s[0] = c;
-	s[1] = '\0';
-	append(std::string(s));
+	push_back(c);
 	return *this;
 	}