Use correct syntax for String.format().

The `{}` is not valid for `String.format()`.
Use `%s` instead.

Author: kaladay

service/src/main/java/org/folio/rest/workflow/controller/WorkflowController.java

@@ -34,7 +34,7 @@
 @RequestMapping("/workflows")
 public class WorkflowController {
 
-  private final static Log LOG = LogFactory.getLog(WorkflowController.class);
+  private static final Log LOG = LogFactory.getLog(WorkflowController.class);
 
   private WorkflowEngineService workflowEngineService;
 
@@ -73,7 +73,7 @@ public JsonNode searchWorkflows(
     @RequestParam(defaultValue="20") Integer limit,
     @TenantHeader String tenant
   ) {
-    LOG.debug(String.format("Performing CQL search: {}, offset, limit", query, offset, limit));
+    LOG.debug(String.format("Performing CQL search: %s, %s, %s", query, offset, limit));
     return workflowCqlService.findByCql(query, offset, limit);
   }
 
@@ -92,7 +92,7 @@ public Workflow activateWorkflow(
     @TenantHeader String tenant,
     @TokenHeader String token
   ) throws WorkflowEngineServiceException, WorkflowNotFoundException {
-    LOG.info(String.format("Activating: {}", id));
+    LOG.info(String.format("Activating: %s", id));
 
     workflowEngineService.exists(id);
 
@@ -105,7 +105,7 @@ public Workflow deactivateWorkflow(
     @TenantHeader String tenant,
     @TokenHeader String token
   ) throws WorkflowEngineServiceException, WorkflowNotFoundException {
-    LOG.info(String.format("Deactivating: {}", id));
+    LOG.info(String.format("Deactivating: %s", id));
 
     workflowEngineService.exists(id);
 
@@ -118,7 +118,7 @@ public ResponseEntity<Object> deleteWorkflow(
     @TenantHeader String tenant,
     @TokenHeader String token
   ) throws WorkflowEngineServiceException, WorkflowNotFoundException {
-    LOG.info(String.format("Deleting: {}", id));
+    LOG.info(String.format("Deleting: %s", id));
 
     workflowEngineService.exists(id);
 
@@ -134,7 +134,7 @@ public JsonNode workflowHistory(
     @TenantHeader String tenant,
     @TokenHeader String token
   ) throws WorkflowEngineServiceException {
-    LOG.debug(String.format("Retrieving History: {}", id));
+    LOG.debug(String.format("Retrieving History: %s", id));
     return workflowEngineService.history(id, tenant, token);
   }
 
@@ -145,7 +145,7 @@ public JsonNode startWorkflow(
     @TokenHeader String token,
     @RequestBody JsonNode context
   ) throws WorkflowEngineServiceException {
-    LOG.info(String.format("Starting: {} with context {}", id, context));
+    LOG.info(String.format("Starting: %s with context %s", id, context));
     return workflowEngineService.start(id, tenant, token, context);
   }
 

service/src/main/java/org/folio/rest/workflow/service/WorkflowEngineService.java

@@ -244,7 +244,7 @@ private Workflow sendWorkflowRequest(WorkflowDto workflow, String requestPath, S
 
     HttpEntity<WorkflowDto> entity = new HttpEntity<>(workflow, headers(tenant, token));
     String url = String.format(requestPath, okapiUrl, basePath);
-    LOG.debug(String.format("Send Okapi workflow engine request {} {}", HttpMethod.POST, url));
+    LOG.debug(String.format("Send Okapi workflow engine request %s %s", HttpMethod.POST, url));
 
     try {
       ResponseEntity<Workflow> response = exchange(url, HttpMethod.POST, entity, Workflow.class);
@@ -254,7 +254,7 @@ private Workflow sendWorkflowRequest(WorkflowDto workflow, String requestPath, S
 
         if (responseWorkflow != null) {
           String deploymentId = responseWorkflow.getDeploymentId();
-          LOG.info(String.format("Workflow is active = {}, deploymentID = {}", Boolean.TRUE.equals(responseWorkflow.getActive()), deploymentId));
+          LOG.info(String.format("Workflow is active = %s, deploymentID = %s", Boolean.TRUE.equals(responseWorkflow.getActive()), deploymentId));
           return workflowRepo.save(responseWorkflow);
         }
       }
@@ -267,7 +267,7 @@ private Workflow sendWorkflowRequest(WorkflowDto workflow, String requestPath, S
 
   private HttpHeaders headers(String tenant, String token) {
     HttpHeaders requestHeaders = new HttpHeaders();
-    LOG.debug(String.format("Request Headers: tenant '{}' and token '{}'.", tenant, token));
+    LOG.debug(String.format("Request Headers: tenant '%s' and token '%s'.", tenant, token));
 
     if (tenant != null) {
       requestHeaders.add(tenantHeaderName, tenant);
@@ -282,7 +282,7 @@ private HttpHeaders headers(String tenant, String token) {
   }
 
   private <T> ResponseEntity<T> exchange(String url, HttpMethod method, HttpEntity<?> request, Class<T> responseType) {
-    LOG.debug(String.format("Exchange for {} {} {}", responseType.getSimpleName(), method, url));
+    LOG.debug(String.format("Exchange for %s %s %s", responseType.getSimpleName(), method, url));
     return this.restTemplate.exchange(url, method, request, responseType, (Object[]) new String[0]);
   }
 

service/src/main/java/org/folio/rest/workflow/service/WorkflowImportService.java

@@ -534,7 +534,7 @@ private void verifyVersion(JsonNode json) {
       String version = json.get(VERSION).asString();
 
       if (!VERSION_PATTERN_1_0.matcher(version).find()) {
-        LOG.warn(String.format("Unknown version '{}', attempting import anyway.", version));
+        LOG.warn(String.format("Unknown version '%s', attempting import anyway.", version));
       }
     } else {
       LOG.warn("No version is specified, attempting import anyway.");
@@ -547,7 +547,7 @@ private void verifyVersion(JsonNode json) {
    * @param name The name of the unknown file or directory.
    */
   private void warnOnUnknownFileOrDir(String name) {
-    LOG.warn(String.format("Ignoring unknown file or directory: '{}'.", name));
+    LOG.warn(String.format("Ignoring unknown file or directory: '%s'.", name));
   }
 
 }