Skip to content

Commit b5577e2

Browse files
fixed tests (#7184)
1 parent 22b76cb commit b5577e2

14 files changed

Lines changed: 40 additions & 31 deletions

cypress/e2e/consortia/data-import/importing-marcBib-files/json-log-of-updated-srs-and-instance-for-shared-source-folio-source-updated-via-DI-on-member.cy.js renamed to cypress/e2e/consortia/data-import/importing-marcBib-files/json-log-of-updated-srs-and-instance-for-shared-folio-source-updated-via-DI-on-member.cy.js

File renamed without changes.

cypress/e2e/consortia/data-import/importing-marcBib-files/json-log-of-updated-srs-and-instanse-for-shared-source-folio-instance-updated-via-DI-on-member.cy.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ describe('Data Import', () => {
6161
action: ACTION_NAMES_IN_ACTION_PROFILE.UPDATE,
6262
};
6363
const matchProfile = {
64-
profileName: `C417042 001-to-Hrid match for update${getRandomPostfix()}`,
64+
profileName: `C417044 001-to-Hrid match for update${getRandomPostfix()}`,
6565
incomingRecordFields: {
6666
field: '001',
6767
},

cypress/e2e/consortia/inventory/instance/adding-shadow-child-instance-to-local-instance-on-member.cy.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import uuid from 'uuid';
2-
import { ITEM_STATUS_NAMES } from '../../../../support/constants';
2+
import { ITEM_STATUS_NAMES, LOAN_TYPE_NAMES, LOCATION_NAMES } from '../../../../support/constants';
33
import Affiliations, { tenantNames } from '../../../../support/dictionary/affiliations';
44
import Permissions from '../../../../support/dictionary/permissions';
55
import InstanceRecordEdit from '../../../../support/fragments/inventory/instanceRecordEdit';
@@ -41,10 +41,10 @@ describe('Inventory', () => {
4141
cy.getHoldingTypes({ limit: 1 }).then((res) => {
4242
testData.shadowHoldings.holdingTypeId = res[0].id;
4343
});
44-
cy.getLocations({ limit: 1 }).then((res) => {
44+
cy.getLocations({ query: `name="${LOCATION_NAMES.ANNEX_UI}"` }).then((res) => {
4545
testData.shadowHoldings.locationId = res.id;
4646
});
47-
cy.getLoanTypes({ limit: 1 }).then((res) => {
47+
cy.getLoanTypes({ query: `name="${LOAN_TYPE_NAMES.CAN_CIRCULATE}"` }).then((res) => {
4848
testData.shadowItem.loanTypeId = res[0].id;
4949
});
5050
cy.getBookMaterialType().then((res) => {

cypress/e2e/consortia/inventory/instance/adding-shadow-parent-instance-to-local-instance-on-member.cy.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import uuid from 'uuid';
2-
import { ITEM_STATUS_NAMES } from '../../../../support/constants';
2+
import { ITEM_STATUS_NAMES, LOCATION_NAMES, LOAN_TYPE_NAMES } from '../../../../support/constants';
33
import Affiliations, { tenantNames } from '../../../../support/dictionary/affiliations';
44
import Permissions from '../../../../support/dictionary/permissions';
55
import InstanceRecordEdit from '../../../../support/fragments/inventory/instanceRecordEdit';
@@ -41,10 +41,10 @@ describe('Inventory', () => {
4141
cy.getHoldingTypes({ limit: 1 }).then((res) => {
4242
testData.shadowHoldings.holdingTypeId = res[0].id;
4343
});
44-
cy.getLocations({ limit: 1 }).then((res) => {
44+
cy.getLocations({ query: `name="${LOCATION_NAMES.ANNEX_UI}"` }).then((res) => {
4545
testData.shadowHoldings.locationId = res.id;
4646
});
47-
cy.getLoanTypes({ limit: 1 }).then((res) => {
47+
cy.getLoanTypes({ query: `name="${LOAN_TYPE_NAMES.CAN_CIRCULATE}"` }).then((res) => {
4848
testData.shadowItem.loanTypeId = res[0].id;
4949
});
5050
cy.getBookMaterialType().then((res) => {

cypress/e2e/finance/funds/error-message-when-transfer-exceeds-expenditure-limit.cy.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ describe('Finance', () => {
8383
const AddTransferModal = BudgetDetails.openAddTransferModal();
8484
AddTransferModal.verifyFromFieldValue('');
8585
AddTransferModal.verifyToFieldValue(fundA.name);
86-
8786
AddTransferModal.fillTransferDetails({
8887
fromFund: fundB.name,
8988
amount: '200',

cypress/e2e/inventory/version-history/instance/version-history-after-editing-instance-via-quickmarc.cy.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ describe('Inventory', () => {
7878
index: 0,
7979
firstName: testData.user.firstName,
8080
lastName: testData.user.lastName,
81-
changes: ['Index title (Edited)', 'Title (Edited)', 'Status updated date (Removed)'],
81+
changes: ['Index title (Edited)', 'Title (Edited)'],
8282
});
8383
},
8484
);

cypress/e2e/invoices/approve-and-pay-invoice-in-current-FY-for-previous-FY.cy.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,14 +263,13 @@ describe('Invoices', { retries: { runMode: 1 } }, () => {
263263
after(() => {
264264
cy.getAdminToken().then(() => {
265265
Users.deleteViaApi(testData.user.userId);
266-
Approvals.setApprovePayValueViaApi(false);
267266
Organizations.deleteOrganizationViaApi(testData.organization.id);
268267
});
269268
});
270269

271270
it(
272271
'C388526 Approve and pay invoice created in current FY for previous FY when related order line was created in current FY (thunderjet) (TaaS)',
273-
{ tags: ['criticalPath', 'thunderjet', 'C388526'] },
272+
{ tags: ['criticalPath', 'thunderjet', 'C388526', 'nonParallel'] },
274273
() => {
275274
Orders.searchByParameter('PO number', testData.order.poNumber);
276275
Orders.selectFromResultsList(testData.order.poNumber);

cypress/e2e/invoices/save-invoice-fiscal-year-after-fund-distribution-change.cy.js

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ import OrderLines from '../../support/fragments/orders/orderLines';
1010
import Orders from '../../support/fragments/orders/orders';
1111
import NewOrganization from '../../support/fragments/organizations/newOrganization';
1212
import Organizations from '../../support/fragments/organizations/organizations';
13+
import Approvals from '../../support/fragments/settings/invoices/approvals';
1314
import NewLocation from '../../support/fragments/settings/tenant/locations/newLocation';
1415
import ServicePoints from '../../support/fragments/settings/tenant/servicePoints/servicePoints';
1516
import TopMenu from '../../support/fragments/topMenu';
@@ -69,6 +70,7 @@ describe('Invoices', () => {
6970

7071
before(() => {
7172
cy.getAdminToken();
73+
Approvals.setApprovePayValueViaApi(false);
7274
FiscalYears.createViaApi(firstFiscalYear).then((firstFiscalYearResponse) => {
7375
firstFiscalYear.id = firstFiscalYearResponse.id;
7476
firstLedger.fiscalYearOneId = firstFiscalYear.id;
@@ -78,9 +80,7 @@ describe('Invoices', () => {
7880
firstFund.ledgerId = firstLedger.id;
7981
Funds.createViaApi(firstFund).then((firstFundResponse) => {
8082
firstFund.id = firstFundResponse.fund.id;
81-
cy.waitForAuthRefresh(() => {
82-
cy.loginAsAdmin({ path: TopMenu.fundPath, waiter: Funds.waitLoading });
83-
}, 20_000);
83+
cy.loginAsAdmin({ path: TopMenu.fundPath, waiter: Funds.waitLoading });
8484
FinanceHelp.searchByName(firstFund.name);
8585
Funds.selectFund(firstFund.name);
8686
Funds.addBudget(allocatedQuantity);
@@ -153,12 +153,11 @@ describe('Invoices', () => {
153153
permissions.uiInvoicesPayInvoicesInDifferentFiscalYear.gui,
154154
]).then((userProperties) => {
155155
user = userProperties;
156-
cy.waitForAuthRefresh(() => {
157-
cy.login(userProperties.username, userProperties.password, {
158-
path: TopMenu.invoicesPath,
159-
waiter: Invoices.waitLoading,
160-
});
161-
}, 20_000);
156+
157+
cy.login(userProperties.username, userProperties.password, {
158+
path: TopMenu.invoicesPath,
159+
waiter: Invoices.waitLoading,
160+
});
162161
});
163162
});
164163
});

cypress/e2e/orders/manage-user-assignments-in-routing-list-from-orders.cy.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,6 @@ describe('Orders', () => {
133133
Orders.searchByParameter('PO number', testData.orderNumber);
134134
Orders.selectFromResultsList(testData.orderNumber);
135135
OrderLines.selectPOLInOrder();
136-
OrderLineDetails.openRoutingListsAccordion();
137136
OrderLineDetails.openRoutingList(routingList);
138137
RoutingListDetails.editRoutingList();
139138
RoutingListEditForm.addUserToRoutingList();

cypress/e2e/orders/users-added-to-routing-list-from-pol-are-synchronized-with-users-added-via-receiving-title.cy.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ describe('Orders', () => {
124124
Orders.searchByParameter('PO number', testData.orderNumber);
125125
Orders.selectFromResultsList(testData.orderNumber);
126126
OrderLines.selectPOLInOrder();
127-
OrderLineDetails.openRoutingListsAccordion();
128127
OrderLineDetails.openRoutingList(routingList);
129128
RoutingListDetails.editRoutingList();
130129
RoutingListEditForm.addUserToRoutingList();

0 commit comments

Comments
 (0)