UIFC-476-add-eslint-rules fix console errors

Author: elsenhans

src/components/MetadataSources/MetadataSourceView.test.js

@@ -1,6 +1,7 @@
 import {
   QueryClient,
   QueryClientProvider,
+  setLogger,
 } from 'react-query';
 import { MemoryRouter } from 'react-router-dom';
 
@@ -16,8 +17,8 @@ import renderWithIntlConfiguration from '../../../test/jest/helpers/renderWithIn
 import MetadataSourceView from './MetadataSourceView';
 
 const mockPut = jest.fn();
-const mockGet = jest.fn(() => Promise.resolve({
-  json: () => Promise.resolve({ name: 'Test organization', id: 'uuid-1234' }),
+const mockGet = jest.fn(() => ({
+  json: jest.fn().mockResolvedValue({ name: 'Test organization', id: 'uuid-1234' }),
 }));
 
 jest.mock('@folio/stripes/core', () => {
@@ -36,6 +37,12 @@ const handlers = {
   onEdit: jest.fn,
 };
 
+setLogger({
+  log: console.log,
+  warn: console.warn,
+  error: () => {},
+});
+
 const queryClient = new QueryClient();
 const okapiState = { okapi: { token: {} } };
 
@@ -73,6 +80,10 @@ describe('MetadataSourceView', () => {
     renderMetadataSourceView(SOURCE);
   });
 
+  afterEach(() => {
+    queryClient.clear();
+  });
+
   it('accordions should be present', () => {
     expect(document.querySelector('#managementAccordion')).toBeInTheDocument();
     expect(document.querySelector('#technicalAccordion')).toBeInTheDocument();

src/routes/CollectionViewRoute.test.js

@@ -7,6 +7,7 @@ import { MemoryRouter } from 'react-router-dom';
 import {
   render,
   screen,
+  waitFor,
 } from '@folio/jest-config-stripes/testing-library/react';
 
 import routeProps from '../../test/fixtures/routeProps';
@@ -17,7 +18,7 @@ const queryClient = new QueryClient();
 jest.mock('../components/MetadataCollections/MetadataCollectionView', () => () => <div>MetadataCollectionView</div>);
 
 describe('render CollectionViewRoute', () => {
-  it('should render MetadataCollectionView', () => {
+  it('should render MetadataCollectionView', async () => {
     render(
       <QueryClientProvider client={queryClient}>
         <MemoryRouter>
@@ -26,6 +27,8 @@ describe('render CollectionViewRoute', () => {
       </QueryClientProvider>
     );
 
-    expect(screen.getByText('MetadataCollectionView')).toBeInTheDocument();
+    await waitFor(() => {
+      expect(screen.getByText('MetadataCollectionView')).toBeInTheDocument();
+    });
   });
 });

src/routes/FilterViewRoute.test.js

@@ -7,6 +7,7 @@ import { MemoryRouter } from 'react-router-dom';
 import {
   render,
   screen,
+  waitFor,
 } from '@folio/jest-config-stripes/testing-library/react';
 
 import routeProps from '../../test/fixtures/routeProps';
@@ -17,7 +18,7 @@ const queryClient = new QueryClient();
 jest.mock('../components/Filters/FilterView', () => () => <div>FilterView</div>);
 
 describe('render FilterViewRoute', () => {
-  it('should render FilterView', () => {
+  it('should render FilterView', async () => {
     render(
       <QueryClientProvider client={queryClient}>
         <MemoryRouter>
@@ -26,6 +27,8 @@ describe('render FilterViewRoute', () => {
       </QueryClientProvider>
     );
 
-    expect(screen.getByText('FilterView')).toBeInTheDocument();
+    await waitFor(() => {
+      expect(screen.getByText('FilterView')).toBeInTheDocument();
+    });
   });
 });

src/routes/SourceViewRoute.test.js

@@ -7,6 +7,7 @@ import { MemoryRouter } from 'react-router-dom';
 import {
   render,
   screen,
+  waitFor,
 } from '@folio/jest-config-stripes/testing-library/react';
 
 import routeProps from '../../test/fixtures/routeProps';
@@ -17,7 +18,7 @@ const queryClient = new QueryClient();
 jest.mock('../components/MetadataSources/MetadataSourceView', () => () => <div>MetadataSourceView</div>);
 
 describe('render SourceViewRoute', () => {
-  it('should render MetadataSourceView', () => {
+  it('should render MetadataSourceView', async () => {
     render(
       <QueryClientProvider client={queryClient}>
         <MemoryRouter>
@@ -26,6 +27,8 @@ describe('render SourceViewRoute', () => {
       </QueryClientProvider>
     );
 
-    expect(screen.getByText('MetadataSourceView')).toBeInTheDocument();
+    await waitFor(() => {
+      expect(screen.getByText('MetadataSourceView')).toBeInTheDocument();
+    });
   });
 });

test/fixtures/metadatasource.js

@@ -31,7 +31,6 @@ const metadatasource = {
   'indexingLevel' : 'bibliographic',
   'generalNotes' : 'Test licensing note',
   'organization' : {
-    'id' : 'uuid-1234',
     'name' : 'Test organization'
   },
 };