Guidelin.locked is saved as number not boolean

[khaledhosny]

In fontra/src/fontra/core/classes.py Guideline.locked is type is bool, but in:

fontra-glyphs/src/fontra_glyphs/backend.py

Lines 1410 to 1417 in e7024bc

	def gsGuidelineToFontraGuideline(gsGuideline):
	return Guideline(
	x=gsGuideline.position.x,
	y=gsGuideline.position.y,
	angle=gsGuideline.angle,
	name=gsGuideline.name,
	locked=gsGuideline.locked,
	)

The Glyphs value is used directly and it is a number not boolean. This apparently not an issue in the Python and JavaScript backends, but while working on the Rust backend for fontc this became an issue. I can work around it, but it would be nice if the type was corrected in classes.py or the code here forced it to be boolean.

[khaledhosny]

When Fontra saves the file, it converts the numbers to boolean, so maybe fixing the code here is enough (this affects test files in fontra repo, like Raqq.fontra).

[justvanrossum]

We should probably convert to bool on read and convert to int on write.

That said, I’m curious, why is fontc interested in guidelines?

[khaledhosny]

That said, I’m curious, why is fontc interested in guidelines?

Now that you mention it, there is no reason to even bother with it. I was updating existing Rust code from classes.py and mapping new classes, and I didn’t stop to think which ones I actually need. I opened #148 to fix the code here to match Fontra backend code, but I’m also dropping reading guidelines from my fontc work.