Skip to content

Commit 14831b3

Browse files
committed
Use sky instead of mock to fix login activity tests.
1 parent 23874ff commit 14831b3

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

libs/test/SalesforceSDKTest/src/com/salesforce/androidsdk/auth/LoginViewModelTest.kt

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ import android.webkit.WebView
3030
import androidx.arch.core.executor.testing.InstantTaskExecutorRule
3131
import androidx.test.ext.junit.runners.AndroidJUnit4
3232
import androidx.test.platform.app.InstrumentationRegistry
33-
import io.mockk.mockk
34-
import io.mockk.verify
3533
import com.salesforce.androidsdk.R.string.oauth_display_type
3634
import com.salesforce.androidsdk.app.SalesforceSDKManager
3735
import com.salesforce.androidsdk.auth.OAuth2.getFrontdoorUrl
@@ -40,6 +38,8 @@ import com.salesforce.androidsdk.config.LoginServerManager.LoginServer
4038
import com.salesforce.androidsdk.security.SalesforceKeyGenerator.getSHA256Hash
4139
import com.salesforce.androidsdk.ui.LoginActivity.Companion.ABOUT_BLANK
4240
import com.salesforce.androidsdk.ui.LoginViewModel
41+
import io.mockk.spyk
42+
import io.mockk.verify
4343
import org.junit.After
4444
import org.junit.Assert.assertEquals
4545
import org.junit.Assert.assertFalse
@@ -203,13 +203,14 @@ class LoginViewModelTest {
203203
@Test
204204
fun clearWebViewCache_CallsWebViewClearCache_WithTrueParameter() {
205205
// Arrange
206-
val mockWebView = mockk<WebView>(relaxed = true)
207-
206+
val webView = WebView(context)
207+
val webviewSpy = spyk<WebView>(webView)
208+
208209
// Act
209-
viewModel.clearWebViewCache(mockWebView)
210-
210+
viewModel.clearWebViewCache(webviewSpy)
211+
211212
// Assert
212-
verify { mockWebView.clearCache(true) }
213+
verify { webviewSpy.clearCache(true) }
213214
}
214215

215216
private fun generateExpectedAuthorizationUrl(

0 commit comments

Comments
 (0)