Skip to content

Commit e437641

Browse files
@W-17964655: [Android] WSC discovery endpoint to postpone OAuth flow (Lock In Supported Client Id Values For Salesforce Welcome Discovery)
1 parent f20120b commit e437641

1 file changed

Lines changed: 11 additions & 8 deletions

File tree

libs/SalesforceSDK/src/com/salesforce/androidsdk/ui/LoginActivity.kt

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ import com.salesforce.androidsdk.auth.OAuth2.swapJWTForTokens
134134
import com.salesforce.androidsdk.auth.idp.interfaces.SPManager.Status
135135
import com.salesforce.androidsdk.auth.idp.interfaces.SPManager.StatusUpdateCallback
136136
import com.salesforce.androidsdk.config.BootConfig.getBootConfig
137-
import com.salesforce.androidsdk.config.LoginServerManager.LoginServer
138137
import com.salesforce.androidsdk.config.RuntimeConfig.ConfigKey.ManagedAppCertAlias
139138
import com.salesforce.androidsdk.config.RuntimeConfig.ConfigKey.RequireCertAuth
140139
import com.salesforce.androidsdk.config.RuntimeConfig.getRuntimeConfig
@@ -1427,13 +1426,17 @@ open class LoginActivity : FragmentActivity() {
14271426
fun isSalesforceWelcomeDiscoveryMobileUrl(
14281427
context: Context,
14291428
uri: Uri,
1430-
) = isSalesforceWelcomeDiscoveryUrlPath(uri) && uri.queryParameterNames?.contains(
1431-
SALESFORCE_WELCOME_DISCOVERY_MOBILE_URL_QUERY_PARAMETER_KEY_CLIENT_ID
1432-
) != null && uri.queryParameterNames?.contains(
1433-
SALESFORCE_WELCOME_DISCOVERY_MOBILE_URL_QUERY_PARAMETER_KEY_CLIENT_ID
1434-
) != null && uri.queryParameterNames?.contains(
1435-
SALESFORCE_WELCOME_DISCOVERY_MOBILE_URL_QUERY_PARAMETER_KEY_CALLBACK_URL
1436-
) != null && uri.getQueryParameter(SALESFORCE_WELCOME_DISCOVERY_MOBILE_URL_QUERY_PARAMETER_KEY_CLIENT_ID) == getBootConfig(context).remoteAccessConsumerKey
1429+
): Boolean {
1430+
val clientIdParameter = uri.getQueryParameter(SALESFORCE_WELCOME_DISCOVERY_MOBILE_URL_QUERY_PARAMETER_KEY_CLIENT_ID)
1431+
return isSalesforceWelcomeDiscoveryUrlPath(uri) && uri.queryParameterNames?.contains(
1432+
SALESFORCE_WELCOME_DISCOVERY_MOBILE_URL_QUERY_PARAMETER_KEY_CLIENT_ID
1433+
) != null && uri.queryParameterNames?.contains(
1434+
SALESFORCE_WELCOME_DISCOVERY_MOBILE_URL_QUERY_PARAMETER_KEY_CLIENT_VERSION
1435+
) != null && uri.queryParameterNames?.contains(
1436+
SALESFORCE_WELCOME_DISCOVERY_MOBILE_URL_QUERY_PARAMETER_KEY_CALLBACK_URL
1437+
) != null && clientIdParameter == getBootConfig(context).remoteAccessConsumerKey &&
1438+
(clientIdParameter == "SfdcMobileChatterAndroid" || clientIdParameter == "SfdcMobileChatteriOS")
1439+
}
14371440

14381441
/**
14391442
* Determines if the provided URL is a Salesforce Welcome Discovery

0 commit comments

Comments
 (0)