Keep sending notification with UserAccountManager, test clean up

Author: bbirman

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/OAuth/SFOAuthSessionRefresher.m

@@ -118,7 +118,7 @@ - (void)completeWithSuccess {
         SFOAuthInfo *authInfo = [[SFOAuthInfo alloc] initWithAuthType:SFOAuthTypeRefresh];
         [userInfo setValue:authInfo forKey:kSFNotificationUserInfoAuthTypeKey];
         [[NSNotificationCenter defaultCenter] postNotificationName:kSFNotificationUserDidRefreshToken
-                                                            object:self
+                                                            object:[SFUserAccountManager sharedInstance]
                                                           userInfo:userInfo];
         self.completionBlock(self.credentials);
     }

libs/SalesforceSDKCore/SalesforceSDKCoreTests/SFSDKAuthUtilTests.swift

@@ -189,8 +189,6 @@ class SFSDKAuthUtilTests: XCTestCase {
         XCTAssertNotEqual(account.credentials.accessToken, originalAccessToken,
                           "Access token should be rotated after refresh")
         XCTAssertNotNil(account.credentials.refreshToken)
-        print("original refresh token: \(originalRefreshToken)")
-        print("current refresh token: \(account.credentials.refreshToken)")
         XCTAssertNotEqual(account.credentials.refreshToken, originalRefreshToken,
                           "Refresh token should be rotated after refresh")
     }
@@ -242,7 +240,7 @@ class SFSDKAuthUtilTests: XCTestCase {
         let notificationCount = Mutex<Int>(0)
 
         let observer = NotificationCenter.default.addObserver(
-            forName: .init(rawValue: "SFNotificationOAuthUserDidRefreshToken"),
+            forName: UserAccountManager.didRefreshToken,
             object: nil,
             queue: nil
         ) { _ in

libs/SalesforceSDKCore/SalesforceSDKCoreTests/SFSDKTokenRefreshCoordinatorTests.m

@@ -95,7 +95,7 @@ - (void)refreshSessionWithCompletion:(void (^)(SFOAuthCredentials *))completionB
 
         NSMutableDictionary *userInfo = [NSMutableDictionary new];
         [[NSNotificationCenter defaultCenter] postNotificationName:kSFNotificationUserDidRefreshToken
-                                                            object:self
+                                                            object:[SFUserAccountManager sharedInstance]
                                                           userInfo:userInfo];
         if (completionBlock) {
             completionBlock(self.credentials);
@@ -584,6 +584,9 @@ - (void)testIntegrationSingleNetworkCallForConcurrentRefreshes {
 
     [self waitForExpectationsWithTimeout:5.0 handler:nil];
 
+    // Guard: verify the mock was actually exercised (not vacuously passing)
+    XCTAssertGreaterThan(mockClient.accessTokenForRefreshCallCount, 0,
+                         @"Mock authClient was never called — the test is not exercising the intended path");
     // THE KEY ASSERTION: Only one network call was made
     XCTAssertEqual(mockClient.accessTokenForRefreshCallCount, 1,
                    @"Only one accessTokenForRefresh: call should have been made despite 5 concurrent callers");