Skip to content

Commit cb646bf

Browse files
committed
Better name for property
1 parent 37eafc5 commit cb646bf

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Common/SalesforceSDKManager.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,9 +237,9 @@ NS_SWIFT_NAME(SalesforceManager)
237237
*/
238238
@property (nonatomic, assign) BOOL useWebServerAuthentication;
239239

240-
/** Whether or not the app should use welcome discovery. This should only be enabled if the connected app is supported.
240+
/** Whether or not the app supports welcome discovery, this should only be enabled if the connected app is supported.
241241
*/
242-
@property (nonatomic, assign) BOOL useWelcomeDiscovery;
242+
@property (nonatomic, assign) BOOL supportsWelcomeDiscovery;
243243

244244
/** Whether hybrid authentication flow should be used. Defaults to YES.
245245
*/

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/Common/SalesforceSDKManager.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ - (instancetype)init {
315315
self.useWebServerAuthentication = YES;
316316
self.blockSalesforceIntegrationUser = NO;
317317
self.useHybridAuthentication = YES;
318-
self.useWelcomeDiscovery = NO;
318+
self.supportsWelcomeDiscovery = NO;
319319
[self setupServiceConfiguration];
320320
_snapshotViewControllers = [SFSDKSafeMutableDictionary new];
321321
_nativeLoginViewControllers = [SFSDKSafeMutableDictionary new];

libs/SalesforceSDKCore/SalesforceSDKCore/Classes/OAuth/DomainDiscoveryCoordinator.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public class DomainDiscoveryCoordinator: NSObject {
8787
public func isDiscoveryDomain(_ domain: String?) -> Bool {
8888
guard let domain = domain else { return false }
8989
let isDiscovery = domain.lowercased().contains(DomainDiscovery.URLComponent.path.rawValue)
90-
let discoveryEnabled = SalesforceManager.shared.useWelcomeDiscovery
90+
let discoveryEnabled = SalesforceManager.shared.supportsWelcomeDiscovery
9191
if isDiscovery && !discoveryEnabled {
9292
SFSDKCoreLogger.w(classForCoder, message: "\(domain) is a discovery domain, but welcome discovery isn't enabled.")
9393
}

libs/SalesforceSDKCore/SalesforceSDKCoreTests/DomainDiscoveryCoordinatorTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -160,10 +160,10 @@ final class DomainDiscoveryCoordinatorTests: XCTestCase {
160160
let coordinator = DomainDiscoveryCoordinator()
161161
let domain = "welcome.salesforce.com/discovery"
162162

163-
SalesforceManager.shared.useWelcomeDiscovery = false
163+
SalesforceManager.shared.supportsWelcomeDiscovery = false
164164
XCTAssertFalse(coordinator.isDiscoveryDomain(domain))
165165

166-
SalesforceManager.shared.useWelcomeDiscovery = true
166+
SalesforceManager.shared.supportsWelcomeDiscovery = true
167167
XCTAssertTrue(coordinator.isDiscoveryDomain(domain))
168168
}
169169
}

0 commit comments

Comments
 (0)