fix(nodejs): Allow NPM errors by default

elldritch · elldritch · commit 33e478a0058f · 2018-08-14T15:03:16.000-07:00
diff --git a/analyzers/nodejs/nodejs.go b/analyzers/nodejs/nodejs.go
@@ -227,7 +227,7 @@ func (a *Analyzer) Analyze() (graph.Deps, error) {
 	// Get packages.
 	n := npm.NPM{
 		Cmd:      a.NPMCmd,
-		AllowErr: a.Options.AllowNPMErr,
+		AllowErr: a.Options.AllowNPMErr || true, // TODO: we should have a strict mode instead of an allow mode
 	}
 	pkgs, err := n.List(filepath.Dir(a.Module.BuildTarget))
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,7 @@ func (a *Analyzer) Analyze() (graph.Deps, error) {`
`227`	`227`	`// Get packages.`
`228`	`228`	`n := npm.NPM{`
`229`	`229`	`Cmd: a.NPMCmd,`
`230`		`- AllowErr: a.Options.AllowNPMErr,`
	`230`	`+ AllowErr: a.Options.AllowNPMErr \|\| true, // TODO: we should have a strict mode instead of an allow mode`
`231`	`231`	`}`
`232`	`232`	`pkgs, err := n.List(filepath.Dir(a.Module.BuildTarget))`
`233`	`233`	`if err != nil {`