Merge pull request #1627 from tonypzy/refactor/check-auth-handler-helper

refactor: route check_auth through handler authorization helper

Author: hpdang

py/visdom/server/handlers/base_handlers.py

@@ -13,6 +13,7 @@
 import logging
 import traceback
 import http.client
+import time
 
 import tornado.web
 import tornado.websocket
@@ -65,6 +66,14 @@ def initialize(self, app=None):
             self.max_old_content = app.max_old_content
             self.max_image_history = app.max_image_history
 
+    def is_authorized(self):
+        """Update access time and validate authentication for protected methods."""
+        self.last_access = time.time()
+        if self.login_enabled and not self.current_user:
+            self.set_status(401)
+            return False
+        return True
+
     def __init__(self, *request, **kwargs):
         self.include_host = False
         super(BaseHandler, self).__init__(*request, **kwargs)

py/visdom/utils/server_utils.py

@@ -20,7 +20,6 @@
 import json
 import logging
 import os
-import time
 import errno
 from collections import OrderedDict
 
@@ -51,10 +50,7 @@ def check_auth(f):
     """
 
     def _check_auth(handler, *args, **kwargs):
-        # TODO this should call a shared method of the handler
-        handler.last_access = time.time()
-        if handler.login_enabled and not handler.current_user:
-            handler.set_status(401)
+        if not handler.is_authorized():
             return
         f(handler, *args, **kwargs)