-
-
Notifications
You must be signed in to change notification settings - Fork 48
Expand file tree
/
Copy pathtests.py
More file actions
510 lines (432 loc) · 18.5 KB
/
Copy pathtests.py
File metadata and controls
510 lines (432 loc) · 18.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
import datetime
import json
import os
import re
from difflib import context_diff
from pathlib import Path
from string import Template
from unittest import TestCase
import jsonschema
from reporters_db import (
EDITIONS,
JOURNALS,
LAWS,
NAMES_TO_EDITIONS,
REGEX_VARIABLES,
REPORTERS,
VARIATIONS_ONLY,
get_volume_range,
get_volume_ranges,
is_volume_valid,
uses_year_as_volume,
)
from reporters_db.utils import recursive_substitute
VALID_CITE_TYPES = (
"federal",
"neutral",
"scotus_early",
"specialty",
"specialty_west",
"specialty_lexis",
"state",
"state_regional",
)
def emit_strings(obj):
"""Recursively get all the strings out of a JSON object.
Convert ints to strs
"""
if isinstance(obj, dict):
# Feed the keys and items back into the function.
for k, v in obj.items():
yield from emit_strings(k)
yield from emit_strings(v)
elif isinstance(obj, list):
for item in obj:
yield from emit_strings(item)
elif isinstance(obj, int):
yield str(int)
elif isinstance(obj, str):
yield obj
def iter_reporters():
for reporter_abbv, reporter_list in REPORTERS.items():
for reporter_data in reporter_list:
yield reporter_abbv, reporter_list, reporter_data
def iter_editions():
for _reporter_abbv, _reporter_list, reporter_data in iter_reporters():
yield from reporter_data["editions"].items()
class BaseTestCase(TestCase):
# override this with a json file name like "reporters.json":
json_name = None
# string contents of json file:
json_str = None
# parsed contents of json file:
json = None
# parsed contents of schema file:
schema = None
@classmethod
def setUpClass(cls) -> None:
"""Preload json file and schema for validation."""
cls.json_path = (
Path(__file__).parent / "reporters_db" / "data" / cls.json_name
)
cls.json_str = cls.json_path.read_text()
cls.json = json.loads(cls.json_str)
schema_path = Path(__file__).parent / "schemas" / cls.json_name
cls.schema = json.loads(schema_path.read_text())
def check_regexes(self, regexes, examples):
"""Check that each regex matches at least one example, and each example matches at least one regex.
regexes should be a list of [(regex_template, regex)]."""
matched_examples = set()
# check that each regex matches at least one example
for regex_template, regex in regexes:
has_match = False
for example in examples:
if re.match(regex + "$", example):
has_match = True
matched_examples.add(example)
if not has_match:
try:
import exrex
candidate = "Possible examples: %s" % [
exrex.getone(regex, limit=3) for _ in range(10)
]
except ImportError:
candidate = "Run 'pip install exrex' to generate a candidate example"
self.fail(
f"No match in 'examples' for custom regex {regex_template!r}.\n"
f"Expanded regex: {regex}.\n"
f"Provided examples: {examples}.\n"
f"{candidate}"
)
# check that each example is matched by at least one regex
self.assertEqual(
set(examples),
matched_examples,
"Not all examples matched. If custom regexes are provided, all examples should match."
f"Unmatched examples: {set(examples) - matched_examples}. Regexes tried: {regexes}",
)
def check_for_matching_groups(self, regexes, examples):
"""Check that each regex has named <reporter> and <page> matching groups."""
for _regex_template, regex in regexes:
for example in examples:
if m := re.match(regex + "$", example):
self.assertIn(
"reporter",
m.groupdict(),
f"<reporter> group missing in regex {regex}",
)
self.assertIn(
"page",
m.groupdict(),
f"<page> group missing in regex {regex}",
)
continue
def test_json_format(self):
"""Does format of json file match json.dumps(json.loads(), sort_keys=True)?"""
reformatted = json.dumps(
self.json,
indent=4,
ensure_ascii=False,
sort_keys=True,
)
reformatted += "\n"
if self.json_str != reformatted:
if os.environ.get("FIX_JSON"):
self.json_path.write_text(reformatted)
else:
diff = context_diff(
self.json_str.splitlines(),
reformatted.splitlines(),
fromfile="reporters.json",
tofile="expected.json",
)
self.fail(
f"{self.json_name} needs reformatting. "
+ "Run with env var FIX_JSON=1 to update the file automatically. "
+ "Diff of actual vs. expected:\n"
+ "\n".join(diff)
)
def test_schema(self):
"""Does json file validate against the schema in the schemas folder?"""
jsonschema.validate(self.json, self.schema)
def check_dates(self, start, end):
"""Check that start and end dates are valid."""
if start is not None:
self.assertTrue(
isinstance(start, datetime.datetime),
f"{repr(start)} should be imported as a date.",
)
if end is not None:
self.assertTrue(
isinstance(end, datetime.datetime),
f"{repr(end)} should be imported as a date.",
)
if start is not None and end is not None:
self.assertLessEqual(start, end)
def check_ascii(self, obj):
"""Check that all strings in obj match a list of expected ascii characters."""
allowed_chars = r"[ 0-9a-zA-Z.,\-'&(){}\[\]\\$§_?<>+*|:/’]"
for s in emit_strings(obj):
remaining_chars = re.sub(allowed_chars, "", s)
self.assertFalse(
remaining_chars,
f"Unexpected characters in {repr(s)}: {repr(remaining_chars)}.",
)
def check_whitespace(self, obj):
for s in emit_strings(obj):
self.assertEqual(
s.strip(), s, msg=f"Field needs whitespace stripped: '{s}'"
)
non_space_whitespace = any(w != " " for w in re.findall(r"\s+", s))
self.assertFalse(
non_space_whitespace,
f"Field has unexpected whitespace: {repr(s)}",
)
class RegexesTest(BaseTestCase):
"""Tests for regexes.json"""
json_name = "regexes.json"
class ReportersTest(BaseTestCase):
"""Tests for reporters.json"""
json_name = "reporters.json"
def test_any_keys_missing_editions(self):
"""Have we added any new reporters that lack a matching edition?"""
for reporter_abbv, _reporter_list, reporter_data in iter_reporters():
self.assertIn(
reporter_abbv,
reporter_data["editions"],
msg=f"Could not find edition for key: {reporter_abbv}",
)
def test_for_variations_mapping_to_bad_keys(self):
"""Do we have a variation that maps to a key that doesn't exist in the
first place?
"""
for variations in VARIATIONS_ONLY.values():
for variation in variations:
self.assertIn(
EDITIONS[variation],
REPORTERS.keys(),
msg=f"Could not map variation to a valid reporter: {variation}",
)
def test_basic_names_to_editions(self):
"""Do we get something like we expected in the NAME_TO_EDITION var?"""
self.assertEqual(
["A.", "A.2d", "A.3d"], NAMES_TO_EDITIONS["Atlantic Reporter"]
)
def test_editions_ordering(self):
"""Test Ill. App., where we don't have good start dates."""
self.assertEqual(
["Ill. App.", "Ill. App. 2d", "Ill. App. 3d"],
NAMES_TO_EDITIONS["Illinois Appellate Court Reports"],
)
def test_dates(self):
"""Do we properly make the ISO-8601 date strings into Python dates?"""
# for reporter_abbv, reporter_list, reporter_data in iter_reporters():
for _edition_name, edition in iter_editions():
self.check_dates(edition["start"], edition["end"])
def test_all_reporters_have_valid_cite_type(self):
"""Do all reporters have valid cite_type values?"""
for reporter_abbv, _reporter_list, reporter_data in iter_reporters():
self.assertIn(
reporter_data["cite_type"],
VALID_CITE_TYPES,
f"{reporter_abbv} did not have a valid cite_type value",
)
def test_no_variation_is_same_as_key(self):
"""Are any variations identical to the keys they're supposed to be
variations of?
"""
for variation, keys in VARIATIONS_ONLY.items():
for key in keys:
self.assertNotEqual(
variation,
key,
f"The variation '{variation}' is identical to the key it's supposed "
"to be a variation of.",
)
def test_fields_tidy(self):
"""Check that fields don't have unexpected characters or whitespace."""
for reporter_abbv, _reporter_list, reporter_data in iter_reporters():
self.check_ascii(reporter_abbv)
self.check_ascii(list(reporter_data["editions"].keys()))
self.check_ascii(reporter_data["variations"])
self.check_whitespace(REPORTERS)
def test_regexes(self):
"""
(1) Do custom regexes and examples match up?
(2) Does each regex have named <reporter> and <page> matching groups?
"""
for reporter_abbv, _reporter_list, reporter_data in iter_reporters():
# get list of expanded regexes and examples for this reporter
examples = reporter_data.get("examples", [])
regexes = []
for edition_abbv, edition in reporter_data["editions"].items():
if not edition.get("regexes"):
continue
for regex_template in edition["regexes"]:
edition_strings = [edition_abbv] + [
k
for k, v in reporter_data["variations"].items()
if v == edition_abbv
]
regex = recursive_substitute(
regex_template, REGEX_VARIABLES
)
regex = Template(regex).safe_substitute(
edition=f"(?:{'|'.join(re.escape(e) for e in edition_strings)})"
)
regexes.append((regex_template, regex))
if not regexes:
continue
with self.subTest(
"Check reporter regexes", reporter=reporter_abbv
):
self.check_regexes(regexes, examples)
with self.subTest(
"Check for named matching groups", reporter=reporter_abbv
):
self.check_for_matching_groups(regexes, examples)
class LawsTest(BaseTestCase):
"""Tests for laws.json"""
json_name = "laws.json"
@staticmethod
def iter_laws():
for law_key, law_list in LAWS.items():
yield from ((law_key, law) for law in law_list)
def test_regexes(self):
"""Do custom regexes and examples match up?"""
for law_key, law in self.iter_laws():
regexes = []
# expand regex and substitute $edition value
series_strings = [law_key] + law["variations"]
for regex_template in law["regexes"]:
regex = recursive_substitute(regex_template, REGEX_VARIABLES)
regex = Template(regex).safe_substitute(
edition=f"(?:{'|'.join(re.escape(e) for e in series_strings)})"
)
regexes.append((regex_template, regex))
with self.subTest("Check law regexes", name=law["name"]):
self.check_regexes(regexes, law["examples"])
def test_dates(self):
for _law_key, law in self.iter_laws():
self.check_dates(law["start"], law["end"])
def test_fields_tidy(self):
"""Check that fields don't have unexpected characters or whitespace."""
for _law_key, law in self.iter_laws():
self.check_ascii(law["regexes"])
self.check_ascii(law["examples"])
self.check_whitespace(REPORTERS)
class JournalsTest(BaseTestCase):
"""Tests for journals.json"""
json_name = "journals.json"
@staticmethod
def iter_journals():
for journal_key, journal_list in JOURNALS.items():
yield from ((journal_key, journal) for journal in journal_list)
def test_regexes(self):
"""Do custom regexes and examples match up?"""
for _journal_key, journal in self.iter_journals():
regexes = [
(
regex_template,
recursive_substitute(regex_template, REGEX_VARIABLES),
)
for regex_template in journal.get("regexes", [])
]
with self.subTest("Check journal regexes", name=journal["name"]):
self.check_regexes(regexes, journal.get("examples", []))
def test_dates(self):
for _journal_key, journal in self.iter_journals():
self.check_dates(journal["start"], journal["end"])
def test_fields_tidy(self):
"""Check that fields don't have unexpected characters or whitespace."""
for journal_key, journal in self.iter_journals():
self.check_ascii(journal_key)
self.check_ascii(journal["name"])
self.check_whitespace(JOURNALS)
class VolumeRangeTests(TestCase):
"""Tests for volume range functionality."""
def test_get_volume_ranges_returns_dict(self):
"""get_volume_ranges should return a dictionary."""
ranges = get_volume_ranges()
self.assertIsInstance(ranges, dict)
def test_get_volume_range_known_reporter(self):
"""get_volume_range should return tuple for known reporters."""
# This test assumes U.S. has volume_range data
result = get_volume_range("U.S.")
if result is not None:
self.assertIsInstance(result, tuple)
self.assertEqual(len(result), 2)
min_vol, max_vol = result
self.assertGreaterEqual(min_vol, 1)
self.assertGreater(max_vol, min_vol)
def test_get_volume_range_unknown_reporter(self):
"""get_volume_range should return None for unknown reporters."""
result = get_volume_range("Definitely Not A Real Reporter")
self.assertIsNone(result)
def test_is_volume_valid_within_range(self):
"""Volumes within range should be valid."""
# Assuming U.S. has range data with max around 600
is_valid, reason = is_volume_valid("U.S.", 500)
# If no range data, it defaults to valid
self.assertTrue(is_valid)
def test_is_volume_valid_unknown_reporter(self):
"""Unknown reporters should default to valid."""
is_valid, reason = is_volume_valid("Unknown Reporter", 99999)
self.assertTrue(is_valid)
self.assertEqual(reason, "")
def test_is_volume_valid_below_minimum(self):
"""Volumes below minimum should be invalid."""
# Assuming U.S. has range data with min = 1
result = get_volume_range("U.S.")
if result is not None:
is_valid, reason = is_volume_valid("U.S.", 0)
self.assertFalse(is_valid)
self.assertIn("below minimum", reason)
def test_is_volume_valid_above_maximum(self):
"""Volumes way above maximum should be invalid."""
# Assuming U.S. has range data
result = get_volume_range("U.S.")
if result is not None:
is_valid, reason = is_volume_valid("U.S.", 50000)
self.assertFalse(is_valid)
self.assertIn("exceeds maximum", reason)
def test_uses_year_as_volume_false_for_regular_reporter(self):
"""Regular reporters should not use year as volume."""
result = uses_year_as_volume("U.S.")
self.assertFalse(result)
def test_uses_year_as_volume_unknown_reporter(self):
"""Unknown reporters should return False."""
result = uses_year_as_volume("Unknown Reporter")
self.assertFalse(result)
def test_volume_range_schema_valid(self):
"""All volume_range objects should have required fields."""
ranges_data = get_volume_ranges()
for reporter, (min_vol, max_vol) in ranges_data.items():
self.assertIsInstance(min_vol, int, f"{reporter} min is not int")
self.assertIsInstance(max_vol, int, f"{reporter} max is not int")
self.assertGreaterEqual(min_vol, 0, f"{reporter} min is negative")
self.assertGreater(max_vol, 0, f"{reporter} max is not positive")
self.assertLessEqual(min_vol, max_vol, f"{reporter} min > max")
class VolumeRangeIntegrationTests(TestCase):
"""Integration tests for volume ranges in reporters.json."""
def test_all_editions_volume_range_valid(self):
"""If volume_range exists, it should be properly formatted."""
for _reporter_key, reporter_list in REPORTERS.items():
for reporter in reporter_list:
for edition_key, edition_data in reporter.get(
"editions", {}
).items():
if "volume_range" in edition_data:
vr = edition_data["volume_range"]
self.assertIn("min", vr, f"{edition_key} missing min")
self.assertIn("max", vr, f"{edition_key} missing max")
self.assertGreaterEqual(
vr["max"],
vr["min"],
f"{edition_key} max < min",
)
# avoid running test methods in BaseTestCase itself
del BaseTestCase
if __name__ == "__main__":
import unittest
unittest.main()