Skip to content

Commit 283c438

Browse files
authored
Merge pull request #19 from freshtechbro/codex/release-0-0-18-fix-3
test: fix final 0.0.18 desktop release gate
2 parents ad22625 + 4bbc627 commit 283c438

2 files changed

Lines changed: 18 additions & 10 deletions

File tree

docs/RELEASE_0.0.18_EVIDENCE.md

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,11 @@ Tracks the `0.0.18` release-prep and post-merge CI-repair gates for the repo sta
143143
- Workflow: `Public Release`
144144
- Head: `main` -> `6a51954dfbe883797b270735c7a73e5ac1a375fb`
145145
- Result: failed during `Run release quality gates` after the first fix merged; both `tests/desktop-runtime-permission.test.ts:302` and `tests/desktop-runtime-audit.test.ts:306` still expected a successful capture result without stubbing the screencapture path check on Linux CI
146+
- [x] Release workflow second rerun failure evidence
147+
- Run: `https://github.com/freshtechbro/opendevbrowser/actions/runs/24323004511`
148+
- Workflow: `Public Release`
149+
- Head: `main` -> `ad2262513c0a75a42e4b7969903a185d6f94dfac`
150+
- Result: failed during `Run release quality gates`; `tests/desktop-runtime-audit.test.ts` was fixed, but `tests/desktop-runtime-permission.test.ts:307` still used the unstubbed success path and returned `{ ok: false }` on Linux CI before the mocked `screencapture` call
146151
- [ ] GitHub release URL
147152
- Current state: `gh release view v0.0.18` returned `release not found`
148153
- [ ] npm publish verification
@@ -161,29 +166,27 @@ Tracks the `0.0.18` release-prep and post-merge CI-repair gates for the repo sta
161166

162167
- This ledger is the active `0.0.18` proof record and should be updated as gates complete.
163168
- `docs/RELEASE_0.0.17_EVIDENCE.md` remains historical and should not be rewritten during `0.0.18` prep.
164-
- The current local release-gate proof set on `codex/release-0-0-18-fix` is green:
165-
- `npm run version:check`
169+
- Historical proof from `codex/release-0-0-18-fix` remained green across the broader release gate set.
170+
- Final `codex/release-0-0-18-fix-3` revalidation after the desktop permission test correction:
166171
- `node scripts/docs-drift-check.mjs`
167-
- `node scripts/chrome-store-compliance-check.mjs`
168-
- `./skills/opendevbrowser-best-practices/scripts/validate-skill-assets.sh`
169172
- `npm run lint`
170173
- `npm run typecheck`
171-
- `npm run build`
172-
- `npm run extension:build`
173-
- `npx opendevbrowser --help`
174-
- `npx opendevbrowser help`
174+
- `npm run test -- tests/desktop-runtime-permission.test.ts`
175175
- `npm run test`
176+
- `npm run build`
176177
- Post-fix blocker closure for this release:
177178
- `feature.canvas.managed_headless` cleared after widening preview navigation fallback from `data:text/html` timeout into `setContent`/document-write recovery.
178179
- `feature.canvas.managed_headed` cleared after increasing managed-headed daemon launch budget to `60000ms`.
179180
- `feature.cli.smoke` cleared after removing the harness-only `review` timeout override of `15000ms`.
180181
- Post-merge CI-only blocker closure for this release:
181182
- onboarding smoke no longer depends on built `dist`
182183
- daemon autostart test uses a Linux-safe tmp fixture
183-
- desktop runtime tests no longer assume a macOS-only binary exists in CI
184+
- `tests/desktop-runtime-audit.test.ts` no longer assumes a macOS-only binary exists in CI
184185
- system Chrome cookie tests no longer assert Darwin-only behavior from Linux
185186
- login-fixture probe no longer exits the process when imported in tests
186187
- product-video title refresh now resists generic marketplace chrome
188+
- Remaining CI blocker before the next public rerun:
189+
- `tests/desktop-runtime-permission.test.ts` success-path capture still needs the Linux-safe `statImpl` stub on `origin/main`; `codex/release-0-0-18-fix-3` carries that last test-only patch
187190
- Both strict live-gate scripts currently return non-zero when `env_limited` or `skipped` lanes remain, even with `0` true `fail` results. Release readiness should therefore be read from the recorded counts and scenario details, not the raw process exit code alone.
188191
- Final rebased candidate status:
189192
- provider direct proof still contains honest `env_limited` lanes but no true failures

tests/desktop-runtime-permission.test.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,12 @@ describe("desktop runtime permission and availability", () => {
235235
cacheRoot,
236236
platform: "darwin",
237237
config: makeDesktopConfig(),
238-
execFileImpl
238+
execFileImpl,
239+
statImpl: vi.fn(async (target: string) => (
240+
target === "/usr/sbin/screencapture"
241+
? ({ size: 1 } as Stats)
242+
: stat(target)
243+
))
239244
});
240245

241246
const status = await runtime.status();

0 commit comments

Comments
 (0)