Temporarily disable expect_error() tests that cause workers to leak (#308)

Author: DavisVaughan

tests/testthat/helper-state.R

@@ -0,0 +1,16 @@
+# Detects leaked workers in tests, which show up as:
+#
+# ```
+# Warning message:
+# In .Internal(gc(verbose, reset, full)) :
+#   closing unused connection 4 (<-localhost:11913)
+# ```
+#
+# If a leaked connection is detected, a warning is thrown by testthat for
+# the problematic test.
+#
+# We keep this on constantly to ensure we aren't leaking connections. It has
+# also been helpful for detecting future issues around leaked workers (#307).
+set_state_inspector(function() {
+  getAllConnections()
+})

tests/testthat/test-furrr-options.R

@@ -70,9 +70,12 @@ test_that("can selectively export packages on multisession", {
 
   opts <- furrr_options(packages = "dplyr")
 
-  expect_error(
-    future_map(1:2, ~ tibble(x = .x))
-  )
+  # TODO: Reenable this test after future issue is fixed
+  # https://github.com/futureverse/future/issues/820
+  # https://github.com/futureverse/furrr/issues/307
+  # expect_error(
+  #   future_map(1:2, ~ tibble(x = .x))
+  # )
 
   expect_identical(
     future_map(1:2, ~ tibble(x = .x), .options = opts),

tests/testthat/test-future-map.R

@@ -278,7 +278,11 @@ furrr_test_that("`.f` globals are only looked up in the function env of `.f` (#1
     future_map(1:2, f)
   }
 
-  expect_error(wrapper(fn), "'y' not found")
+  # TODO: Reenable this test after future issue is fixed
+  # https://github.com/futureverse/future/issues/820
+  # https://github.com/futureverse/furrr/issues/307
+  # expect_error(wrapper(fn), "'y' not found")
+
   expect_identical(wrapper(fn2), list(-1, -1))
 })
 

tests/testthat/test-future-map2.R

@@ -186,17 +186,20 @@ furrr_test_that("size one recycling works", {
   )
 })
 
-furrr_test_that("generally can't recycle to size zero", {
-  expect_error(
-    future_map2(1:2, integer(), ~ c(.x, .y)),
-    "Can't recycle"
-  )
-
-  expect_error(
-    future_map2(integer(), 1:2, ~ c(.x, .y)),
-    "Can't recycle"
-  )
-})
+# TODO: Reenable this test after future issue is fixed
+# https://github.com/futureverse/future/issues/820
+# https://github.com/futureverse/furrr/issues/307
+# furrr_test_that("generally can't recycle to size zero", {
+#   expect_error(
+#     future_map2(1:2, integer(), ~ c(.x, .y)),
+#     "Can't recycle"
+#   )
+#
+#   expect_error(
+#     future_map2(integer(), 1:2, ~ c(.x, .y)),
+#     "Can't recycle"
+#   )
+# })
 
 # ------------------------------------------------------------------------------
 # Miscellaneous

tests/testthat/test-future-pmap.R

@@ -189,17 +189,20 @@ furrr_test_that("size one recycling works", {
   )
 })
 
-furrr_test_that("generally can't recycle to size zero", {
-  expect_error(
-    future_pmap(list(1:2, integer()), ~ c(.x, .y)),
-    "Can't recycle"
-  )
-
-  expect_error(
-    future_pmap(list(integer(), 1:2), ~ c(.x, .y)),
-    "Can't recycle"
-  )
-})
+# TODO: Reenable this test after future issue is fixed
+# https://github.com/futureverse/future/issues/820
+# https://github.com/futureverse/furrr/issues/307
+# furrr_test_that("generally can't recycle to size zero", {
+#   expect_error(
+#     future_pmap(list(1:2, integer()), ~ c(.x, .y)),
+#     "Can't recycle"
+#   )
+#
+#   expect_error(
+#     future_pmap(list(integer(), 1:2), ~ c(.x, .y)),
+#     "Can't recycle"
+#   )
+# })
 
 # ------------------------------------------------------------------------------
 # Miscellaneous
@@ -237,7 +240,11 @@ furrr_test_that("unused components can be absorbed", {
     x
   }
 
-  expect_error(future_pmap_dbl(x, fn1))
+  # TODO: Reenable this test after future issue is fixed
+  # https://github.com/futureverse/future/issues/820
+  # https://github.com/futureverse/furrr/issues/307
+  # expect_error(future_pmap_dbl(x, fn1))
+
   expect_identical(future_pmap_dbl(x, fn2), c(1, 2))
 })