Skip to content

Commit 4ab5b77

Browse files
committed
test: Fix selector tests to expect correct code generation
Updated three selector tests that were checking for incorrect behavior: - TestGenerateSelector: Now expects c.E.Target.Value (was e.Target.Value) - TestGenerateSelectorSingleField: Now expects c.Obj.Name (was obj.Name) - TestGenerateSelectorInFunctionCall: Now expects c.Req.User.Name (was req.User.Name) Parameters are stored as capitalized struct fields and accessed via the component receiver, so the old expectations were for undefined variables. The current code generation is correct - these tests now verify the correct behavior.
1 parent 0e1e40b commit 4ab5b77

1 file changed

Lines changed: 11 additions & 8 deletions

File tree

pkg/codegen/codegen_test.go

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -740,13 +740,14 @@ func Handler(e Event) (Component) {
740740
generatedStr := string(generated)
741741

742742
// Verify selector expression is generated correctly
743-
if !strings.Contains(generatedStr, "e.Target.Value") {
744-
t.Errorf("Generated code does not contain 'e.Target.Value'\nGenerated:\n%s", generatedStr)
743+
// Parameters are stored as struct fields, so e becomes c.E
744+
if !strings.Contains(generatedStr, "c.E.Target.Value") {
745+
t.Errorf("Generated code does not contain 'c.E.Target.Value'\nGenerated:\n%s", generatedStr)
745746
}
746747

747748
// Verify it's in the right context (variable declaration)
748-
if !strings.Contains(generatedStr, "value := e.Target.Value") {
749-
t.Errorf("Generated code does not contain 'value := e.Target.Value'")
749+
if !strings.Contains(generatedStr, "value := c.E.Target.Value") {
750+
t.Errorf("Generated code does not contain 'value := c.E.Target.Value'")
750751
}
751752
}
752753

@@ -780,8 +781,9 @@ func Widget(obj Object) (Component) {
780781
generatedStr := string(generated)
781782

782783
// Verify single-field selector is generated
783-
if !strings.Contains(generatedStr, "obj.Name") {
784-
t.Errorf("Generated code does not contain 'obj.Name'\nGenerated:\n%s", generatedStr)
784+
// Parameters are stored as struct fields, so obj becomes c.Obj
785+
if !strings.Contains(generatedStr, "c.Obj.Name") {
786+
t.Errorf("Generated code does not contain 'c.Obj.Name'\nGenerated:\n%s", generatedStr)
785787
}
786788
}
787789

@@ -815,8 +817,9 @@ func Logger(req Request) (Component) {
815817
generatedStr := string(generated)
816818

817819
// Verify chained selector is generated
818-
if !strings.Contains(generatedStr, "req.User.Name") {
819-
t.Errorf("Generated code does not contain 'req.User.Name'\nGenerated:\n%s", generatedStr)
820+
// Parameters are stored as struct fields, so req becomes c.Req
821+
if !strings.Contains(generatedStr, "c.Req.User.Name") {
822+
t.Errorf("Generated code does not contain 'c.Req.User.Name'\nGenerated:\n%s", generatedStr)
820823
}
821824
}
822825

0 commit comments

Comments
 (0)