Commit 4ed58a9
committed
fix: Update event handlers during DOM patches
CRITICAL FIX: Event handlers were not being updated when components
re-rendered, causing button clicks and other events to be ignored after
the initial render.
Root cause:
- Components create new event handler closures on each render (capturing
updated state)
- The diff/patch system only updated attributes and properties, NOT events
- Initial handlers were attached during Mount but never updated
- Re-renders created new VNode trees with new handlers, but old handlers
remained on the DOM
The fix:
1. Updated UpdateElement() to re-attach event handlers during updates:
- Clean up old js.Func references (prevent memory leaks)
- Remove old event listeners
- Attach new event listeners with updated closures
2. Updated Diff() to detect event handler changes:
- Added eventsChanged() helper function
- Event maps are compared (can't compare closures directly)
- Assumes handlers changed if event keys exist (safe for closures)
3. Updated ApplyPatch() to pass event maps to UpdateElement():
- oldNode.Events and newNode.Events now passed
- Event maps copied to oldNode after patch
Impact:
- Button clicks now trigger handlers after re-renders
- State updates propagate correctly to event handlers
- AutoRotate toggle, speed slider, and all controls now work
- No memory leaks from orphaned js.Func references
This fixes the webgpu-cube example where Controls component state
updates weren't reflected in button click handlers, preventing the
auto-rotate toggle and other controls from working.1 parent de841e7 commit 4ed58a9
2 files changed
Lines changed: 72 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
| 90 | + | |
91 | 91 | | |
92 | | - | |
| 92 | + | |
| 93 | + | |
93 | 94 | | |
94 | 95 | | |
95 | 96 | | |
| |||
227 | 228 | | |
228 | 229 | | |
229 | 230 | | |
| 231 | + | |
| 232 | + | |
230 | 233 | | |
231 | | - | |
| 234 | + | |
232 | 235 | | |
233 | 236 | | |
| 237 | + | |
234 | 238 | | |
235 | 239 | | |
236 | 240 | | |
| |||
319 | 323 | | |
320 | 324 | | |
321 | 325 | | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
225 | 225 | | |
226 | 226 | | |
227 | 227 | | |
228 | | - | |
| 228 | + | |
229 | 229 | | |
230 | 230 | | |
231 | 231 | | |
| |||
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
253 | 299 | | |
254 | 300 | | |
255 | 301 | | |
| |||
0 commit comments