shorter comments, fmt

Author: mrq1911

pallets/referrals/src/lib.rs

@@ -482,9 +482,8 @@ pub mod pallet {
 			let who = ensure_signed(origin)?;
 			for (asset_id, _) in PendingConversions::<T>::iter() {
 				let asset_balance = T::Currency::balance(asset_id.clone(), &Self::pot_account_id());
-				// Best-effort, matching `on_idle`: a slice that can't be converted (e.g. below the
-				// converter's min trading limit) is skipped, not fatal — the funds stay in the pot
-				// and the entry is dropped so it can't block this or anyone else's claim.
+				// Best-effort, like `on_idle`: skip an un-convertible slice rather than revert the
+				// whole claim. Funds stay in the pot and re-queue on the next fee.
 				let _ = T::Convert::convert(
 					Self::pot_account_id(),
 					asset_id.clone(),

pallets/referrals/src/tests.rs

@@ -70,9 +70,7 @@ thread_local! {
 	pub static TIER_VOLUME: RefCell<HashMap<Level, Option<Balance>>> = RefCell::new(HashMap::default());
 	pub static TIER_REWARDS: RefCell<HashMap<Level, FeeDistribution>> = RefCell::new(HashMap::default());
 	pub static SEED_AMOUNT: RefCell<Balance> = RefCell::new(Balance::zero());
-	// Mirrors the runtime `MinTradingLimit`: `AssetConvert` rejects sub-minimum amounts with a
-	// non-referrals error, exactly as `ConvertViaOmnipool` -> `Omnipool::sell` does in production.
-	// 0 disables the gate so existing tests are unaffected.
+	// Mirrors runtime `MinTradingLimit`: reject sub-minimum amounts. 0 = disabled.
 	pub static CONVERT_MIN_AMOUNT: RefCell<Balance> = RefCell::new(Balance::zero());
 }
 
@@ -380,9 +378,7 @@ impl Convert<AccountId, AssetId, Balance> for AssetConvert {
 	) -> Result<Balance, Self::Error> {
 		let min_amount = CONVERT_MIN_AMOUNT.with(|v| *v.borrow());
 		if amount > 0 && amount < min_amount {
-			// Production parity: the omnipool-backed converter rejects sub-`MinTradingLimit`
-			// amounts with `pallet_omnipool::Error::InsufficientTradingAmount` — an error that
-			// is *not* one of the two referrals-specific variants `claim_rewards` tolerates.
+			// Like `ConvertViaOmnipool`: sub-min amounts fail with a non-referrals error.
 			return Err(DispatchError::Other("InsufficientTradingAmount"));
 		}
 		let price = CONVERSION_RATE

pallets/referrals/src/tests/claim.rs

@@ -74,11 +74,7 @@ fn claim_rewards_should_remove_assets_from_the_list_when_not_successful() {
 		});
 }
 
-// Regression: a sub-`MinTradingLimit` dust balance of a non-reward asset in `PendingConversions`
-// must not block reward claims. The converter rejects the dust with a non-referrals error
-// (`InsufficientTradingAmount`), which the claim loop only tolerates for its own two legacy
-// variants — so today it reverts the whole claim instead of skipping the dust like `on_idle`
-// does. This test asserts the desired self-healing behaviour and currently FAILS, proving the bug.
+// Regression: sub-`MinTradingLimit` dust in `PendingConversions` must not block reward claims.
 #[test]
 fn claim_rewards_should_succeed_when_pending_asset_balance_is_below_min_trading_limit() {
 	ExtBuilder::default()