tests: declare class:Collection / collection_type (rnaseq-sr)#1295
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mvdbeek
approved these changes
Jul 15, 2026
Member
|
Attention: deployment skipped! https://github.com/galaxyproject/iwc/actions/runs/29392418499 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final piece of the #1286 split. Same mechanical change as #1290/#1291/#1292:
class: Collectionon outputs that already carriedelement_tests:, andtype:->collection_type:on nested collection elements. No.gafiles or expected data touched.Why this is standalone
rnaseq-srwas held back from #1292 because it errors in CI with:That is not a tool or workflow problem — it is the CI harness bug filed as #1294. The shed-installed data-table config does not survive Galaxy restarts, so the second and later consumer of featurecounts within a chunk cannot load it.
rnaseq-peruns first, installs featurecounts, and passes;rnaseq-srinherits it and fails.As the only featurecounts consumer in this PR's CI run,
rnaseq-srinstalls the tool fresh and registers the data tables — so it should pass here. (rnaseq-pewent out separately in #1292.)This PR therefore doubles as the empirical check on #1294's diagnosis: if it goes green, the harness bug is confirmed and
rnaseq-sritself is fine.