fix(browse): show pending badges for visible items

Author: julianknutsen

internal/api/server_test.go

@@ -571,6 +571,45 @@ func TestDetailNotFound(t *testing.T) {
 	}
 }
 
+func TestBrowse_DefaultView_IncludesPendingBadgeDataForVisibleItems(t *testing.T) {
+	db := newFakeDB()
+	db.items["w-1"] = &fakeItem{id: "w-1", title: "My item", status: "open", priority: 1, postedBy: "alice", effortLevel: "medium"}
+
+	client := sdk.New(sdk.ClientConfig{
+		DB:        db,
+		RigHandle: "alice",
+		Mode:      "pr",
+		ListPendingItems: func() (map[string][]sdk.PendingItem, error) {
+			return map[string][]sdk.PendingItem{
+				"w-1": {{
+					RigHandle: "bob",
+					Status:    "in_review",
+					Branch:    "wl/bob/w-1",
+					PRURL:     "https://example.com/pr/1",
+				}},
+			}, nil
+		},
+	})
+
+	ts := httptest.NewServer(New(client))
+	defer ts.Close()
+
+	var browse BrowseResponse
+	r := getJSON(t, ts, "/api/wanted", &browse)
+	if r.StatusCode != http.StatusOK {
+		t.Fatalf("expected 200 browse, got %d", r.StatusCode)
+	}
+	if len(browse.Items) != 1 || browse.Items[0].ID != "w-1" {
+		t.Fatalf("browse = %+v, want visible main item", browse.Items)
+	}
+	if browse.Items[0].PendingCount != 1 {
+		t.Fatalf("pending_count = %d, want 1", browse.Items[0].PendingCount)
+	}
+	if len(browse.Items[0].PendingItems) != 1 || browse.Items[0].PendingItems[0].RigHandle != "bob" {
+		t.Fatalf("pending_items = %+v, want bob pending PR", browse.Items[0].PendingItems)
+	}
+}
+
 func TestDashboard(t *testing.T) {
 	db := newFakeDB()
 	db.items["w-1"] = &fakeItem{id: "w-1", title: "My task", status: "claimed", claimedBy: "alice", postedBy: "bob", effortLevel: "medium"}

internal/sdk/reads.go

@@ -132,9 +132,6 @@ func (c *Client) BrowseContext(ctx context.Context, filter commons.BrowseFilter)
 		if len(pending) == 0 {
 			continue
 		}
-		if view == "mine" && pendingIDs[items[i].ID] == 0 && len(visiblePendingItems[items[i].ID]) == 0 {
-			continue
-		}
 		pendingIDs[items[i].ID] += len(pending)
 		overlayPendingClaimedBy(&items[i], pending)
 	}

internal/sdk/sdk_test.go

@@ -1198,6 +1198,51 @@ func TestBrowse_DefaultViewTreatsEmptyAsMine(t *testing.T) {
 	}
 }
 
+func TestBrowse_DefaultViewShowsPendingForVisibleItems(t *testing.T) {
+	db := newFakeDB()
+	db.seedItem(fakeItem{
+		ID:          "w-1",
+		Title:       "My visible item",
+		Project:     "gascity",
+		Type:        "bug",
+		Priority:    1,
+		PostedBy:    "alice",
+		Status:      "open",
+		EffortLevel: "small",
+	})
+
+	c := New(ClientConfig{
+		DB:        db,
+		RigHandle: "alice",
+		Mode:      "pr",
+		ListPendingItems: func() (map[string][]PendingItem, error) {
+			return map[string][]PendingItem{
+				"w-1": {{
+					RigHandle: "bob",
+					Status:    "in_review",
+					Branch:    "wl/bob/w-1",
+					PRURL:     "https://example.com/pr/1",
+				}},
+			}, nil
+		},
+	})
+
+	result, err := c.Browse(commons.BrowseFilter{Priority: -1})
+	if err != nil {
+		t.Fatalf("Browse: %v", err)
+	}
+
+	if len(result.Items) != 1 || result.Items[0].ID != "w-1" {
+		t.Fatalf("browse items = %+v, want visible main item", result.Items)
+	}
+	if result.PendingIDs["w-1"] != 1 {
+		t.Fatalf("pending count = %d, want 1", result.PendingIDs["w-1"])
+	}
+	if len(result.UpstreamPending["w-1"]) != 1 || result.UpstreamPending["w-1"][0].RigHandle != "bob" {
+		t.Fatalf("upstream pending = %+v, want bob pending PR", result.UpstreamPending["w-1"])
+	}
+}
+
 func TestDetail_UpstreamPRs(t *testing.T) {
 	db := newFakeDB()
 	db.seedItem(fakeItem{ID: "w-1", Title: "Fix bug", Status: "open", Priority: 1, PostedBy: "alice", EffortLevel: "medium"})