Skip to content

Commit c970d93

Browse files
Gematik-EntwicklungPhyliac
authored andcommitted
R2.1.4
1 parent e20d079 commit c970d93

10 files changed

Lines changed: 23 additions & 39 deletions

File tree

ReleaseNotes.md

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,21 @@
22

33
# Release Notes popp-sample-code
44

5-
## Release 2.1.3
5+
## Release 2.1.4
66

77
### Known Issues
88
- If your eGK has an older CVCA you may get problems while testing with the RÍSE PoPP-Service
99
- Standard-Kartenleser with Docker is not supported in this release, we will fix this in an upcoming release
1010

11+
### changed
12+
13+
- Introduce static key id for signing PoPP token and JWKS endpoint
14+
15+
16+
## Release 2.1.3
17+
1118
## added
12-
- Our PoPP-Service now has a JWSK endpoint
19+
- Our PoPP-Service now has a JWKS endpoint
1320

1421
## changed
1522
- We changed how to start our PoPP-Client and PoPP-Service, please look at the README if you have questions
@@ -69,4 +76,4 @@
6976

7077
### fixed
7178

72-
- TLS connection to Konnektor with ECC is working
79+
- TLS connection to Konnektor with ECC is working

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@
33
<parent>
44
<groupId>org.springframework.boot</groupId>
55
<artifactId>spring-boot-starter-parent</artifactId>
6-
<version>4.0.4</version>
6+
<version>4.0.5</version>
77
</parent>
88
<groupId>de.gematik.refpopp</groupId>
99
<artifactId>popp-example-impl-global</artifactId>
10-
<version>2.1.3</version>
10+
<version>2.1.4</version>
1111
<packaging>pom</packaging>
1212
<name>popp-sample-code</name>
1313
<description>PoPP - example implementation</description>

popp-client/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
<parent>
88
<groupId>de.gematik.refpopp</groupId>
99
<artifactId>popp-example-impl-global</artifactId>
10-
<version>2.1.3</version>
10+
<version>2.1.4</version>
1111
<relativePath>../pom.xml</relativePath>
1212
</parent>
1313

1414
<artifactId>popp-client</artifactId>
15-
<version>2.1.3</version>
15+
<version>2.1.4</version>
1616
<packaging>jar</packaging>
1717

1818
<name>popp-client</name>

popp-commons/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
<parent>
88
<groupId>de.gematik.refpopp</groupId>
99
<artifactId>popp-example-impl-global</artifactId>
10-
<version>2.1.3</version>
10+
<version>2.1.4</version>
1111
<relativePath>../pom.xml</relativePath>
1212
</parent>
1313

1414
<artifactId>popp-commons</artifactId>
15-
<version>2.1.3</version>
15+
<version>2.1.4</version>
1616
<name>popp-commons</name>
1717
<description>popp-commons</description>
1818

popp-coverage-report/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<parent>
88
<groupId>de.gematik.refpopp</groupId>
99
<artifactId>popp-example-impl-global</artifactId>
10-
<version>2.1.3</version>
10+
<version>2.1.4</version>
1111
<relativePath>../pom.xml</relativePath>
1212
</parent>
1313

popp-server/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
<parent>
88
<groupId>de.gematik.refpopp</groupId>
99
<artifactId>popp-example-impl-global</artifactId>
10-
<version>2.1.3</version>
10+
<version>2.1.4</version>
1111
<relativePath>../pom.xml</relativePath>
1212
</parent>
1313

1414
<artifactId>popp-server</artifactId>
15-
<version>2.1.3</version>
15+
<version>2.1.4</version>
1616
<packaging>jar</packaging>
1717

1818
<name>popp-server</name>

popp-server/src/main/java/de/gematik/refpopp/popp_server/configuration/JwksConfiguration.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public JsonWebKeySet jwkSource(@Qualifier("poppKeyStore") KeyStore keystore) {
5151
final PublicKey publicKey = keystore.getCertificate(firstAlias).getPublicKey();
5252
log.info("Public key: {}", publicKey);
5353
final JsonWebKey jsonWebKey = JsonWebKey.Factory.newJwk(publicKey);
54-
jsonWebKey.setKeyId(firstAlias);
54+
jsonWebKey.setKeyId("staticPublicKeyId");
5555
return new JsonWebKeySet(jsonWebKey);
5656
} catch (final GeneralSecurityException | JoseException e) {
5757
throw new IllegalStateException("Failed to initialize keystore", e);

popp-server/src/main/java/de/gematik/refpopp/popp_server/scenario/common/token/TokenHeader.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ private Map<String, Object> createHeadersForConnectorToken(
9595
private Map<String, Object> createHeadersForPoppToken(final ECPublicKey publicKey) {
9696
final var headers = new HashMap<String, Object>();
9797
headers.put(Header.TYP.value, poppTokenType);
98-
headers.put(Header.KID.value, getKeyId(publicKey));
98+
headers.put(Header.KID.value, "staticPublicKeyId");
9999

100100
return headers;
101101
}

popp-server/src/main/resources/application-dev.yaml

Lines changed: 0 additions & 23 deletions
This file was deleted.

popp-server/src/test/java/de/gematik/refpopp/popp_server/configuration/JwksConfigurationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@ void setUp() {
4747
this.jsonWebKeySet = jwkConfiguration.jwkSource(keystore);
4848
assertThat(this.jsonWebKeySet.getJsonWebKeys()).hasSize(1);
4949
assertThat(this.jsonWebKeySet.getJsonWebKeys().getFirst().getKeyId())
50-
.isEqualTo("popp-token-server-nist-komp61");
50+
.isEqualTo("staticPublicKeyId");
5151
}
5252

5353
@Test
5454
void thatAValidJwkSetIsReturned() {
5555
final JwksController controller = new JwksController(this.jsonWebKeySet);
5656
final String jwks = controller.jwks();
57-
assertThat(jwks).contains("popp-token-server-nist-komp61");
57+
assertThat(jwks).contains("staticPublicKeyId");
5858
}
5959
}

0 commit comments

Comments
 (0)