Skip to content

Commit 7c250f7

Browse files
authored
Merge pull request #2487 from generalaction/david/eng-1574-emdash-github-releases
fix: mac build failing
2 parents eeb7e73 + 440f9f9 commit 7c250f7

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

apps/emdash-desktop/scripts/release/notarize-mac.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { existsSync, mkdtempSync, readdirSync, rmSync, writeFileSync } from 'node:fs';
22
import { tmpdir } from 'node:os';
3-
import { join } from 'node:path';
3+
import { join, resolve } from 'node:path';
44
import { parseArgs } from 'node:util';
55
import { notarize } from '@electron/notarize';
66
import { RELEASE_DIR } from './lib/config.ts';
@@ -41,9 +41,11 @@ if (apiKeyContent.includes('BEGIN PRIVATE KEY') || apiKeyContent.length > 500) {
4141
writeFileSync(keyFile, apiKeyContent);
4242
}
4343

44+
// Absolute paths: @electron/notarize resolves .dmg/.pkg appPath against an internal
45+
// temp dir, so a relative path would be looked up under that temp dir and fail.
4446
const dmgs = readdirSync(RELEASE_DIR)
4547
.filter((f) => f.endsWith('.dmg'))
46-
.map((f) => join(RELEASE_DIR, f));
48+
.map((f) => resolve(RELEASE_DIR, f));
4749

4850
if (dmgs.length === 0) {
4951
warn('No DMG files found — nothing to notarize.');

0 commit comments

Comments
 (0)