feat: added dynamic timezone

kemboi22 · kemboi22 · commit ebba2d6626a4 · 2025-12-24T04:03:50.000+03:00
diff --git a/imageroot/actions/configure-module/20configure b/imageroot/actions/configure-module/20configure
@@ -25,6 +25,7 @@ else:
     auth_token = secrets.token_urlsafe(32)
 # n8n CSRF settings
 host = data.get("host", "")
+timezone = data.get("timezone", "UTC")
 n8n_URL = "https://" + host
 OFFLOAD_MANUAL_EXECUTIONS_TO_WORKERS = data.get(
     "OFFLOAD_MANUAL_EXECUTIONS_TO_WORKERS", "true"
@@ -48,8 +49,8 @@ SMTP_USERNAME = smtp_settings["username"]
 SMTP_PASSWORD = smtp_settings["password"]
 
 n8n_config = {
-    "GENERIC_TIMEZONE": "Europe/Berlin",
-    "TZ": "Africa/Nairobi",
+    "GENERIC_TIMEZONE": timezone,
+    "TZ": timezone,
     "N8N_HOST": n8n_URL,
     "EXECUTIONS_MODE": "queue",
     "QUEUE_BULL_REDIS_HOST": "n8n-redis",
diff --git a/imageroot/actions/get-defaults/10defaults b/imageroot/actions/get-defaults/10defaults
@@ -0,0 +1,55 @@
+#!/usr/bin/env python3
+
+#
+# Copyright (C) 2024 Nethesis S.r.l.
+# SPDX-License-Identifier: GPL-3.0-or-later
+#
+
+import json
+import sys
+import subprocess
+import os
+import agent
+
+timezones_directory = "/usr/share/zoneinfo/posix/"
+command = "find *  -type f -or -type l"
+# Get the list of timezones
+accepted_timezone_list = subprocess.check_output(
+    command, cwd=timezones_directory, text=True, shell=True
+).splitlines()
+
+# Get local timezone
+# Works for both Rocky Linux and Debian systems
+local_timezone = ""
+try:
+    # Method 1: Read from /etc/timezone (Debian/Ubuntu)
+    if os.path.exists("/etc/timezone"):
+        with open("/etc/timezone", "r") as f:
+            local_timezone = f.read().strip()
+    # Method 2: Read symlink from /etc/localtime (Rocky Linux/RHEL)
+    elif os.path.islink("/etc/localtime"):
+        localtime_path = os.path.realpath("/etc/localtime")
+        # Extract timezone from path like /usr/share/zoneinfo/Europe/Rome
+        if "/zoneinfo/" in localtime_path:
+            local_timezone = localtime_path.split("/zoneinfo/")[1]
+    # Method 3: Use timedatectl as fallback
+    if not local_timezone:
+        result = subprocess.run(
+            ["timedatectl", "show", "-p", "Timezone", "--value"],
+            capture_output=True,
+            text=True,
+        )
+        if result.returncode == 0:
+            local_timezone = result.stdout.strip()
+except Exception as e:
+    print(f"Warning: Could not determine timezone: {e}", file=sys.stderr)
+    # If all methods fail, use UTC as default
+    local_timezone = "UTC"
+
+
+config = {
+    "accepted_timezone_list": accepted_timezone_list,
+    "local_timezone": local_timezone,
+}
+
+json.dump(config, fp=sys.stdout)
diff --git a/imageroot/actions/get-defaults/validate-output.json b/imageroot/actions/get-defaults/validate-output.json
@@ -0,0 +1,37 @@
+{
+  "$schema": "http://json-schema.org/draft-07/schema#",
+  "title": "n8n defaults",
+  "$id": "http://nethserver.org/json-schema/task/output/n8n/get-defaults",
+  "description": "Get n8n default configuration values",
+  "examples": [
+    {
+      "accepted_timezone_list": [
+        "Europe/Amsterdam",
+        "Europe/Berlin",
+        "Europe/Brussels",
+        "Europe/London"
+      ],
+      "local_timezone": "Europe/Rome"
+    },
+    {
+      "accepted_timezone_list": ["Europe/Amsterdam", "Europe/Berlin"],
+      "local_timezone": "UTC"
+    }
+  ],
+  "type": "object",
+  "additionalProperties": false,
+  "required": ["accepted_timezone_list", "local_timezone"],
+  "properties": {
+    "accepted_timezone_list": {
+      "description": "List of accepted timezones",
+      "type": "array",
+      "items": {
+        "type": "string"
+      }
+    },
+    "local_timezone": {
+      "description": "The current system timezone",
+      "type": "string"
+    }
+  }
+}
diff --git a/ui/src/views/Settings.vue b/ui/src/views/Settings.vue
@@ -58,6 +58,26 @@
                 $t("settings.enabled")
               }}</template>
             </cv-toggle>
+            <NsComboBox
+              v-model.trim="timezone"
+              :autoFilter="true"
+              :autoHighlight="true"
+              :title="$t('settings.timezone')"
+              :label="$t('settings.timezone_placeholder')"
+              :options="timezoneList"
+              :userInputLabel="core.$t('common.user_input_l')"
+              :acceptUserInput="false"
+              :showItemType="true"
+              :invalid-message="$t(error.timezone)"
+              :disabled="loading.getConfiguration || loading.configureModule"
+              tooltipAlignment="start"
+              tooltipDirection="top"
+              ref="timezone"
+            >
+              <template slot="tooltip">
+                {{ $t("settings.timezone_tooltip") }}
+              </template>
+            </NsComboBox>
             <div v-if="error.configureModule" class="bx--row">
               <div class="bx--col">
                 <NsInlineNotification
@@ -109,18 +129,24 @@ export default {
       n8n_ADMIN_PASSWORD: "",
       isLetsEncryptEnabled: false,
       isHttpToHttpsEnabled: false,
+      timezone: "",
+      timezoneList: [],
       loading: {
         getConfiguration: false,
         configureModule: false,
+        getDefaults: false,
       },
       error: {
         getConfiguration: "",
+        timezone: "",
         configureModule: "",
         host: "",
         n8n_ADMIN_USER: "",
         n8n_ADMIN_PASSWORD: "",
         lets_encrypt: "",
         http2https: "",
+        getStatus: "",
+        getDefaults: "",
       },
     };
   },
@@ -129,6 +155,8 @@ export default {
   },
   created() {
     this.getConfiguration();
+    this.getStatus();
+    this.getDefaults();
   },
   beforeRouteEnter(to, from, next) {
     next((vm) => {
@@ -141,6 +169,48 @@ export default {
     next();
   },
   methods: {
+    async getStatus() {
+      this.loading.getStatus = true;
+      this.error.getStatus = "";
+      const taskAction = "get-status";
+      const eventId = this.getUuid();
+      // register to task error
+      this.core.$root.$once(
+        `${taskAction}-aborted-${eventId}`,
+        this.getStatusAborted,
+      );
+      // register to task completion
+      this.core.$root.$once(
+        `${taskAction}-completed-${eventId}`,
+        this.getStatusCompleted,
+      );
+      const res = await to(
+        this.createModuleTaskForApp(this.instanceName, {
+          action: taskAction,
+          extra: {
+            title: this.$t("action." + taskAction),
+            isNotificationHidden: true,
+            eventId,
+          },
+        }),
+      );
+      const err = res[0];
+      if (err) {
+        console.error(`error creating task ${taskAction}`, err);
+        this.error.getStatus = this.getErrorMessage(err);
+        this.loading.getStatus = false;
+        return;
+      }
+    },
+    getStatusAborted(taskResult, taskContext) {
+      console.error(`${taskContext.action} aborted`, taskResult);
+      this.error.getStatus = this.$t("error.generic_error");
+      this.loading.getStatus = false;
+    },
+    getStatusCompleted(taskContext, taskResult) {
+      this.status = taskResult.output;
+      this.loading.getStatus = false;
+    },
     async getConfiguration() {
       this.loading.getConfiguration = true;
       this.error.getConfiguration = "";
@@ -150,14 +220,14 @@ export default {
       this.core.$root.$off(taskAction + "-aborted");
       this.core.$root.$once(
         taskAction + "-aborted",
-        this.getConfigurationAborted
+        this.getConfigurationAborted,
       );
 
       // register to task completion
       this.core.$root.$off(taskAction + "-completed");
       this.core.$root.$once(
         taskAction + "-completed",
-        this.getConfigurationCompleted
+        this.getConfigurationCompleted,
       );
 
       const res = await to(
@@ -167,7 +237,7 @@ export default {
             title: this.$t("action." + taskAction),
             isNotificationHidden: true,
           },
-        })
+        }),
       );
       const err = res[0];
 
@@ -204,6 +274,10 @@ export default {
         }
         isValidationOk = false;
       }
+      if (!this.timezone) {
+        this.error.timezone = "common.required";
+        isValidationOk = false;
+      }
 
       return isValidationOk;
     },
@@ -235,21 +309,21 @@ export default {
       this.core.$root.$off(taskAction + "-aborted");
       this.core.$root.$once(
         taskAction + "-aborted",
-        this.configureModuleAborted
+        this.configureModuleAborted,
       );
 
       // register to task validation
       this.core.$root.$off(taskAction + "-validation-failed");
       this.core.$root.$once(
         taskAction + "-validation-failed",
-        this.configureModuleValidationFailed
+        this.configureModuleValidationFailed,
       );
 
       // register to task completion
       this.core.$root.$off(taskAction + "-completed");
       this.core.$root.$once(
         taskAction + "-completed",
-        this.configureModuleCompleted
+        this.configureModuleCompleted,
       );
 
       const res = await to(
@@ -259,14 +333,15 @@ export default {
             host: this.host,
             lets_encrypt: this.isLetsEncryptEnabled,
             http2https: this.isHttpToHttpsEnabled,
+            timezone: this.timezone,
           },
           extra: {
             title: this.$t("settings.instance_configuration", {
               instance: this.instanceName,
             }),
             description: this.$t("settings.configuring"),
           },
-        })
+        }),
       );
       const err = res[0];
 
@@ -288,6 +363,60 @@ export default {
       // reload configuration
       this.getConfiguration();
     },
+    async getDefaults() {
+      this.loading.getDefaults = true;
+
+      const taskAction = "get-defaults";
+      const eventId = this.getUuid();
+
+      // register to task error
+      this.core.$root.$once(
+        `${taskAction}-aborted-${eventId}`,
+        this.getDefaultsAborted,
+      );
+
+      // register to task completion
+      this.core.$root.$once(
+        `${taskAction}-completed-${eventId}`,
+        this.getDefaultsCompleted,
+      );
+
+      const res = await to(
+        this.createModuleTaskForApp(this.instanceName, {
+          action: taskAction,
+          extra: {
+            title: this.$t("action." + taskAction),
+            isNotificationHidden: true,
+            eventId,
+          },
+        }),
+      );
+      const err = res[0];
+
+      if (err) {
+        console.error(`error creating task ${taskAction}`, err);
+        this.error.getDefaults = this.getErrorMessage(err);
+        this.loading.getDefaults = false;
+        return;
+      }
+    },
+    getDefaultsAborted(taskResult, taskContext) {
+      console.error(`${taskContext.action} aborted`, taskResult);
+      this.error.getDefaults = this.$t("error.generic_error");
+      this.loading.getDefaults = false;
+    },
+    getDefaultsCompleted(taskContext, taskResult) {
+      this.timezoneList = [];
+      taskResult.output.accepted_timezone_list.forEach((value) =>
+        this.timezoneList.push({
+          name: value,
+          label: value,
+          value: value,
+        }),
+      );
+      this.loading.getDefaults = false;
+      this.isProxyInstalled = taskResult.output.proxy_status.proxy_installed;
+    },
   },
 };
 </script>
