Add Stellar-Conduct (#2711)

* Add SSC reaction

* Add SSC to artifacts/weapons/subscriptions

* Fix lint

* Change SSC polestar gadget to spawn on player pos

* Remove TODO

Author: Charlie-Zheng

internal/artifacts/disenchantmentindeepshadow/disenchantmentindeepshadow.go

@@ -43,31 +43,35 @@ func NewSet(core *core.Core, char *character.CharWrapper, count int, param map[s
 		return &s, nil
 	}
 
-	c4Buff := make([]float64, attributes.EndStatType)
-	c4Buff[attributes.CR] = 0.16
-
 	char.AddReactBonusMod(character.ReactBonusMod{
-		Base: modifier.NewBase("disenchantment-reaction-bonus-4pc", -1),
+		Base: modifier.NewBase("disenchantment-4pc-dmg", -1),
 		Amount: func(ai info.AttackInfo) float64 {
-			if ai.AttackTag != attacks.AttackTagSuperconductDamage {
-				return 0
+			switch ai.AttackTag {
+			case attacks.AttackTagSuperconductDamage:
+				return 0.8
+			case attacks.AttackTagDirectStellarConduct:
+				return 0.4
 			}
 
-			return 0.8
+			return 0
 		},
 	})
 
-	// TODO: check if it works while character is off-field
-
+	m := make([]float64, attributes.EndStatType)
+	m[attributes.CR] = 0.16
 	char.AddAttackMod(character.AttackMod{
-		Base: modifier.NewBase("disenchantment-on-superconduct-4pc", -1),
+		Base: modifier.NewBase("disenchantment-4pc-cr", -1),
 		Amount: func(_ *info.AttackEvent, t info.Target) []float64 {
 			e, ok := t.(*enemy.Enemy)
 			if !ok {
 				return nil
 			}
 			if e.StatusIsActive(reactable.SuperConductShredKey) {
-				return c4Buff
+				return m
+			}
+
+			if e.StatusIsActive(reactable.StellarConductShredKey) {
+				return m
 			}
 			return nil
 		},
@@ -84,7 +88,7 @@ func NewSet(core *core.Core, char *character.CharWrapper, count int, param map[s
 			return
 		}
 
-		if r.StatusIsActive(reactable.SuperConductShredKey) {
+		if r.StatusIsActive(reactable.SuperConductShredKey) || r.StatusIsActive(reactable.StellarConductShredKey) {
 			ae.Snapshot.Stats[attributes.CR] += 0.16
 		}
 	}, "disenchantment-4pc-superconduct-"+char.Base.Key.String())

internal/artifacts/scrolloftheheroofcindercity/scrolloftheheroofcindercity.go

@@ -16,6 +16,7 @@ import (
 var reactToElements = map[info.ReactionType][]attributes.Element{
 	info.ReactionTypeOverload:           {attributes.Electro, attributes.Pyro},
 	info.ReactionTypeSuperconduct:       {attributes.Electro, attributes.Cryo},
+	info.ReactionTypeStellarConduct:     {attributes.Electro, attributes.Cryo},
 	info.ReactionTypeMelt:               {attributes.Pyro, attributes.Cryo},
 	info.ReactionTypeVaporize:           {attributes.Pyro, attributes.Hydro},
 	info.ReactionTypeFreeze:             {attributes.Cryo, attributes.Hydro},
@@ -128,6 +129,7 @@ func NewSet(c *core.Core, char *character.CharWrapper, count int, param map[stri
 		for evt, react := range map[event.Event]info.ReactionType{
 			event.OnOverload:           info.ReactionTypeOverload,
 			event.OnSuperconduct:       info.ReactionTypeSuperconduct,
+			event.OnStellarConduct:     info.ReactionTypeStellarConduct,
 			event.OnMelt:               info.ReactionTypeMelt,
 			event.OnVaporize:           info.ReactionTypeVaporize,
 			event.OnFrozen:             info.ReactionTypeFreeze,

internal/artifacts/thunderingfury/thunderingfury.go

@@ -63,7 +63,9 @@ func NewSet(c *core.Core, char *character.CharWrapper, count int, param map[stri
 				attacks.AttackTagSuperconductDamage,
 				attacks.AttackTagHyperbloom:
 				return 0.4
-			case attacks.AttackTagDirectLunarCharged, attacks.AttackTagReactionLunarCharge:
+			case attacks.AttackTagDirectLunarCharged,
+				attacks.AttackTagReactionLunarCharge,
+				attacks.AttackTagDirectStellarConduct:
 				return 0.2
 			}
 			return 0
@@ -97,6 +99,7 @@ func NewSet(c *core.Core, char *character.CharWrapper, count int, param map[stri
 	c.Events.Subscribe(event.OnElectroCharged, reduceNoGadget, fmt.Sprintf("tf-4pc-%v", char.Base.Key.String()))
 	c.Events.Subscribe(event.OnLunarCharged, reduceNoGadget, fmt.Sprintf("tf-4pc-%v", char.Base.Key.String()))
 	c.Events.Subscribe(event.OnSuperconduct, reduceNoGadget, fmt.Sprintf("tf-4pc-%v", char.Base.Key.String()))
+	c.Events.Subscribe(event.OnStellarConduct, reduceNoGadget, fmt.Sprintf("tf-4pc-%v", char.Base.Key.String()))
 	c.Events.Subscribe(event.OnHyperbloom, reduce, fmt.Sprintf("tf-4pc-%v", char.Base.Key.String()))
 	c.Events.Subscribe(event.OnQuicken, reduceNoGadget, fmt.Sprintf("tf-4pc-%v", char.Base.Key.String()))
 	c.Events.Subscribe(event.OnAggravate, reduceNoGadget, fmt.Sprintf("tf-4pc-%v", char.Base.Key.String()))

internal/characters/clorinde/asc.go

@@ -36,6 +36,7 @@ func (c *char) a1() {
 	c.Core.Events.Subscribe(event.OnElectroCharged, c.a1CB, "clorinde-a1-ec")
 	c.Core.Events.Subscribe(event.OnLunarCharged, c.a1CB, "clorinde-a1-lc")
 	c.Core.Events.Subscribe(event.OnSuperconduct, c.a1CB, "clorinde-a1-superconduct")
+	c.Core.Events.Subscribe(event.OnStellarConduct, c.a1CB, "clorinde-a1-ssc")
 	c.Core.Events.Subscribe(event.OnAggravate, c.a1CB, "clorinde-a1-aggravate")
 	c.Core.Events.Subscribe(event.OnQuicken, c.a1CB, "clorinde-a1-quicken")
 	c.Core.Events.Subscribe(event.OnHyperbloom, c.a1CBGadget, "clorinde-a1-hyperbloom")

internal/characters/cyno/cons.go

@@ -111,6 +111,7 @@ func (c *char) c4() {
 	c.Core.Events.Subscribe(event.OnElectroCharged, restoreNoGadget, "cyno-c4")
 	c.Core.Events.Subscribe(event.OnLunarCharged, restoreNoGadget, "cyno-c4")
 	c.Core.Events.Subscribe(event.OnSuperconduct, restoreNoGadget, "cyno-c4")
+	c.Core.Events.Subscribe(event.OnStellarConduct, restoreNoGadget, "cyno-c4")
 	c.Core.Events.Subscribe(event.OnQuicken, restoreNoGadget, "cyno-c4")
 	c.Core.Events.Subscribe(event.OnAggravate, restoreNoGadget, "cyno-c4")
 	c.Core.Events.Subscribe(event.OnHyperbloom, restore, "cyno-c4")

internal/characters/dori/asc.go

@@ -44,6 +44,7 @@ func (c *char) a1() {
 	c.Core.Events.Subscribe(event.OnElectroCharged, reduceNoGadget, "dori-a1")
 	c.Core.Events.Subscribe(event.OnLunarCharged, reduceNoGadget, "dori-a1")
 	c.Core.Events.Subscribe(event.OnSuperconduct, reduceNoGadget, "dori-a1")
+	c.Core.Events.Subscribe(event.OnStellarConduct, reduceNoGadget, "dori-a1")
 	c.Core.Events.Subscribe(event.OnQuicken, reduceNoGadget, "dori-a1")
 	c.Core.Events.Subscribe(event.OnAggravate, reduceNoGadget, "dori-a1")
 	c.Core.Events.Subscribe(event.OnHyperbloom, reduce, "dori-a1")

internal/characters/fischl/asc.go

@@ -74,6 +74,7 @@ func (c *char) a4() {
 	c.Core.Events.Subscribe(event.OnElectroCharged, a4cbNoGadget, "fischl-a4")
 	c.Core.Events.Subscribe(event.OnLunarCharged, a4cbNoGadget, "fischl-a4")
 	c.Core.Events.Subscribe(event.OnSuperconduct, a4cbNoGadget, "fischl-a4")
+	c.Core.Events.Subscribe(event.OnStellarConduct, a4cbNoGadget, "fischl-a4")
 	c.Core.Events.Subscribe(event.OnSwirlElectro, a4cbNoGadget, "fischl-a4")
 	c.Core.Events.Subscribe(event.OnCrystallizeElectro, a4cbNoGadget, "fischl-a4")
 	c.Core.Events.Subscribe(event.OnHyperbloom, a4cb, "fischl-a4")

internal/characters/freminet/cons.go

@@ -128,4 +128,5 @@ func (c *char) c4c6() {
 	c.Core.Events.Subscribe(event.OnShatter, c4c6Buff, "freminet-c4-c6-shatter")
 	c.Core.Events.Subscribe(event.OnFrozen, c4c6Buff, "freminet-c4-c6-frozen")
 	c.Core.Events.Subscribe(event.OnSuperconduct, c4c6Buff, "freminet-c4-c6-superconduct")
+	c.Core.Events.Subscribe(event.OnStellarConduct, c4c6Buff, "freminet-c4-c6-ssc")
 }

internal/characters/keqing/cons.go

@@ -64,6 +64,7 @@ func (c *char) c4() {
 	c.Core.Events.Subscribe(event.OnElectroCharged, cbNoGadget, "keqing-c4")
 	c.Core.Events.Subscribe(event.OnLunarCharged, cbNoGadget, "keqing-c4")
 	c.Core.Events.Subscribe(event.OnSuperconduct, cbNoGadget, "keqing-c4")
+	c.Core.Events.Subscribe(event.OnStellarConduct, cbNoGadget, "keqing-c4")
 	c.Core.Events.Subscribe(event.OnSwirlElectro, cbNoGadget, "keqing-c4")
 	c.Core.Events.Subscribe(event.OnCrystallizeElectro, cbNoGadget, "keqing-c4")
 	c.Core.Events.Subscribe(event.OnQuicken, cbNoGadget, "keqing-c4")

internal/characters/sethos/skill.go

@@ -52,6 +52,7 @@ func (c *char) skillRefundHook() {
 	c.Core.Events.Subscribe(event.OnElectroCharged, refundCB, "sethos-e-refund")
 	c.Core.Events.Subscribe(event.OnLunarCharged, refundCB, "sethos-e-refund")
 	c.Core.Events.Subscribe(event.OnSuperconduct, refundCB, "sethos-e-refund")
+	c.Core.Events.Subscribe(event.OnStellarConduct, refundCB, "sethos-e-refund")
 	c.Core.Events.Subscribe(event.OnSwirlElectro, refundCB, "sethos-e-refund")
 	c.Core.Events.Subscribe(event.OnHyperbloom, refundCB, "sethos-e-refund")
 	c.Core.Events.Subscribe(event.OnQuicken, refundCB, "sethos-e-refund")