Skip to content

Insert code cell with generated code when clicking widget button#2

Merged
benjaminszeghy merged 9 commits into
mainfrom
button_wip
Mar 8, 2026
Merged

Insert code cell with generated code when clicking widget button#2
benjaminszeghy merged 9 commits into
mainfrom
button_wip

Conversation

@benjaminszeghy

Copy link
Copy Markdown
Contributor

Add the core function of using an extension to add a code cell with code in it

benjaminszeghy and others added 5 commits March 4, 2026 15:28
Co-authored-by: Esha Potharaju <e5ha@users.noreply.github.com>
@benjaminszeghy
benjaminszeghy requested review from e5ha and mfisher87 March 7, 2026 20:33
@mfisher87

mfisher87 commented Mar 7, 2026

Copy link
Copy Markdown
Member

Nice! To fix the failing checks, we'll need to add a label to this PR. Check the output of the "Enforce PR label" and "build" checks and let me know if the error messages makes sense!

Let's ignore pre-commit for now, it needs to be set up.

@mfisher87 mfisher87 changed the title Button wip Insert code cell with generated code when clicking widget button Mar 7, 2026
@benjaminszeghy benjaminszeghy added the enhancement New feature or request label Mar 8, 2026
@mfisher87

Copy link
Copy Markdown
Member

The check links job is kind of a jerk, sometimes you just need to re-run it 😬

@mfisher87

mfisher87 commented Mar 8, 2026

Copy link
Copy Markdown
Member

Since merging #3 pre-commit checks are now actually doing something! I'd suggest running prek run --all-files locally to do the autofixes. Looks like there's one error that can't be autofixed, though :)

@benjaminszeghy

Copy link
Copy Markdown
Contributor Author

OK, all checks look good now, and It stills builds and runs as expected. Merging!

@benjaminszeghy
benjaminszeghy merged commit 2d9b27f into main Mar 8, 2026
7 checks passed
@benjaminszeghy
benjaminszeghy deleted the button_wip branch March 8, 2026 21:58
@mfisher87

Copy link
Copy Markdown
Member

Nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants