MAPL3 compatibility#3277
Merged
Merged
Conversation
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
…tion Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Previously USE_ESMF was used as a proxy for using a GCM or GCHP. Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
yantosca
requested changes
May 15, 2026
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Contributor
|
All GEOS-Chem Classic integration tests passed except APM: ==============================================================================
GEOS-Chem Classic: Execution Test Results
CodeDir : 9945dbc GEOS-Chem update: Merge PR #3303 (GCHP rundir improvements)
GEOS-Chem : 2cc2774bc Merge PR #3303 (GCHP run directory improvements)
HEMCO : 5f9e8a3 Merge PR #360 (Build-time option for MAPL3 compatibility)
Cloud-J : 16d18b0 Merge PR #34 (Fixed issues in format statements for verbose output)
HETP : df2f942 Merge PR #4 (Multiphase aerosol chemistry, cf Travis et al 2025)
Using 24 OpenMP threads
Number of execution tests: 38
Submitted as SLURM job: 13704344
==============================================================================
gc_4x5_merra2_fullchem_APM..........................Execute Simulation....FAIL
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 37
Execution tests failed: 1
Execution tests not yet completed: 0All GEOS-Chem Classic tests were zero-diff w/r/t gcc.14.8.0-alpha.9, except
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
CodeDir : 6df92fe GEOS-Chem update: Merge PR #3303 (GCHP rundir improvements)
MAPL : 092f62d9 Merge PR #44 (Update MAPL from 2.59 to 2.69.0)
GMAO_Shared : 4ddb3ec Merge pull request #2 from geoschem/feature/mapl-upgrade
ESMA_cmake : 01bbf2f Merge pull request #9 from geoschem/feature/turn_off_f2py_builds_in_gchp
FMS : 259759d1 Merge pull request #3 from geoschem/feature/update_gmao_libs
FVdycoreCubed : 348620f Merge PR #11 (Scale tracers by pressure ratio in first timestep)
geos-chem : 2cc2774bc Merge PR #3303 (GCHP run directory improvements)
HEMCO : 5f9e8a3 Merge PR #360 (Build-time option for MAPL3 compatibility)
Cloud-J : 16d18b0 Merge PR #34 (Fixed issues in format statements for verbose output)
HETP : df2f942 Merge PR #4 (Multiphase aerosol chemistry, cf Travis et al 2025)
GFE : bac529f Merge pull request #40 from Goddard-Fortran-Ecosystem/feature/mathomp4/update-gftl-1.15.2
Number of execution tests: 12
Submitted as SLURM job: 13704448
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%All GCHP tests showed differences in the diagnostic files created by the MAPL HISTORY component due to metadata updates in MAPL v2.59. But restart files are all identical. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This is a no diff update to bring in code for use with MAPL3. MAPL3 is not currently supported in GCHP and is still in development. All code for use with MAPL3 are in C-preprocessor blocks
#ifdef MAPL3. When using GCHP none of this code will be compiled. Code in theInterfaces/GEOSdirectory are not yet updated for MAPL3.Also in this commit are some minor cleanups of the existing code, including replacing C-processor switch
ifdef ESMF_withifdef MAPL_ESMF,ifdef MODEL_GCHPCTMwithifdef MODEL_GCHP, andifdef MODEL_GCHP && MODEL_GEOSwithifdef MAPL_ESMF.This update goes with geoschem/GCHP#550.
Expected changes
This is a no diff update for both GC-Classic and GCHP.
Reference(s)
None
Related Github Issue
None