fix: Throw NotFoundException for missing sections in section controllers

Author: bastianallgeier

src/Panel/Controller/SectionController.php

@@ -4,6 +4,8 @@
 
 use Kirby\Blueprint\Section;
 use Kirby\Cms\Find;
+use Kirby\Cms\ModelWithContent;
+use Kirby\Exception\NotFoundException;
 use Kirby\Http\Router;
 use Kirby\Panel\Area;
 
@@ -36,18 +38,36 @@ public static function factory(
 		// for page/user/site section dialogs
 		if ($path === null) {
 			return new static(
-				section: Find::parent($model)->blueprint()->section($filename),
+				section: static::findSection(Find::parent($model), $filename),
 				path: $section
 			);
 		}
 
 		// for file section dialogs
 		return new static(
-			section: Find::file($model, $filename)->blueprint()->section($section),
+			section: static::findSection(Find::file($model, $filename), $section),
 			path: $path
 		);
 	}
 
+	/**
+	 * @throws NotFoundException If the section cannot be found
+	 */
+	protected static function findSection(
+		ModelWithContent $model,
+		string $name
+	): Section {
+		$section = $model->blueprint()->section($name);
+
+		if ($section === null) {
+			throw new NotFoundException(
+				message: 'The section "' . $name . '" could not be found'
+			);
+		}
+
+		return $section;
+	}
+
 	public function load(): mixed
 	{
 		return Router::execute($this->path, 'GET', $this->routes());

tests/Panel/Controller/Dialog/SectionDialogControllerTest.php

@@ -5,6 +5,7 @@
 use Exception;
 use Kirby\Blueprint\Section;
 use Kirby\Cms\Page;
+use Kirby\Exception\NotFoundException;
 use Kirby\Panel\TestCase;
 use PHPUnit\Framework\Attributes\CoversClass;
 
@@ -107,6 +108,28 @@ public function testFactoryForFile(): void
 		$this->assertSame('test', $controller->path);
 	}
 
+	public function testFactoryForMissingSection(): void
+	{
+		$this->app = $this->app->clone([
+			'site' => [
+				'children' => [
+					['slug' => 'test']
+				]
+			]
+		]);
+
+		$this->app->impersonate('kirby');
+
+		$this->expectException(NotFoundException::class);
+		$this->expectExceptionMessage('The section "test" could not be found');
+
+		SectionDialogController::factory(
+			model: 'pages/test',
+			filename: 'test',
+			section: 'test'
+		);
+	}
+
 	public function testLoad(): void
 	{
 		$section = $this->section();