smc: address Copilot review on #8820

share_my_connection.dart:
- autoStart unconditionally starts ShareMode.unbounded, dropping
  the manual-port and UPnP-probe branches. The auto path is the
  low-friction Unbounded-only surface; SmC requires the explicit
  disclosure dialog enforced by toggle(). Without this fix, a
  user who'd configured a manual port (or got lucky on the mock
  probe) would silently land in SmC mode without ever seeing the
  disclosure, turning their device into a residential exit they
  never agreed to.
- _fallbackToUnbounded: added a comment documenting the
  intentional reuse of the prior _start's event subscription. The
  invariant works because the error path stays inside the same
  subscription; flipping state.mode keeps the same forwarder
  pushing events for Unbounded. _stop is the only teardown path.
- Welcome dialog 'restrictors' → 'restrictions' typo; normalized
  the surrounding paragraph to single-quote-delimited strings
  (the inner curly quote in 'digital bridges' is retained — it's
  intentional inside the prose).
- About-bubble tooltip moved through .i18n.

unbounded_setting.dart + setting.dart:
- New i18n keys added to en.po:
    unbounded_settings_title
    auto_enable_unbounded / auto_enable_unbounded_subtitle
    hide_unbounded / hide_unbounded_subtitle
    about_unbounded
  All hardcoded English strings in the new screens replaced with
  .i18n lookups, matching the existing pattern in vpn_setting.dart.

dart analyze clean on the touched files.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: myleshorton

assets/locales/en.po

@@ -557,15 +557,16 @@ msgstr "Share My Connection"
 msgid "share_my_connection_subtitle"
 msgstr "Let other Lantern users route through your connection to bypass censorship."
 
-msgid "share_my_connection_on_tap_to_view"
-msgstr "On — tap to view"
-
 # Unbounded tab — hero copy. Short variant for the tab embed; the
 # longer privacy explanation now lives in the welcome dialog
 # (showUnboundedWelcomeDialog) so the tab body stays scannable.
 msgid "smc_intro"
 msgstr "Help others bypass censorship by securely sharing your connection."
 
+# Info-bubble tooltip on the Unbounded tab header
+msgid "about_unbounded"
+msgstr "About Unbounded"
+
 # Status card — phase labels
 msgid "smc_status_label"
 msgstr "Status"
@@ -680,6 +681,24 @@ msgstr "Basic mode (Unbounded)"
 msgid "smc_disclosure_full"
 msgstr "Full mode (SmC)"
 
+# Unbounded Settings menu entry (Settings → Unbounded Settings)
+msgid "unbounded_settings_title"
+msgstr "Unbounded Settings"
+
+# Auto-enable Unbounded toggle
+msgid "auto_enable_unbounded"
+msgstr "Auto-enable Unbounded"
+
+msgid "auto_enable_unbounded_subtitle"
+msgstr "Turn on automatically when Lantern is open"
+
+# Hide Unbounded toggle (collapses the Unbounded tab on the Home shell)
+msgid "hide_unbounded"
+msgstr "Hide Unbounded"
+
+msgid "hide_unbounded_subtitle"
+msgstr "Removes Unbounded from the top of this screen"
+
 msgid "vpn_connected"
 msgstr "Lantern is now connected."
 

lib/features/setting/setting.dart

@@ -154,7 +154,7 @@ class _SettingState extends ConsumerState<Setting>
                 if (unboundedAvailable) ...[
                   DividerSpace(),
                   AppTile(
-                    label: 'Unbounded Settings',
+                    label: 'unbounded_settings_title'.i18n,
                     icon: AppImagePaths.share,
                     onPressed: () =>
                         settingMenuTap(_SettingType.unboundedSetting),

lib/features/setting/unbounded_setting.dart

@@ -30,7 +30,7 @@ class UnboundedSetting extends ConsumerWidget {
     final textTheme = Theme.of(context).textTheme;
 
     return BaseScreen(
-      title: 'Unbounded Settings',
+      title: 'unbounded_settings_title'.i18n,
       body: ListView(
         children: [
           const SizedBox(height: 8),
@@ -39,9 +39,9 @@ class UnboundedSetting extends ConsumerWidget {
             child: Column(
               children: [
                 AppTile(
-                  label: 'Auto-enable Unbounded',
+                  label: 'auto_enable_unbounded'.i18n,
                   subtitle: Text(
-                    'Turn on automatically when Lantern is open',
+                    'auto_enable_unbounded_subtitle'.i18n,
                     style: textTheme.labelMedium!.copyWith(
                       color: context.textTertiary,
                       letterSpacing: 0.0,
@@ -57,9 +57,9 @@ class UnboundedSetting extends ConsumerWidget {
                 ),
                 DividerSpace(),
                 AppTile(
-                  label: 'Hide Unbounded',
+                  label: 'hide_unbounded'.i18n,
                   subtitle: Text(
-                    'Removes Unbounded from the top of this screen',
+                    'hide_unbounded_subtitle'.i18n,
                     style: textTheme.labelMedium!.copyWith(
                       color: context.textTertiary,
                       letterSpacing: 0.0,

lib/features/share_my_connection/share_my_connection.dart

@@ -305,27 +305,21 @@ class ShareNotifier extends Notifier<ShareState> {
   }
 
   /// Programmatic entry point used by the Home shell's auto-enable
-  /// listener (VPN-connected → Unbounded on). Mirrors `toggle()` but
-  /// skips the disclosure dialog because the user has already opted
-  /// in via the Unbounded Settings sheet. No-ops if already active or
-  /// in flight.
+  /// listener (VPN-connected → Unbounded on) and by the
+  /// "Auto-enable Unbounded" Settings toggle.
+  ///
+  /// Always starts Unbounded mode regardless of UPnP capability or
+  /// manual-port configuration. SmC requires the explicit-disclosure
+  /// dialog enforced by toggle(); auto-enabling SmC would silently
+  /// turn the user's device into a residential exit they never
+  /// agreed to act as. The auto path is the low-friction Unbounded
+  /// surface only.
+  ///
+  /// No-ops if already active or in flight.
   Future<void> autoStart(WidgetRef widgetRef) async {
     if (state.active || state.probing) return;
     state = state.copyWith(probing: true);
-    final manualPortRes =
-        await widgetRef.read(lanternServiceProvider).getPeerManualPort();
-    final manualPort = manualPortRes.fold((_) => 0, (p) => p);
-    if (manualPort > 0) {
-      await _start(widgetRef, ShareMode.smc);
-      return;
-    }
-    // MOCK UPnP probe — same as toggle(), pending real FFI.
-    await Future.delayed(const Duration(milliseconds: 1500));
-    final upnpAvailable = Random().nextBool();
-    await _start(
-      widgetRef,
-      upnpAvailable ? ShareMode.smc : ShareMode.unbounded,
-    );
+    await _start(widgetRef, ShareMode.unbounded);
   }
 
   Future<void> _start(WidgetRef widgetRef, ShareMode mode) async {
@@ -670,6 +664,13 @@ class ShareNotifier extends Notifier<ShareState> {
   // Constructs ShareState directly (rather than copyWith) so errorMessage
   // gets cleared — copyWith's `?? this.errorMessage` keeps the previous
   // SmC failure string around otherwise.
+  //
+  // Event subscription: deliberately does NOT call _startEventSubscription.
+  // The error path arrives here via _handlePeerStatus which is already
+  // inside the subscription started by the prior _start; flipping the
+  // local state.mode keeps the same subscription forwarding events for
+  // the new (Unbounded) mode. _stop is the only teardown path for the
+  // subscription, and the error path doesn't go through _stop.
   Future<void> _fallbackToUnbounded(WidgetRef widgetRef) async {
     state = ShareState(
       active: true,
@@ -1806,11 +1807,11 @@ class _UnboundedWelcomeDialog extends StatelessWidget {
               ),
               const SizedBox(height: 16),
               Text(
-                "When you enable Unbounded, your device becomes part of a "
+                'When you enable Unbounded, your device becomes part of a '
                 "network of 'digital bridges' to the open internet. "
-                "Censored users connect to these bridges, allowing them "
-                "to bypass government-imposed restrictors and access the "
-                "information they need.",
+                'Censored users connect to these bridges, allowing them '
+                'to bypass government-imposed restrictions and access the '
+                'information they need.',
                 style: textTheme.bodyMedium,
               ),
               const SizedBox(height: 12),