Follow up to #10064.
Right now we have a documented limitation where menu accelerators take priority because they're intercepted by the macOS menu system (and maybe GTK). But these are sourced from config. I realized we can probably fix this limitation by simply applying our key-remap to our keybinds in the Config.finalize method.
The right way to do this would be to add an applyRemaps or something function to our input.Binding.Set that takes a input.KeyRemapSet as a parameter and applies it to the full set. We'll probably have to be careful about re-indexing our hashes and handling reverse mapping too.
I don't see a reason this won't work... but if anyone has any thoughts please share. I'll keep thinking about it too.
Follow up to #10064.
Right now we have a documented limitation where menu accelerators take priority because they're intercepted by the macOS menu system (and maybe GTK). But these are sourced from config. I realized we can probably fix this limitation by simply applying our key-remap to our keybinds in the
Config.finalizemethod.The right way to do this would be to add an
applyRemapsor something function to ourinput.Binding.Setthat takes ainput.KeyRemapSetas a parameter and applies it to the full set. We'll probably have to be careful about re-indexing our hashes and handling reverse mapping too.I don't see a reason this won't work... but if anyone has any thoughts please share. I'll keep thinking about it too.