Skip to content

Commit aca8a9c

Browse files
ci: re-enable file parallelism, remove per-file leak diagnostic
Investigation complete: the lingering handles are native (koffi/FFI) and invisible to JS instrumentation. Restore plain parallel 'npm test' on the inprocess legs and drop the single-worker leak-by-file tracer.
1 parent 8dcc381 commit aca8a9c

3 files changed

Lines changed: 1 addition & 59 deletions

File tree

.github/workflows/nodejs-sdk-tests.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,14 +80,8 @@ jobs:
8080
if: matrix.transport == 'inprocess'
8181
run: |
8282
echo "COPILOT_SDK_DEFAULT_CONNECTION=inprocess" >> "$GITHUB_ENV"
83-
echo "VITEST_LEAK_BY_FILE=1" >> "$GITHUB_ENV"
8483
8584
- name: Run Node.js SDK tests
8685
env:
8786
COPILOT_HMAC_KEY: ${{ secrets.COPILOT_DEVELOPER_CLI_INTEGRATION_HMAC_KEY }}
88-
run: |
89-
if [ "${{ matrix.transport }}" = "inprocess" ]; then
90-
npm test -- --no-file-parallelism --reporter=default --reporter=hanging-process
91-
else
92-
npm test
93-
fi
87+
run: npm test

nodejs/test/diagnostics/leakByFile.ts

Lines changed: 0 additions & 50 deletions
This file was deleted.

nodejs/vitest.config.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,6 @@ export default defineConfig({
99
teardownTimeout: 10000,
1010
isolate: true, // Run each test file in isolation
1111
pool: "forks", // Use process forking for better isolation
12-
setupFiles:
13-
process.env.VITEST_LEAK_BY_FILE === "1" ? ["./test/diagnostics/leakByFile.ts"] : [],
1412
// Exclude our ad-hoc test files that aren't vitest-based
1513
exclude: [
1614
"**/node_modules/**",

0 commit comments

Comments
 (0)