test: restore forceStop() where crash/abrupt-disconnect semantics matter

Keep graceful stop() for normal teardown (needed so in-process workers release
handles and exit), but revert to forceStop() where the test intent requires it:
- client.e2e 'should forceStop without cleanup' body
- connection_token unauthenticated clients whose start() rejects
- client.test.ts stdin-error test using a mock connection
- pending_work_resume, which forceStop()s to simulate a crash leaving pending
  work for resume (restored to base)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: SteveSandersonMS

nodejs/test/client.test.ts

@@ -26,7 +26,7 @@ async function stopClient(client: CopilotClient): Promise<void> {
 describe("CopilotClient", () => {
     it("disposes the stdio connection when child stdin emits an error", async () => {
         const client = new CopilotClient();
-        onTestFinished(() => stopClient(client));
+        onTestFinished(() => client.forceStop());
 
         const stdin = new PassThrough();
         const stdout = new PassThrough();

nodejs/test/e2e/client.e2e.test.ts

@@ -111,7 +111,7 @@ describe("Client", () => {
         onTestFinishedForceStop(client);
 
         await client.createSession({ onPermissionRequest: approveAll });
-        await client.stop();
+        await client.forceStop();
     });
 
     it("should get status with version and protocol info", async () => {

nodejs/test/e2e/connection_token.test.ts

@@ -24,8 +24,8 @@ describe("Connection token", async () => {
     });
 
     afterAll(async () => {
-        await wrongClient.stop();
-        await noTokenClient.stop();
+        await wrongClient.forceStop();
+        await noTokenClient.forceStop();
     });
 
     it("connects with the matching token", async () => {

nodejs/test/e2e/pending_work_resume.e2e.test.ts

@@ -150,7 +150,7 @@ describe("Pending work resume", async () => {
         });
         onTestFinished(async () => {
             try {
-                await server.stop();
+                await server.forceStop();
             } catch {
                 // Ignore cleanup errors
             }
@@ -164,7 +164,7 @@ describe("Pending work resume", async () => {
         });
         onTestFinished(async () => {
             try {
-                await client.stop();
+                await client.forceStop();
             } catch {
                 // Ignore cleanup errors
             }
@@ -222,7 +222,7 @@ describe("Pending work resume", async () => {
                 await permissionRequestedP;
                 expect(initialRequest.kind).toBe("custom-tool");
 
-                await suspendedClient.stop();
+                await suspendedClient.forceStop();
 
                 const resumedTcpClient = createConnectingClient(cliUrl);
                 const session2 = await resumedTcpClient.resumeSession(sessionId, {
@@ -300,7 +300,7 @@ describe("Pending work resume", async () => {
                     )
                 ).toBe("beta");
 
-                await suspendedClient.stop();
+                await suspendedClient.forceStop();
 
                 const resumedClient = createConnectingClient(cliUrl);
                 const session2 = await resumedClient.resumeSession(sessionId, {
@@ -379,7 +379,7 @@ describe("Pending work resume", async () => {
                 expect(await originalToolAStarted.promise).toBe("alpha");
                 expect(await originalToolBStarted.promise).toBe("beta");
 
-                await suspendedClient.stop();
+                await suspendedClient.forceStop();
 
                 const resumedClient = createConnectingClient(cliUrl);
                 const session2 = await resumedClient.resumeSession(sessionId, {
@@ -434,7 +434,7 @@ describe("Pending work resume", async () => {
                 expect(firstAnswer?.data.content ?? "").toContain("NO_PENDING_TURN_ONE");
 
                 await firstSession.disconnect();
-                await firstClient.stop();
+                await firstClient.forceStop();
             }
 
             const resumedClient = createConnectingClient(cliUrl);
@@ -516,7 +516,7 @@ describe("Pending work resume", async () => {
                     ).toBe("beta");
 
                     if (scenario.disconnectOriginalClient) {
-                        await suspendedClient.stop();
+                        await suspendedClient.forceStop();
                     }
 
                     const resumedClient = createConnectingClient(cliUrl);
@@ -615,7 +615,7 @@ describe("Pending work resume", async () => {
                 );
 
                 await firstSession.disconnect();
-                await firstClient.stop();
+                await firstClient.forceStop();
             }
 
             const resumedClient = createConnectingClient(cliUrl);