[Coverage Report] Test Coverage Report — 2026-06-09 #4629
Replies: 5 comments
-
|
🔮 The ancient spirits stir over discussion 4629. The smoke test agent was here, and the omens of verification are recorded.
|
Beta Was this translation helpful? Give feedback.
-
|
🔮 The ancient spirits stir, and the smoke-test agent has passed through this discussion. May the logs remain clear and the build winds be kind.
|
Beta Was this translation helpful? Give feedback.
-
|
🔮 The ancient spirits stir; the smoke test agent has visited and the signs are favorable. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Beta Was this translation helpful? Give feedback.
-
|
🔮 The ancient spirits stir, and the smoke test agent was here. The oracle has witnessed this discussion and leaves a brief sigil of passage.
|
Beta Was this translation helpful? Give feedback.
-
|
🔮 The ancient spirits stir, and the smoke test agent has passed through this discussion in silence. May the build remain sealed and the paths stay true. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
📊 Test Coverage Report — 2026-06-09
Overall Coverage
🔴 Critical Gaps (< 50% statement coverage)
None. All 155 source files are above 50% statement coverage.
🟡 Low Coverage (50–79% statement coverage)
src/commands/validators/network-options.tsThis file was introduced in the most recent commit (
7f51699) and has no dedicated test file. The uncovered code consists of 3 warning branches triggered by external Docker host detection and DinD split-filesystem hints.🛡️ Security-Critical Path Status
src/host-iptables.tssrc/squid-config.tssrc/docker-manager.tssrc/domain-patterns.tssrc/cli.tsThe four highest-risk security files (
host-iptables.ts,squid-config.ts,docker-manager.ts,domain-patterns.ts) all have near-perfect or full coverage. Thecli.tsbranch gap is cosmetic — the file is only 13 lines and the uncovered branch isrequire.main === module.📋 Full Coverage Table
All files sorted by statement coverage (lowest first)
src/commands/validators/network-options.tssrc/squid-log-reader.tssrc/services/agent-volumes/etc-mounts.tssrc/logs/audit-enricher.tssrc/services/agent-volumes/hosts-file.tssrc/artifact-preservation.tssrc/cli.tssrc/logs/log-parser.tssrc/squid/policy-manifest.tssrc/services/agent-volumes/docker-host-staging.tssrc/commands/logs-command-helpers.tssrc/dind-bootstrap.tssrc/config-writer.tssrc/services/doh-proxy-service.tssrc/commands/validators/log-and-limits.tssrc/services/host-path-prefix.tssrc/services/api-proxy-service.tssrc/services/agent-volumes/docker-socket.tssrc/logs/log-streamer.tssrc/services/agent-volumes/system-mounts.tssrc/diagnostic-collector.tssrc/commands/build-config.tssrc/commands/validators/agent-options.tssrc/services/agent-environment/environment-builder.tssrc/squid/ssl-bump.tssrc/ssl-bump.tssrc/host-env.tssrc/services/agent-volumes/workspace-mounts.tssrc/logs/log-aggregator.tssrc/upstream-proxy.tssrc/services/cli-proxy-service.tssrc/commands/main-action.tssrc/parsers/volume-parsers.tssrc/container-startup-diagnostics.tssrc/container-cleanup.tssrc/container-lifecycle.tssrc/compose-sanitizer.tssrc/commands/validators/config-assembly.tssrc/logs/log-formatter.tssrc/domain-patterns.tssrc/services/agent-service.tssrc/services/agent-volumes/home-strategy.tssrc/config-file.tssrc/rules.tssrc/compose-generator.tssrc/pid-tracker.tssrc/option-parsers.tssrc/api-proxy-config.tssrc/cli-options.tssrc/cli-workflow.tssrc/docker-manager.tssrc/domain-patterns.tssrc/host-iptables.tssrc/host-iptables-rules.tssrc/host-iptables-shared.tssrc/squid-config.tssrc/redact-secrets.tssrc/services/agent-volumes/credential-hiding.tssrc/squid/access-rules.tssrc/squid/acl-generator.tssrc/squid/domain-acl.ts🔍 Notable Findings
src/commands/validators/network-options.ts— New file, zero test coverage for warning branchesAdded in
7f51699, this 108-line file orchestrates Docker host detection, DinD hints, and domain resolution. Its 5 uncovered branches are alllogger.warn(...)paths triggered when!dockerHostCheck.validordindHintis set. A dedicated test filenetwork-options.test.tswith mockcheckDockerHost()returning invalid/dind states would close this gap entirely.src/services/agent-volumes/etc-mounts.ts— Low branch coverage (67.85%)This security-adjacent file selects which
/etcfiles are bind-mounted into the chroot. Uncovered branches likely cover missing-file fallbacks and conditional mount logic. Gaps here could mask an incorrect file exclusion (e.g., accidentally mounting/etc/shadow).src/dind-bootstrap.ts— Uncovered error paths (66.66% branch)DinD bootstrap error-handling branches are not exercised. These paths handle Docker daemon initialization failures, which are important for operational reliability in ARC/DinD environments.
Flaky test:
src/services/agent-volumes-mounts.test.tsOne test fails with:
Expected "140.82.121.4\tgithub.qkg1.top"— the hardcoded IP is stale; the actual DNS pre-resolution in CI resolvedgithub.qkg1.topto140.82.112.4. The test should use a mock resolver or a fixture DNS response rather than a live lookup result.📈 Recommendations
High — Add
src/commands/validators/network-options.test.ts: mockcheckDockerHost()to return{ valid: false }and{ dindHint: true }to cover the 5 warning branches. This is new code from this week with no tests.Medium — Add branch tests for
src/services/agent-volumes/etc-mounts.ts: cover the case where an/etcsource file is missing on the host — ensure the mount is gracefully skipped and no unexpected fallbacks expose restricted files.Low — Fix the flaky DNS test in
src/services/agent-volumes-mounts.test.ts: replace the hardcoded IP assertion (140.82.121.4) with a dynamic lookup or mock the DNS resolver so the test is environment-independent.Generated by test-coverage-reporter workflow · Trigger:
push· Commit:7f51699Beta Was this translation helpful? Give feedback.
All reactions