refactor: use map[T]struct{} for set semantics instead of map[T]bool (#29198)

Author: Copilot

pkg/sliceutil/sliceutil.go

@@ -62,11 +62,11 @@ func Any[T any](slice []T, predicate func(T) bool) bool {
 // The order of first occurrence is preserved.
 // This is a pure function that does not modify the input slice.
 func Deduplicate[T comparable](slice []T) []T {
-	seen := make(map[T]bool, len(slice))
+	seen := make(map[T]struct{}, len(slice))
 	result := make([]T, 0, len(slice))
 	for _, item := range slice {
-		if !seen[item] {
-			seen[item] = true
+		if _, ok := seen[item]; !ok {
+			seen[item] = struct{}{}
 			result = append(result, item)
 		}
 	}

pkg/stringutil/sanitize.go

@@ -19,30 +19,30 @@ var (
 	pascalCaseSecretPattern = regexp.MustCompile(`\b([A-Z][a-z0-9]*(?:[A-Z][a-z0-9]*)*(?:Token|Key|Secret|Password|Credential|Auth))\b`)
 
 	// Common non-sensitive workflow keywords to exclude from redaction
-	commonWorkflowKeywords = map[string]bool{
-		"GITHUB":            true,
-		"ACTIONS":           true,
-		"WORKFLOW":          true,
-		"RUNNER":            true,
-		"JOB":               true,
-		"STEP":              true,
-		"MATRIX":            true,
-		"ENV":               true,
-		"PATH":              true,
-		"HOME":              true,
-		"SHELL":             true,
-		"INPUTS":            true,
-		"OUTPUTS":           true,
-		"NEEDS":             true,
-		"STRATEGY":          true,
-		"CONCURRENCY":       true,
-		"IF":                true,
-		"WITH":              true,
-		"USES":              true,
-		"RUN":               true,
-		"WORKING_DIRECTORY": true,
-		"CONTINUE_ON_ERROR": true,
-		"TIMEOUT_MINUTES":   true,
+	commonWorkflowKeywords = map[string]struct{}{
+		"GITHUB":            {},
+		"ACTIONS":           {},
+		"WORKFLOW":          {},
+		"RUNNER":            {},
+		"JOB":               {},
+		"STEP":              {},
+		"MATRIX":            {},
+		"ENV":               {},
+		"PATH":              {},
+		"HOME":              {},
+		"SHELL":             {},
+		"INPUTS":            {},
+		"OUTPUTS":           {},
+		"NEEDS":             {},
+		"STRATEGY":          {},
+		"CONCURRENCY":       {},
+		"IF":                {},
+		"WITH":              {},
+		"USES":              {},
+		"RUN":               {},
+		"WORKING_DIRECTORY": {},
+		"CONTINUE_ON_ERROR": {},
+		"TIMEOUT_MINUTES":   {},
 	}
 )
 
@@ -59,7 +59,7 @@ func SanitizeErrorMessage(message string) string {
 	// Redact uppercase snake_case patterns (e.g., MY_SECRET_KEY, API_TOKEN)
 	sanitized := secretNamePattern.ReplaceAllStringFunc(message, func(match string) string {
 		// Don't redact common workflow keywords
-		if commonWorkflowKeywords[match] {
+		if _, ok := commonWorkflowKeywords[match]; ok {
 			return match
 		}
 		// Don't redact gh-aw public configuration variables (e.g., GH_AW_SKIP_NPX_VALIDATION)

pkg/workflow/validation_helpers.go

@@ -209,13 +209,13 @@ func parseStringSliceAny(raw any, log *logger.Logger) []string {
 // validateNoDuplicateIDs checks that all items have unique IDs extracted by idFunc.
 // The onDuplicate callback creates the error to return when a duplicate is found.
 func validateNoDuplicateIDs[T any](items []T, idFunc func(T) string, onDuplicate func(string) error) error {
-	seen := make(map[string]bool)
+	seen := make(map[string]struct{})
 	for _, item := range items {
 		id := idFunc(item)
-		if seen[id] {
+		if _, ok := seen[id]; ok {
 			return onDuplicate(id)
 		}
-		seen[id] = true
+		seen[id] = struct{}{}
 	}
 	return nil
 }