[WIP] Fix failing GitHub Actions job Integration: CLI MCP Other (#35200)

* Initial plan

* fix: fail fast on repo-only MCP add workflow specs

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* test: cover repo-only MCP add spec validation

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* test: align MCP tools management unit test conventions

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* test: use testify assertions for MCP spec guard tests

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

* docs: clarify repo-only MCP add spec detection

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Author: Copilot

pkg/cli/mcp_tools_management.go

@@ -3,6 +3,7 @@ package cli
 import (
 	"context"
 	"strconv"
+	"strings"
 
 	"github.com/github/gh-aw/pkg/logger"
 	"github.com/modelcontextprotocol/go-sdk/jsonrpc"
@@ -41,6 +42,14 @@ func registerAddTool(server *mcp.Server, execCmd execCmdFunc) {
 		if len(args.Workflows) == 0 {
 			return nil, nil, newMCPError(jsonrpc.CodeInvalidParams, "missing required parameter: at least one workflow specification is required", nil)
 		}
+		for _, workflowSpec := range args.Workflows {
+			if isRepositoryOnlyWorkflowSpec(workflowSpec) {
+				return nil, nil, newMCPError(jsonrpc.CodeInvalidParams, "failed to add workflows", map[string]any{
+					"error": "workflow specification must be in format 'owner/repo/workflow-name[@version]'",
+					"spec":  workflowSpec,
+				})
+			}
+		}
 
 		mcpToolsManagementLog.Printf("add tool invoked: workflows=%d, number=%d, name=%q", len(args.Workflows), args.Number, args.Name)
 
@@ -74,6 +83,17 @@ func registerAddTool(server *mcp.Server, execCmd execCmdFunc) {
 	})
 }
 
+func isRepositoryOnlyWorkflowSpec(spec string) bool {
+	if strings.HasPrefix(spec, "http://") || strings.HasPrefix(spec, "https://") || isLocalWorkflowPath(spec) {
+		return false
+	}
+
+	// Strip optional @version suffix so owner/repo@v1 is treated as repository-only.
+	specWithoutVersion := strings.SplitN(spec, "@", 2)[0]
+	slashParts := strings.Split(specWithoutVersion, "/")
+	return len(slashParts) == 2 && slashParts[0] != "" && slashParts[1] != ""
+}
+
 // updateArgs holds the input parameters for the update tool.
 type updateArgs struct {
 	Workflows []string `json:"workflows,omitempty" jsonschema:"Workflow IDs to update (empty for all workflows)"`

pkg/cli/mcp_tools_management_test.go

@@ -0,0 +1,55 @@
+//go:build !integration
+
+package cli
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestIsRepositoryOnlyWorkflowSpec(t *testing.T) {
+	tests := []struct {
+		name string
+		spec string
+		want bool
+	}{
+		{
+			name: "repo only",
+			spec: "owner/repo",
+			want: true,
+		},
+		{
+			name: "repo only with version",
+			spec: "owner/repo@v1.0.0",
+			want: true,
+		},
+		{
+			name: "repo with workflow path",
+			spec: "owner/repo/workflow",
+			want: false,
+		},
+		{
+			name: "repo with workflow path and version",
+			spec: "owner/repo/workflow@main",
+			want: false,
+		},
+		{
+			name: "github url",
+			spec: "https://github.com/owner/repo/blob/main/.github/workflows/test.md",
+			want: false,
+		},
+		{
+			name: "local path",
+			spec: "./.github/workflows/test.md",
+			want: false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := isRepositoryOnlyWorkflowSpec(tt.spec)
+			assert.Equal(t, tt.want, got, "isRepositoryOnlyWorkflowSpec(%q) should return %v", tt.spec, tt.want)
+		})
+	}
+}