fix: stop codex retries when thread already has active goal

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Author: Copilot

actions/setup/js/codex_harness.cjs

@@ -439,10 +439,11 @@ async function main() {
     }
 
     const nonRetryableGuard = detectNonRetryableHarnessGuard(result.output);
-    if (nonRetryableGuard.aiCreditsExceeded || nonRetryableGuard.awfAPIProxyBlockingRequests) {
+    if (nonRetryableGuard.aiCreditsExceeded || nonRetryableGuard.awfAPIProxyBlockingRequests || nonRetryableGuard.goalAlreadyActive) {
       const reasons = [];
       if (nonRetryableGuard.aiCreditsExceeded) reasons.push("AI credits budget exceeded");
       if (nonRetryableGuard.awfAPIProxyBlockingRequests) reasons.push("AWF API proxy is blocking requests");
+      if (nonRetryableGuard.goalAlreadyActive) reasons.push("goal is already active for this thread");
       log(`attempt ${attempt + 1}: ${reasons.join(" and ")} — not retrying (non-retryable guard condition)`);
       break;
     }

actions/setup/js/codex_harness.test.cjs

@@ -409,9 +409,11 @@ env_key = "OPENAI_API_KEY"
       if (result.exitCode === 0) return false;
       const RATE_LIMIT_ERROR_PATTERN = /rate_limit_exceeded|429 Too Many Requests|RateLimitError/i;
       const SERVER_ERROR_PATTERN = /InternalServerError|ServiceUnavailableError|500 Internal Server Error|503 Service Unavailable/i;
+      const GOAL_ALREADY_ACTIVE_PATTERN = /cannot create a new goal because this thread already has a goal|this thread already has a goal|use update_goal only when the existing goal is complete/i;
       if (attempt === 0 && isAuthenticationFailedError(result.output)) return false;
       if (isMissingApiKeyError(result.output)) return false;
       if (hasNumerousPermissionDeniedIssues(result.output)) return false;
+      if (GOAL_ALREADY_ACTIVE_PATTERN.test(result.output)) return false;
       const isTransient = RATE_LIMIT_ERROR_PATTERN.test(result.output) || SERVER_ERROR_PATTERN.test(result.output);
       return attempt < MAX_RETRIES && (result.hasOutput || isTransient);
     }
@@ -461,6 +463,15 @@ env_key = "OPENAI_API_KEY"
       const result = { exitCode: 1, hasOutput: true, output: "permission denied\npermission denied\npermission denied" };
       expect(shouldRetry(result, 0)).toBe(false);
     });
+
+    it("does not retry when codex reports an existing active goal", () => {
+      const result = {
+        exitCode: 1,
+        hasOutput: true,
+        output: "cannot create a new goal because this thread already has a goal; use update_goal only when the existing goal is complete",
+      };
+      expect(shouldRetry(result, 0)).toBe(false);
+    });
   });
 
   describe("noop pre-flight and retry guard", () => {

actions/setup/js/harness_retry_guard.cjs

@@ -5,17 +5,19 @@
 const AI_CREDITS_EXCEEDED_PATTERNS = [/\bmax[\s_-]*ai[\s_-]*credits[\s_-]*exceeded\b/i, /\bai[\s_-]*credits[\s_-]*rate[\s_-]*limit[\s_-]*error\b/i, /ai[\s_-]*credits?.*(?:rate[\s-]*limit|limit exceeded|budget exceeded|exceeded)/i];
 
 const AWF_API_PROXY_BLOCKING_REQUESTS_PATTERNS = [/\bawf\b.*\bapi[\s_-]*proxy\b.*\bblocking requests\b/i, /\bapi[\s_-]*proxy\b.*\bblocking requests\b/i, /\bapi[\s_-]*proxy\b.*\bblocked requests?\b/i, /\bDIFC_FILTERED\b/];
+const GOAL_ALREADY_ACTIVE_PATTERNS = [/\bcannot create a new goal because this thread already has a goal\b/i, /\bthis thread already has a goal\b/i, /\buse update_goal only when the existing goal is complete\b/i];
 
 /**
  * Detect retry guard conditions that should stop harness retries immediately.
  * @param {unknown} output
- * @returns {{ aiCreditsExceeded: boolean, awfAPIProxyBlockingRequests: boolean }}
+ * @returns {{ aiCreditsExceeded: boolean, awfAPIProxyBlockingRequests: boolean, goalAlreadyActive: boolean }}
  */
 function detectNonRetryableHarnessGuard(output) {
   const safeOutput = typeof output === "string" ? output : "";
   return {
     aiCreditsExceeded: AI_CREDITS_EXCEEDED_PATTERNS.some(pattern => pattern.test(safeOutput)),
     awfAPIProxyBlockingRequests: AWF_API_PROXY_BLOCKING_REQUESTS_PATTERNS.some(pattern => pattern.test(safeOutput)),
+    goalAlreadyActive: GOAL_ALREADY_ACTIVE_PATTERNS.some(pattern => pattern.test(safeOutput)),
   };
 }
 
@@ -24,5 +26,6 @@ if (typeof module !== "undefined" && module.exports) {
     detectNonRetryableHarnessGuard,
     AI_CREDITS_EXCEEDED_PATTERNS,
     AWF_API_PROXY_BLOCKING_REQUESTS_PATTERNS,
+    GOAL_ALREADY_ACTIVE_PATTERNS,
   };
 }

actions/setup/js/harness_retry_guard.test.cjs

@@ -65,5 +65,13 @@ describe("harness_retry_guard.cjs", () => {
     const result = detectNonRetryableHarnessGuard("transient network timeout");
     expect(result.aiCreditsExceeded).toBe(false);
     expect(result.awfAPIProxyBlockingRequests).toBe(false);
+    expect(result.goalAlreadyActive).toBe(false);
+  });
+
+  it("detects goal already active markers", () => {
+    const result = detectNonRetryableHarnessGuard("cannot create a new goal because this thread already has a goal; use update_goal only when the existing goal is complete");
+    expect(result.aiCreditsExceeded).toBe(false);
+    expect(result.awfAPIProxyBlockingRequests).toBe(false);
+    expect(result.goalAlreadyActive).toBe(true);
   });
 });