Skip to content

Commit c9bc82f

Browse files
Copilotpelikhan
andauthored
Fix Smoke Pi: no safe outputs due to wrong prompt order and missing gh CLI instruction (#38719)
* Initial plan * Fix Smoke Pi: inline noop-reminder and use gh CLI in test 1 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com> Co-authored-by: Peli de Halleux <pelikhan@users.noreply.github.com>
1 parent 8b368d1 commit c9bc82f

2 files changed

Lines changed: 15 additions & 12 deletions

File tree

.github/workflows/smoke-pi.lock.yml

Lines changed: 9 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/smoke-pi.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ timeout-minutes: 10
8080

8181
Execute the following tests sequentially in a single turn:
8282

83-
1. **GitHub MCP Testing**: Use GitHub MCP tools to fetch details of exactly 2 merged pull requests from ${{ github.repository }} (title and number only)
83+
1. **GitHub CLI Testing**: Use `gh` CLI commands to fetch details of exactly 2 merged pull requests from ${{ github.repository }} (title and number only)
8484
2. **Web Fetch Testing**: Use the web-fetch MCP tool to fetch https://github.com and verify the response contains "GitHub" (do NOT use bash or playwright for this test - use the web-fetch MCP tool directly)
8585
3. **File Writing Testing**: Create a test file `/tmp/gh-aw/agent/smoke-test-pi-${{ github.run_id }}.txt` with content "Smoke test passed for Pi at $(date)" (create the directory if it doesn't exist)
8686
4. **Bash Tool Testing**: Execute bash commands to verify file creation was successful (use `cat` to read the file back)
@@ -102,4 +102,8 @@ Execute the following tests sequentially in a single turn:
102102

103103
If all tests pass and this workflow was triggered by a pull_request event, use the `add_labels` safe-output tool to add the label `smoke-pi` to the pull request (omit the `item_number` parameter to auto-target the triggering PR).
104104

105-
{{#runtime-import shared/noop-reminder.md}}
105+
**Important**: If no action is needed after completing your analysis, you **MUST** call the `noop` safe-output tool with a brief explanation. Pass arguments directly to the tool. Do **NOT** wrap them under a `noop` key. Failing to call any safe-output tool is the most common cause of safe-output workflow failures.
106+
107+
```json
108+
{"message": "No action needed: [brief explanation of what was analyzed and why]"}
109+
```

0 commit comments

Comments
 (0)