Replace raw fmt.Fprintf output in outcomes_history.go with console package (#39248)

Author: Copilot

pkg/cli/outcomes_history.go

@@ -9,6 +9,7 @@ import (
 	"strconv"
 	"strings"
 
+	"github.com/github/gh-aw/pkg/console"
 	"github.com/github/gh-aw/pkg/constants"
 	ghmapping "github.com/github/gh-aw/pkg/github"
 	"github.com/github/gh-aw/pkg/workflow"
@@ -162,7 +163,7 @@ func RunOutcomesHistory(config OutcomesHistoryConfig) error {
 		return nil
 	}
 
-	fmt.Fprintf(os.Stderr, "Objective history for %s (limit %d)\n", repo, config.Limit)
+	fmt.Fprintln(os.Stderr, console.FormatSectionHeader(fmt.Sprintf("Objective history for %s (limit %d)", repo, config.Limit)))
 	if data.Issues != nil {
 		renderHistoricalObjectiveReport(*data.Issues)
 	}
@@ -295,22 +296,41 @@ func buildHistoricalObjectiveReport(source string, items []historicalGitHubItem,
 }
 
 func renderHistoricalObjectiveReport(report historicalObjectiveReport) {
-	fmt.Fprintf(os.Stderr, "\n%s\n", strings.ToUpper(report.Source))
-	fmt.Fprintf(os.Stderr, "  Sample size: %d\n", report.SampleSize)
-	fmt.Fprintf(os.Stderr, "  Scored items: %d\n", report.ScoredItems)
-	fmt.Fprintf(os.Stderr, "  Total objective value: %d\n", report.TotalObjectiveValue)
+	fmt.Fprintf(os.Stderr, "\n%s\n", console.FormatSectionHeader(strings.ToUpper(report.Source)))
+	fmt.Fprintln(os.Stderr, console.FormatInfoMessage(fmt.Sprintf("Sample size: %d", report.SampleSize)))
+	fmt.Fprintln(os.Stderr, console.FormatInfoMessage(fmt.Sprintf("Scored items: %d", report.ScoredItems)))
+	fmt.Fprintln(os.Stderr, console.FormatInfoMessage(fmt.Sprintf("Total objective value: %d", report.TotalObjectiveValue)))
 
 	if len(report.ObjectiveBuckets) > 0 {
-		fmt.Fprintln(os.Stderr, "  Top objective buckets:")
+		bucketRows := make([][]string, 0, min(len(report.ObjectiveBuckets), 8))
 		for _, bucket := range report.ObjectiveBuckets[:min(len(report.ObjectiveBuckets), 8)] {
-			fmt.Fprintf(os.Stderr, "    %-22s %3d x %3d = %4d\n", bucket.Label, bucket.Count, bucket.MappedValue, bucket.ContributedValue)
+			bucketRows = append(bucketRows, []string{
+				bucket.Label,
+				strconv.Itoa(bucket.Count),
+				strconv.Itoa(bucket.MappedValue),
+				strconv.Itoa(bucket.ContributedValue),
+			})
 		}
+		fmt.Fprint(os.Stderr, console.RenderTable(console.TableConfig{
+			Title:   "Top objective buckets",
+			Headers: []string{"Bucket", "Count", "Mapped Value", "Contributed Value"},
+			Rows:    bucketRows,
+		}))
 	}
 
 	if len(report.RepresentativeItems) > 0 {
-		fmt.Fprintln(os.Stderr, "  Representative items:")
+		itemRows := make([][]string, 0, min(len(report.RepresentativeItems), 5))
 		for _, item := range report.RepresentativeItems[:min(len(report.RepresentativeItems), 5)] {
-			fmt.Fprintf(os.Stderr, "    #%d %-3d %s\n", item.Number, item.ObjectiveValue, item.Title)
+			itemRows = append(itemRows, []string{
+				fmt.Sprintf("#%d", item.Number),
+				strconv.Itoa(item.ObjectiveValue),
+				item.Title,
+			})
 		}
+		fmt.Fprint(os.Stderr, console.RenderTable(console.TableConfig{
+			Title:   "Representative items",
+			Headers: []string{"Number", "Value", "Title"},
+			Rows:    itemRows,
+		}))
 	}
 }

pkg/cli/outcomes_history_test.go

@@ -9,6 +9,7 @@ import (
 	"testing"
 
 	ghmapping "github.com/github/gh-aw/pkg/github"
+	"github.com/github/gh-aw/pkg/testutil"
 	"github.com/spf13/cobra"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -121,6 +122,61 @@ func TestRunOutcomesHistory_JSON(t *testing.T) {
 	assert.Equal(t, 65, data.PRs.TotalObjectiveValue)
 }
 
+func TestRunOutcomesHistory_PrettyOutput(t *testing.T) {
+	oldRunGH := outcomesHistoryRunGH
+	defer func() { outcomesHistoryRunGH = oldRunGH }()
+
+	outcomesHistoryRunGH = func(spinnerMessage string, args ...string) ([]byte, error) {
+		if len(args) >= 2 && args[0] == "issue" && args[1] == "list" {
+			return []byte(`[
+				{"number":101,"title":"Automation issue","url":"https://example.com/issues/101","closedAt":"2026-06-08T00:00:00Z","labels":[{"name":"automation"}]}
+			]`), nil
+		}
+		if len(args) >= 2 && args[0] == "pr" && args[1] == "list" {
+			return []byte(`[
+				{"number":202,"title":"Testing PR","url":"https://example.com/pull/202","mergedAt":"2026-06-08T00:00:00Z","labels":[{"name":"testing"}]}
+			]`), nil
+		}
+		return nil, assert.AnError
+	}
+
+	require.NoError(t, os.Setenv("OBJECTIVE_MAPPING_JSON", `{"label_to_value":{"automation":40,"testing":65},"multi_label_logic":"max"}`))
+	t.Cleanup(func() { os.Unsetenv("OBJECTIVE_MAPPING_JSON") })
+
+	stderr := testutil.CaptureStderr(t, func() {
+		err := RunOutcomesHistory(OutcomesHistoryConfig{RepoOverride: "owner/repo", JSONOutput: false, Limit: 10, Source: historySourceAll})
+		require.NoError(t, err)
+	})
+
+	// Top-level section header.
+	assert.Contains(t, stderr, "Objective history for owner/repo (limit 10)")
+
+	// Issues section header.
+	assert.Contains(t, stderr, "ISSUES")
+
+	// Issues stats.
+	assert.Contains(t, stderr, "Sample size: 1")
+	assert.Contains(t, stderr, "Scored items: 1")
+	assert.Contains(t, stderr, "Total objective value: 40")
+
+	// Issues bucket table title and headers.
+	assert.Contains(t, stderr, "Top objective buckets")
+	assert.Contains(t, stderr, "Bucket")
+	assert.Contains(t, stderr, "Mapped Value")
+	assert.Contains(t, stderr, "Contributed Value")
+
+	// Issues representative items table title and headers.
+	assert.Contains(t, stderr, "Representative items")
+	assert.Contains(t, stderr, "Number")
+	assert.Contains(t, stderr, "Title")
+
+	// PRs section header.
+	assert.Contains(t, stderr, "PRS")
+
+	// PRs stats.
+	assert.Contains(t, stderr, "Total objective value: 65")
+}
+
 func TestNewOutcomesHistorySubcommand_InheritsGlobalVerboseFlag(t *testing.T) {
 	cmd := NewOutcomesHistorySubcommand()
 	require.NotNil(t, cmd)