🛠️ Improve error messaging for branch sync failure (#23155)

* improve message

* Update actions/setup/js/extra_empty_commit.cjs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* commit

* fix: update test to expect core.warning instead of core.info for sync failure

Agent-Logs-Url: https://github.com/github/gh-aw/sessions/dbb38263-3c2a-480d-acfe-977413337ce6

Co-authored-by: dsyme <7204669+dsyme@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: dsyme <7204669+dsyme@users.noreply.github.com>

Author: 3 people

actions/setup/js/extra_empty_commit.cjs

@@ -147,10 +147,11 @@ async function pushExtraEmptyCommit({ branchName, repoOwner, repoName, commitMes
     try {
       await exec.exec("git", ["fetch", "ci-trigger", branchName]);
       await exec.exec("git", ["reset", "--hard", `ci-trigger/${branchName}`]);
-    } catch {
+    } catch (error) {
       // Non-fatal: if fetch/reset fails (e.g. branch not yet on remote), continue
       // with the local HEAD and attempt the push anyway.
-      core.info(`Could not sync local branch with remote ${branchName} - will attempt push with local HEAD`);
+      const syncErrorMessage = error instanceof Error ? error.message : String(error);
+      core.warning(`Could not sync local branch with remote ${branchName} - will attempt push with local HEAD. Underlying error: ${syncErrorMessage}`);
     }
 
     // Create and push an empty commit

actions/setup/js/extra_empty_commit.test.cjs

@@ -222,7 +222,7 @@ describe("extra_empty_commit.cjs", () => {
 
       // Push should still be attempted and succeed (mock returns 0 for push)
       expect(result).toEqual({ success: true });
-      expect(mockCore.info).toHaveBeenCalledWith(expect.stringContaining("Could not sync local branch"));
+      expect(mockCore.warning).toHaveBeenCalledWith(expect.stringContaining("Could not sync local branch"));
 
       // commit and push should still have been called
       const commitCall = mockExec.exec.mock.calls.find(c => c[0] === "git" && c[1] && c[1][0] === "commit");